From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52E6C43217 for ; Thu, 30 Sep 2021 18:31:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F54861555 for ; Thu, 30 Sep 2021 18:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229534AbhI3Sd1 (ORCPT ); Thu, 30 Sep 2021 14:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhI3Sd0 (ORCPT ); Thu, 30 Sep 2021 14:33:26 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B3EBC06176C for ; Thu, 30 Sep 2021 11:31:43 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id s17so25015782edd.8 for ; Thu, 30 Sep 2021 11:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=57Llzgrk8lHt7Xo2P5Ng2+YQoTMIOMCchXp4xSgknMk=; b=qCNHubRpYsl2KShLEgoKcAg1XkM+flFqwpUFpfl2SvYHun9wUbaWdDYiyGjRW2Jsbd VdQPKfO3YnpxBAihCSVu2sOPft8zM0KJl86yBloC1fLvkwYL0S4GdRmD/0hggep9YwD9 M7eYKSXF1d4Kv0w91VICm13eNfB1YVm2D23lLykPv0sObzl+HuVastAApQNKEWHimaQv AMigogxGRcuLGSCvEbq9IsWR/Lk5JMywo3O3KQw8oWHJHJ3NkRLsy1Ii4ldoY8ObOIY8 mD0cGvrtuz/hGR+0Cx6y5rhF0voZzYTfUA/rJNTJTdCqeD2k4AGzWL1Uwpj/sK7tmQE6 tgvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=57Llzgrk8lHt7Xo2P5Ng2+YQoTMIOMCchXp4xSgknMk=; b=TJK20KATJWphh5AdIvUmmZkGTxRxj8LhAIrCjkaTM+CPnidXs0udIjv8Z7W1v225CG srSi0X53EZH/RIDS9hcF/cRgoRH4P3AjXA3a0Ux/ln3Acj+/oYuip1fjDt08sh6ERjWS hrayVBcROdJHlHmEbILI5E9z22ZvSU1c6M73CdMMlCpD6xa8IsvaawJFpuhPAZgRFcDW sTDjHUEDxKuEHvyvIdaw2NamNguheXTKizb9RapbEZJjOOrlxcXUWpQUUobffLzHWOdO rHeEoQM3rdRMj3zfAs1873tT/Z38JN7zpKpkHv+TID1zJ/6KEx/Y2EZlUXx5SFpQOW5Y VApw== X-Gm-Message-State: AOAM530xXBLE89JiHAQfZUcljln7Qs1EqAbwtFr7vqjeH7FZQ2w+7qIe JA9x+jP4sSaUxliOBbjbK+vqx1Jxv1lXTM2GIt8afg== X-Google-Smtp-Source: ABdhPJzlSNDKjr2XQYyGWvZ6wVqvdu6JiqBsgpApQl0wZaMzJq4PH9as3kJjSkfYWfTwWQP4lOv/sqEpvKhejHkecug= X-Received: by 2002:a17:907:9908:: with SMTP id ka8mr905842ejc.164.1633026701077; Thu, 30 Sep 2021 11:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-3-willmcvicker@google.com> In-Reply-To: From: Will McVicker Date: Thu, 30 Sep 2021 11:31:23 -0700 Message-ID: Subject: Re: [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended To: John Stultz Cc: Russell King , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Linus Walleij , Alessandro Zummo , Alexandre Belloni , Thomas Gleixner , Lee Jones , Geert Uytterhoeven , Saravana Kannan , Android Kernel Team , linux-arm-kernel , lkml , Linux Samsung SOC , "open list:COMMON CLK FRAMEWORK" , "open list:GPIO SUBSYSTEM" , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Thanks for the suggestion. That makes sense. I'll look into that for the next version. --Will On Wed, Sep 29, 2021 at 1:46 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 1:01 PM Will McVicker wrote: > > On Tue, Sep 28, 2021 at 8:42 PM John Stultz wrote: > > > On Tue, Sep 28, 2021 at 4:56 PM Will McVicker wrote: > > > > > > > > This allows modules to access the value of timekeeping_suspended without > > > > giving them write access to the variable. > > > > > > > > > > It's important to cover "the why" not "the what" in these commit > > > messages, so you might add a note as to what code will be the user of > > > this (the samsung/clk-pll.c code changed later in this series). > > > > > > thanks > > > -john > > > > Thanks John for the tip. I will try to be better at that in the followup. > > I have to remind myself regularly as well. :) Apologies if my quick > reply above seemed curt (as it does to me re-reading it now). Wasn't > my intent. > > > For this specific patch, I am adding this new API because the Samsung > > PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the > > variable 'timekeeping_suspended' to detect timeouts before the > > clocksource is initialized or timekeeping itself is suspended. My > > patch series aims to modularize the Samsung PLL driver. So to keep the > > driver's functionality intact, I need to add this additional API. > > Sounds good! > > Another small/medium suggestion: Since you're adding a new interface > for non-core users of timekeeping_suspended, it might be good to > switch the other users as well (seems like just > drivers/clk/ti/clkctrl.c and kernel/sched/clock.c), then also remove > the extern in include/linux/timekeeping.h (so there's one consistent > method to access it)? I know it's a sort of scope creep, so apologies > for asking, but it would make the series more attractive if it's not > leaving something for others to clean up later. > > thanks > -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31FCBC433FE for ; Thu, 30 Sep 2021 18:52:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2B2361368 for ; Thu, 30 Sep 2021 18:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2B2361368 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9n+6qtyGNtIqIvTDroedBNUIDxHkvbpavLtI1SA3a7I=; b=FSxq/u7g9NPcwQ kpuaaJ9Z63ILSxCJ3ZPuXE4dauJshmPiygKc4HkBkjboAjOcjspK113sNpM8jj4xBHdABjZDXJVHW 9O0XGDECYxHeWPcmtsLAXkvZWgr/53BKI1eOSrjYbCm2j5jvgLn09kgXrid+STLpYqASBb5rCFfAU Qv1YiCpF+VI974yGWNKSlHdwNPmIP+piGwE70tKgZ9YrFaUkZUQIvV9knBQ50aiDT2QwKp8vK0vdM 97VV1ka+Kk8six94laPOs6yrvKICmMIg4QHOCYsc5QayelHNyHyk05BVM9ak9e9G//Ne0scR8La9v zZcNRFNyc1Kss90vNQrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW17u-00FhnZ-Dh; Thu, 30 Sep 2021 18:49:51 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW0qN-00Faii-GN for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 18:31:44 +0000 Received: by mail-ed1-x530.google.com with SMTP id bd28so25563999edb.9 for ; Thu, 30 Sep 2021 11:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=57Llzgrk8lHt7Xo2P5Ng2+YQoTMIOMCchXp4xSgknMk=; b=qCNHubRpYsl2KShLEgoKcAg1XkM+flFqwpUFpfl2SvYHun9wUbaWdDYiyGjRW2Jsbd VdQPKfO3YnpxBAihCSVu2sOPft8zM0KJl86yBloC1fLvkwYL0S4GdRmD/0hggep9YwD9 M7eYKSXF1d4Kv0w91VICm13eNfB1YVm2D23lLykPv0sObzl+HuVastAApQNKEWHimaQv AMigogxGRcuLGSCvEbq9IsWR/Lk5JMywo3O3KQw8oWHJHJ3NkRLsy1Ii4ldoY8ObOIY8 mD0cGvrtuz/hGR+0Cx6y5rhF0voZzYTfUA/rJNTJTdCqeD2k4AGzWL1Uwpj/sK7tmQE6 tgvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=57Llzgrk8lHt7Xo2P5Ng2+YQoTMIOMCchXp4xSgknMk=; b=vaM5NAeuHtuP3we8OjU1SMdRLjzs46zxx2tAD/NHtkcyi0wfIs3h6Cejz+0OPbi1kP yyxCjgApLzYKIDph2seg7IiWyZYP2f9UoUS8IY0sc+IojZGRadaG3ue/KDxYdVA6p6MX 2w1kFQtRAw/6myt1+uOKO5hzN42iItZw5Pp7CicgT3nQSUStUW41zMpX0exDFGrsv4Sw RQ4Y4uPyBC9bYK4/RPvnagTSTA/MHgs2J+rv9gIxehIcKrsUhlA9kL2Mr7jJQiknvD0P S53yzukjAK2YUAENt8mr90myWcdfsvGCxhK4JXunoQ7vHE143WcevSRez1OEpWsD5SEu pCWA== X-Gm-Message-State: AOAM530UENt93RLIezWMCpyZCiwS8kFt6RHX9fod/OO/QE0zxtuT5mUp PIajoRPd2e9th74E89eIImH0zG6zuvoGIA4jFCUh2A== X-Google-Smtp-Source: ABdhPJzlSNDKjr2XQYyGWvZ6wVqvdu6JiqBsgpApQl0wZaMzJq4PH9as3kJjSkfYWfTwWQP4lOv/sqEpvKhejHkecug= X-Received: by 2002:a17:907:9908:: with SMTP id ka8mr905842ejc.164.1633026701077; Thu, 30 Sep 2021 11:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-3-willmcvicker@google.com> In-Reply-To: From: Will McVicker Date: Thu, 30 Sep 2021 11:31:23 -0700 Message-ID: Subject: Re: [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended To: John Stultz Cc: Russell King , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Linus Walleij , Alessandro Zummo , Alexandre Belloni , Thomas Gleixner , Lee Jones , Geert Uytterhoeven , Saravana Kannan , Android Kernel Team , linux-arm-kernel , lkml , Linux Samsung SOC , "open list:COMMON CLK FRAMEWORK" , "open list:GPIO SUBSYSTEM" , linux-rtc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_113143_580764_6F05EB7B X-CRM114-Status: GOOD ( 31.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for the suggestion. That makes sense. I'll look into that for the next version. --Will On Wed, Sep 29, 2021 at 1:46 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 1:01 PM Will McVicker wrote: > > On Tue, Sep 28, 2021 at 8:42 PM John Stultz wrote: > > > On Tue, Sep 28, 2021 at 4:56 PM Will McVicker wrote: > > > > > > > > This allows modules to access the value of timekeeping_suspended without > > > > giving them write access to the variable. > > > > > > > > > > It's important to cover "the why" not "the what" in these commit > > > messages, so you might add a note as to what code will be the user of > > > this (the samsung/clk-pll.c code changed later in this series). > > > > > > thanks > > > -john > > > > Thanks John for the tip. I will try to be better at that in the followup. > > I have to remind myself regularly as well. :) Apologies if my quick > reply above seemed curt (as it does to me re-reading it now). Wasn't > my intent. > > > For this specific patch, I am adding this new API because the Samsung > > PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the > > variable 'timekeeping_suspended' to detect timeouts before the > > clocksource is initialized or timekeeping itself is suspended. My > > patch series aims to modularize the Samsung PLL driver. So to keep the > > driver's functionality intact, I need to add this additional API. > > Sounds good! > > Another small/medium suggestion: Since you're adding a new interface > for non-core users of timekeeping_suspended, it might be good to > switch the other users as well (seems like just > drivers/clk/ti/clkctrl.c and kernel/sched/clock.c), then also remove > the extern in include/linux/timekeeping.h (so there's one consistent > method to access it)? I know it's a sort of scope creep, so apologies > for asking, but it would make the series more attractive if it's not > leaving something for others to clean up later. > > thanks > -john _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel