From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91055C433F5 for ; Mon, 20 Sep 2021 21:00:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 579D160F70 for ; Mon, 20 Sep 2021 21:00:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 579D160F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h0DFktVxv2LwvpvSSDKyFejDzA70g8ypyQ+oBKZNaRk=; b=BvhxkucpBLy06Q qAJ3jjudh56bqpmlMQHhpaArD1CoNc9gyZlBUl79LWj/CYHHMYtOHRNetKth0B29QzHP4eZy2AuQg +o5PYAzUhc8/KSQdC2iLQ9CmpjMrDbfipM2XGItzJ8ujrrFrVLTESfwNVqo8ZL1zefkAcpTKFqMr7 Q3PAt6L32O1EuxgIix5Kwp7b1WeusMsjH0YOcADQgL8k2ZxM1PuFxKG/l+xflhI1UddBOlKJkAQ6P 5bcqPbMqiB2w7+DfJjKL7UYCHJG5rm6XdzLhMfWhkO8qj4HPU1zLRpsMk0WsiGWF3Bo/yQkwxQk+Z BGXqH8ZsxNdD/W7pSSPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSQMn-0036Ce-8x; Mon, 20 Sep 2021 20:58:21 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSQMf-0036A0-3y for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 20:58:14 +0000 Received: by mail-ed1-x532.google.com with SMTP id g8so66391797edt.7 for ; Mon, 20 Sep 2021 13:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PC43tSgvhG7E0sEr+EdWjU4dUcDPCSX0FiAfZowtiZg=; b=nIMzEFRDbWw1z1g6+GhQbUl4DUvtylQpDP+jTHJoTenS8HI5r6M2ar3tFGhFvpuB9F QKXYIBNORPCzuiHLY0Ld/nyW4dWGSehFCuhVm4/g8RmFM5FHXd2YbKZ0ZWsZ6cjTQAAd rAeadVgIdfLtKpLv6nlbwU3BXfVWapw1JmfSgEVRKGbtNH3n+9mOlsTSffV7gW6rR8vl xqgtFQ70JnuH6tJCFZeN5B4s4aEyaXppka2q2ezEQUu6yee/X+ppufw0EYuEuEeXLtql 9Fu+/Ttw3V4LZ+4ainPQa1WcvPUqJwVQdxIVp8zEDKfgATa9jJTmhHMY7ds0Fs4pA4f5 h7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PC43tSgvhG7E0sEr+EdWjU4dUcDPCSX0FiAfZowtiZg=; b=phxSWAI1k6V1jGlrawygBS+C88A7/LZbbhJ0wBwmi+trISdZqsHxC75J+5YJHHhwug naX6mZMAEl2hKFMTJupN1RHgRhjOQL/QtGW4CsoX4pWO1Jj4ed3f0wWRZcBSeyeCCJDO y1lam9KzQE0k31Li6FvFxZ7R6ZRtfaDekM+8+A1wd60dZkgZLr8JHYVhYVab6zxxiPNX JS6xMdmcSN0Ls+xDX5ksMNrHS4XfjTAhhYnRatKOojGOK6X/zWN9JFktunZvF8bKj/UE M1xbhr8Uic9PDpnzeUhEswxJHolh7LJDPmGPfhdc2ThoQ4lwUrYis4GhCb0b685cZP1b 51ug== X-Gm-Message-State: AOAM532MmTO5ZzPZbq9ycP49uTX13GgiFyWIUFuU8sJKUnCNi/q898q0 iubCvdKk2KaQUvTxtYuUYR9ScfZGh5WxFTGST4klcA== X-Google-Smtp-Source: ABdhPJx5e1g4BROAxqXoTN8Q7cw00CNUSRPKmEtwEG/MNdxn3PAjt/9c1I+re1VC08Eb6LibgwFMTXauNkekkW2yQRk= X-Received: by 2002:a17:906:3a58:: with SMTP id a24mr17992046ejf.67.1632171491324; Mon, 20 Sep 2021 13:58:11 -0700 (PDT) MIME-Version: 1.0 References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> In-Reply-To: <20210920190350.3860821-3-willmcvicker@google.com> From: Will McVicker Date: Mon, 20 Sep 2021 13:57:55 -0700 Message-ID: Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic To: Catalin Marinas , Will Deacon , Krzysztof Kozlowski Cc: Lee Jones , "Cc: Android Kernel" , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-samsung-soc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_135813_238099_A0D58E62 X-CRM114-Status: GOOD ( 22.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 20, 2021 at 12:04 PM Will McVicker wrote: > > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to > be enabled by default via "default y if ARCH_EXYNOS" versus being > selected by the ARCH_EXYNOS config directly. This allows vendors to > disable these configs if they wish and provides additional flexibility > to modularize them in the presence of a generic kernel. > > There are no .config differences with this change. The configs > SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still > remain enabled by default. > > Signed-off-by: Will McVicker > --- > arch/arm64/Kconfig.platforms | 4 ---- > drivers/soc/samsung/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 3a66ed43088d..6a006490c9b9 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,14 +91,10 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select EXYNOS_CHIPID > - select EXYNOS_PM_DOMAINS if PM_GENERIC_DOMAINS > - select EXYNOS_PMU > select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PINCTRL_EXYNOS > select PM_GENERIC_DOMAINS if PM > - select SOC_SAMSUNG > help > This enables support for ARMv8 based Samsung Exynos SoC family. > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 5745d7e5908e..9402c02bc9de 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -4,6 +4,7 @@ > # > menuconfig SOC_SAMSUNG > bool "Samsung SoC driver support" if COMPILE_TEST > + default y if ARCH_EXYNOS > > if SOC_SAMSUNG > > @@ -15,6 +16,7 @@ config EXYNOS_ASV_ARM > config EXYNOS_CHIPID > bool "Exynos ChipID controller and ASV driver" if COMPILE_TEST > depends on ARCH_EXYNOS || COMPILE_TEST > + default y if ARCH_EXYNOS > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > @@ -24,6 +26,7 @@ config EXYNOS_CHIPID > config EXYNOS_PMU > bool "Exynos PMU controller driver" if COMPILE_TEST > depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST) > + default y if ARCH_EXYNOS > select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS > > # There is no need to enable these drivers for ARMv8 > @@ -34,6 +37,7 @@ config EXYNOS_PMU_ARM_DRIVERS > config EXYNOS_PM_DOMAINS > bool "Exynos PM domains" if COMPILE_TEST > depends on (ARCH_EXYNOS && PM_GENERIC_DOMAINS) || COMPILE_TEST > + default y if (ARCH_EXYNOS && PM_GENERIC_DOMAINS) > > config SAMSUNG_PM_DEBUG > bool "Samsung PM Suspend debug" > -- > 2.33.0.464.g1972c5931b-goog > Sorry I didn't see this patch sent yesterday: https://lore.kernel.org/lkml/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com/ Looks like Krzysztof's patch covers my portion of the patch related to EXYNOS_CHIPID. I'll keep an eye on his patch as it goes through and will modify mine as needed since it's likely to come in after. Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F61C433EF for ; Tue, 21 Sep 2021 01:44:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B77F60F6D for ; Tue, 21 Sep 2021 01:44:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232814AbhIUBp0 (ORCPT ); Mon, 20 Sep 2021 21:45:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233526AbhIUBlc (ORCPT ); Mon, 20 Sep 2021 21:41:32 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1586C04CD1B for ; Mon, 20 Sep 2021 13:58:12 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id eg28so43605717edb.1 for ; Mon, 20 Sep 2021 13:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PC43tSgvhG7E0sEr+EdWjU4dUcDPCSX0FiAfZowtiZg=; b=nIMzEFRDbWw1z1g6+GhQbUl4DUvtylQpDP+jTHJoTenS8HI5r6M2ar3tFGhFvpuB9F QKXYIBNORPCzuiHLY0Ld/nyW4dWGSehFCuhVm4/g8RmFM5FHXd2YbKZ0ZWsZ6cjTQAAd rAeadVgIdfLtKpLv6nlbwU3BXfVWapw1JmfSgEVRKGbtNH3n+9mOlsTSffV7gW6rR8vl xqgtFQ70JnuH6tJCFZeN5B4s4aEyaXppka2q2ezEQUu6yee/X+ppufw0EYuEuEeXLtql 9Fu+/Ttw3V4LZ+4ainPQa1WcvPUqJwVQdxIVp8zEDKfgATa9jJTmhHMY7ds0Fs4pA4f5 h7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PC43tSgvhG7E0sEr+EdWjU4dUcDPCSX0FiAfZowtiZg=; b=Ab62gx47FGBx14T7mJ3xIyH1Slzrcyj9u9MIO8HI6qeDad84thOnlsxEUMEKtSXE2s vuW2uFD2a4sKjgp6IvU2Mf1K+nQGLcOTz6TMtN9jrpm7yNNA/rEOAhhQxzlNxZdubiVk f2qQ+P2RqjvDlcSiBkubmb7ejXPDGazgu/DJ6av61O7exR18Qx5AmUtdXAmLLOHbtYSl sQMB/1Iruex8XtRRccCOj/3QHClhRXSM+JYVSdZiQwniICzXlBp594jXyZv9oIvrHL4E DvRa0Y9TtV5U9URjHhyTezV16c+Ew3X1X+uTkqrcQHpaHvaJIQzf/kmJp0JR0Pj113M0 mF0g== X-Gm-Message-State: AOAM530erohXSBuBlCFIbcs49W7K7JW/HpUWPbSyzk/2cbAbo4IbghuP HB6VlJh6p6ZMjdOn34KIindcLKjcuw5ld9lcNR15grVLvUDq5w== X-Google-Smtp-Source: ABdhPJx5e1g4BROAxqXoTN8Q7cw00CNUSRPKmEtwEG/MNdxn3PAjt/9c1I+re1VC08Eb6LibgwFMTXauNkekkW2yQRk= X-Received: by 2002:a17:906:3a58:: with SMTP id a24mr17992046ejf.67.1632171491324; Mon, 20 Sep 2021 13:58:11 -0700 (PDT) MIME-Version: 1.0 References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> In-Reply-To: <20210920190350.3860821-3-willmcvicker@google.com> From: Will McVicker Date: Mon, 20 Sep 2021 13:57:55 -0700 Message-ID: Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic To: Catalin Marinas , Will Deacon , Krzysztof Kozlowski Cc: Lee Jones , "Cc: Android Kernel" , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 12:04 PM Will McVicker wrote: > > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to > be enabled by default via "default y if ARCH_EXYNOS" versus being > selected by the ARCH_EXYNOS config directly. This allows vendors to > disable these configs if they wish and provides additional flexibility > to modularize them in the presence of a generic kernel. > > There are no .config differences with this change. The configs > SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still > remain enabled by default. > > Signed-off-by: Will McVicker > --- > arch/arm64/Kconfig.platforms | 4 ---- > drivers/soc/samsung/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 3a66ed43088d..6a006490c9b9 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,14 +91,10 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select EXYNOS_CHIPID > - select EXYNOS_PM_DOMAINS if PM_GENERIC_DOMAINS > - select EXYNOS_PMU > select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PINCTRL_EXYNOS > select PM_GENERIC_DOMAINS if PM > - select SOC_SAMSUNG > help > This enables support for ARMv8 based Samsung Exynos SoC family. > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 5745d7e5908e..9402c02bc9de 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -4,6 +4,7 @@ > # > menuconfig SOC_SAMSUNG > bool "Samsung SoC driver support" if COMPILE_TEST > + default y if ARCH_EXYNOS > > if SOC_SAMSUNG > > @@ -15,6 +16,7 @@ config EXYNOS_ASV_ARM > config EXYNOS_CHIPID > bool "Exynos ChipID controller and ASV driver" if COMPILE_TEST > depends on ARCH_EXYNOS || COMPILE_TEST > + default y if ARCH_EXYNOS > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > @@ -24,6 +26,7 @@ config EXYNOS_CHIPID > config EXYNOS_PMU > bool "Exynos PMU controller driver" if COMPILE_TEST > depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST) > + default y if ARCH_EXYNOS > select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS > > # There is no need to enable these drivers for ARMv8 > @@ -34,6 +37,7 @@ config EXYNOS_PMU_ARM_DRIVERS > config EXYNOS_PM_DOMAINS > bool "Exynos PM domains" if COMPILE_TEST > depends on (ARCH_EXYNOS && PM_GENERIC_DOMAINS) || COMPILE_TEST > + default y if (ARCH_EXYNOS && PM_GENERIC_DOMAINS) > > config SAMSUNG_PM_DEBUG > bool "Samsung PM Suspend debug" > -- > 2.33.0.464.g1972c5931b-goog > Sorry I didn't see this patch sent yesterday: https://lore.kernel.org/lkml/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com/ Looks like Krzysztof's patch covers my portion of the patch related to EXYNOS_CHIPID. I'll keep an eye on his patch as it goes through and will modify mine as needed since it's likely to come in after. Thanks, Will