From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0005C433FE for ; Tue, 21 Sep 2021 17:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8EC761178 for ; Tue, 21 Sep 2021 17:46:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbhIURre (ORCPT ); Tue, 21 Sep 2021 13:47:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231695AbhIURr3 (ORCPT ); Tue, 21 Sep 2021 13:47:29 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83CAFC061575 for ; Tue, 21 Sep 2021 10:46:00 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id v24so77389580eda.3 for ; Tue, 21 Sep 2021 10:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mQQDt3jbAZk0CeTPaKtXUkqjBcabdWOVqUMSrb9IMC0=; b=poXvbJmwz7vtECOa8f4BEix3x6KuyVodHQ2LT+fkzIYCmN5rc76INwCnGGLT7qMVqc elcQ8C14+wB3V3wLRTD3DsYkPnn4CSNAGxM2tbViuRIyeEDDbfalqJBgsIn6Fb03IA8h 8/P5ccMVHF7gsNL7oHpYm4rL2ALddvSQGOMddTuujSQL9TACdsPiW2unJcL6yJg8oJ9h cZmqqzIxudo6uVBkm+erLwneUnyhOo5v2IC6pGR7r8z5DB/DCjLGEN5vQ3Pjj1nzBlmK 9ir6qQxejsnqbuzuC+xYKr/TTDEcJlsbpkABxYUc6yrNZwSFV+yVzKEzisvnbPHzFbf3 IksQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mQQDt3jbAZk0CeTPaKtXUkqjBcabdWOVqUMSrb9IMC0=; b=fcKGc8Z+BO30sTggBiOtpAm47eZS+Y6zdx0Mf9HHww+cd/xAz7SDo6pYIS60rmFRwJ epJhU9DN+NOmlI12v1YSej1Wluk8FPIDfqAtHIh12OuHyF2bnbRAjbeXRgC/CzE1NorB WhqFHyWjZNKO4JQHM2CUXjHxiks6SUyKArlYyQDD9JMwm+bAjLb0OilBCnlPWWD5GufV Drvco+JINyZfBhF2mkOOQHJsLeeZNd65CqY5iLwZoPgKkrye+rSU5/+E8MyOvhYxZ+v0 QBBGnHTtHqcf4i1emRAsVlQAAUYDvwv7Fy7i42gdZo6HMnvyjpiuq5LvIlHRZrKd4+I4 u1Nw== X-Gm-Message-State: AOAM531fJ3E54CmQm5jfVESkzIBSSiLdBAISTa055Y4GJhf1ch8x/dpb kFnI2qewBxO7fDTz7R4+2kBQNOevMuoRkdJDn6+/+Q== X-Google-Smtp-Source: ABdhPJwJbT/0NCvATNDegKI0IJETlYRX/RpirpTKRe62opaMokm4pqc+Vgau2G/y5TKgjLalAWmvyhKQx5wVPu1rhXc= X-Received: by 2002:a50:e044:: with SMTP id g4mr5779430edl.46.1632246358716; Tue, 21 Sep 2021 10:45:58 -0700 (PDT) MIME-Version: 1.0 References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> In-Reply-To: From: Will McVicker Date: Tue, 21 Sep 2021 10:45:42 -0700 Message-ID: Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic To: Lee Jones Cc: Krzysztof Kozlowski , Catalin Marinas , Will Deacon , "Cc: Android Kernel" , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 1:19 AM Lee Jones wrote: > > On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: > > > On 20/09/2021 21:03, Will McVicker wrote: > > > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs t= o > > > be enabled by default via "default y if ARCH_EXYNOS" versus being > > > selected by the ARCH_EXYNOS config directly. This allows vendors to > > > disable these configs if they wish and provides additional flexibilit= y > > > to modularize them in the presence of a generic kernel. > > > > This is not true. Vendors cannot disable these options as they are not > > visible. > > Good point, well made. > > > Although I understand that Arnd prefers this way and I do not > > object it, but your explanation is incorrect. Thanks Krzysztof for the reviews! I'm sorry I missed the whole "hidden configs" part. I'll upload the series to include the fix that refactos the Samsung SoC drivers menuconfig which will address that and allow one to enable/disable those configs. I'm going to hold off though until we hash out the rest of the discussion in the cover letter email. Thanks, Will > > -- > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] > Senior Technical Lead - Developer Services > Linaro.org =E2=94=82 Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1132C433EF for ; Tue, 21 Sep 2021 17:48:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9AF560EDF for ; Tue, 21 Sep 2021 17:48:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B9AF560EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zhW2n63huuXDY39HOYVjSaboSlSCGmE6xb1K4lb5hGg=; b=FwytIt2/wG3qFf +P3bFNS27s9k2JOW8rRT397m3trCmqNSj5mx6oTnh7KzDzv2nDKktovtD6Bw+QiQzAKb0k4N83tlW JEZBHaj/CgsfmPTs+t/4KlZ6PZ/abSH6nVUO+L4WaO+s26DXzvt5W60/UNmi16hUaSmrfo6FeaX+x N0xbZM1lWeFk6beqaOKJ2x/k8kUvAygDhEtWpUF9JlJdG2FJ1cRLDDf17xfR5pHiuRLbxcJ5mYJPt xsnQSJRapHlseUz3uiF03GQOET9x847l0w9R4bA6e8OeFcCN2nr8dHIOqEhkp4z88UtNGrJgU+xN2 ChGgQa2E4HoeVxV9Dl/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSjqL-005NKs-Sl; Tue, 21 Sep 2021 17:46:10 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSjqE-005NIc-H8 for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 17:46:05 +0000 Received: by mail-ed1-x530.google.com with SMTP id g8so77430142edt.7 for ; Tue, 21 Sep 2021 10:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mQQDt3jbAZk0CeTPaKtXUkqjBcabdWOVqUMSrb9IMC0=; b=poXvbJmwz7vtECOa8f4BEix3x6KuyVodHQ2LT+fkzIYCmN5rc76INwCnGGLT7qMVqc elcQ8C14+wB3V3wLRTD3DsYkPnn4CSNAGxM2tbViuRIyeEDDbfalqJBgsIn6Fb03IA8h 8/P5ccMVHF7gsNL7oHpYm4rL2ALddvSQGOMddTuujSQL9TACdsPiW2unJcL6yJg8oJ9h cZmqqzIxudo6uVBkm+erLwneUnyhOo5v2IC6pGR7r8z5DB/DCjLGEN5vQ3Pjj1nzBlmK 9ir6qQxejsnqbuzuC+xYKr/TTDEcJlsbpkABxYUc6yrNZwSFV+yVzKEzisvnbPHzFbf3 IksQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mQQDt3jbAZk0CeTPaKtXUkqjBcabdWOVqUMSrb9IMC0=; b=209G1mG4Kc5/t/PtmWNi3d4iGwW57tDE17rZMSiyFiz9XrItsDNU7RywZAsfWafTS5 NCiVYHlqhRSMGhKGht8qQXftPIZi5SXDnp/kkBs+MMgw25dSry7oMjfaPIpRJOrC2Ow8 pYDkvjo/+KqlyOtmrUu7fkc8tbnbtj9lu85jXDP+JlRz/khc5YkfDSkXA2412OLrPl2a IqX9pzgh23lmcxOdD6512arK8g/xQMYJo1F1e9ZU6qmp8v9+ZzM1sPSUTRvkOwSytOkA FMDyvsRtQTdMlfHpIlvAUNkvdp7EDt55fVoulkiXpvrGXxG8yOXYwaVzsM41WTl7q5yb HBSQ== X-Gm-Message-State: AOAM533PX2f0iKar5c3BHmibxDh7a6j/XNhnuWeS0ENmI0iOJQ3I+XaB ck+EoXfk2BLMsMDFhPzUXQQvD5w1lhcuodfk59KHxA== X-Google-Smtp-Source: ABdhPJwJbT/0NCvATNDegKI0IJETlYRX/RpirpTKRe62opaMokm4pqc+Vgau2G/y5TKgjLalAWmvyhKQx5wVPu1rhXc= X-Received: by 2002:a50:e044:: with SMTP id g4mr5779430edl.46.1632246358716; Tue, 21 Sep 2021 10:45:58 -0700 (PDT) MIME-Version: 1.0 References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> In-Reply-To: From: Will McVicker Date: Tue, 21 Sep 2021 10:45:42 -0700 Message-ID: Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic To: Lee Jones Cc: Krzysztof Kozlowski , Catalin Marinas , Will Deacon , "Cc: Android Kernel" , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-samsung-soc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_104602_636603_77502089 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBTZXAgMjEsIDIwMjEgYXQgMToxOSBBTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IE9uIFR1ZSwgMjEgU2VwIDIwMjEsIEtyenlzenRvZiBLb3psb3dz a2kgd3JvdGU6Cj4KPiA+IE9uIDIwLzA5LzIwMjEgMjE6MDMsIFdpbGwgTWNWaWNrZXIgd3JvdGU6 Cj4gPiA+IFN3aXRjaCB0aGUgZGVmYXVsdCBsb2dpYyB0byBlbmFibGUgU09DX1NBTVNVTkcgYW5k IGl0J3Mgc3ViLWNvbmZpZ3MgdG8KPiA+ID4gYmUgZW5hYmxlZCBieSBkZWZhdWx0IHZpYSAiZGVm YXVsdCB5IGlmIEFSQ0hfRVhZTk9TIiB2ZXJzdXMgYmVpbmcKPiA+ID4gc2VsZWN0ZWQgYnkgdGhl IEFSQ0hfRVhZTk9TIGNvbmZpZyBkaXJlY3RseS4gVGhpcyBhbGxvd3MgdmVuZG9ycyB0bwo+ID4g PiBkaXNhYmxlIHRoZXNlIGNvbmZpZ3MgaWYgdGhleSB3aXNoIGFuZCBwcm92aWRlcyBhZGRpdGlv bmFsIGZsZXhpYmlsaXR5Cj4gPiA+IHRvIG1vZHVsYXJpemUgdGhlbSBpbiB0aGUgcHJlc2VuY2Ug b2YgYSBnZW5lcmljIGtlcm5lbC4KPiA+Cj4gPiBUaGlzIGlzIG5vdCB0cnVlLiBWZW5kb3JzIGNh bm5vdCBkaXNhYmxlIHRoZXNlIG9wdGlvbnMgYXMgdGhleSBhcmUgbm90Cj4gPiB2aXNpYmxlLgo+ Cj4gR29vZCBwb2ludCwgd2VsbCBtYWRlLgo+Cj4gPiBBbHRob3VnaCBJIHVuZGVyc3RhbmQgdGhh dCBBcm5kIHByZWZlcnMgdGhpcyB3YXkgYW5kIEkgZG8gbm90Cj4gPiBvYmplY3QgaXQsIGJ1dCB5 b3VyIGV4cGxhbmF0aW9uIGlzIGluY29ycmVjdC4KClRoYW5rcyBLcnp5c3p0b2YgZm9yIHRoZSBy ZXZpZXdzISBJJ20gc29ycnkgSSBtaXNzZWQgdGhlIHdob2xlICJoaWRkZW4KY29uZmlncyIgcGFy dC4gSSdsbCB1cGxvYWQgdGhlIHNlcmllcyB0byBpbmNsdWRlIHRoZSBmaXggdGhhdCByZWZhY3Rv cwp0aGUgU2Ftc3VuZyBTb0MgZHJpdmVycyBtZW51Y29uZmlnIHdoaWNoIHdpbGwgYWRkcmVzcyB0 aGF0IGFuZCBhbGxvdwpvbmUgdG8gZW5hYmxlL2Rpc2FibGUgdGhvc2UgY29uZmlncy4gSSdtIGdv aW5nIHRvIGhvbGQgb2ZmIHRob3VnaAp1bnRpbCB3ZSBoYXNoIG91dCB0aGUgcmVzdCBvZiB0aGUg ZGlzY3Vzc2lvbiBpbiB0aGUgY292ZXIgbGV0dGVyCmVtYWlsLgoKVGhhbmtzLApXaWxsCgo+Cj4g LS0KPiBMZWUgSm9uZXMgW+adjueQvOaWr10KPiBTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZl bG9wZXIgU2VydmljZXMKPiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QXJtIFNvQ3MKPiBGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==