From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Subject: Re: [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support Date: Fri, 27 Jul 2018 12:16:40 +0530 Message-ID: References: <20180726065331.6186-1-o.rempel@pengutronix.de> <20180726065331.6186-4-o.rempel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "A.s. Dong" Cc: Mark Rutland , Devicetree List , Oleksij Rempel , Rob Herring , ", linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream" , ", Sascha Hauer" , Fabio Estevam , Shawn Guo , Vladimir Zapolskiy , dl-linux-imx List-Id: devicetree@vger.kernel.org T24gRnJpLCBKdWwgMjcsIDIwMTggYXQgMTE6MzAgQU0sIEEucy4gRG9uZyA8YWlzaGVuZy5kb25n QG54cC5jb20+IHdyb3RlOgo+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9tOiBK YXNzaSBCcmFyIFttYWlsdG86amFzc2lzaW5naGJyYXJAZ21haWwuY29tXQo+PiBTZW50OiBGcmlk YXksIEp1bHkgMjcsIDIwMTggMTI6NTYgUE0KPj4gVG86IEEucy4gRG9uZyA8YWlzaGVuZy5kb25n QG54cC5jb20+Cj4+IENjOiBPbGVrc2lqIFJlbXBlbCA8by5yZW1wZWxAcGVuZ3V0cm9uaXguZGU+ OyAsIFNhc2NoYSBIYXVlcgo+PiA8a2VybmVsQHBlbmd1dHJvbml4LmRlPjsgU2hhd24gR3VvIDxz aGF3bmd1b0BrZXJuZWwub3JnPjsgRmFiaW8KPj4gRXN0ZXZhbSA8ZmFiaW8uZXN0ZXZhbUBueHAu Y29tPjsgUm9iIEhlcnJpbmcgPHJvYmgrZHRAa2VybmVsLm9yZz47Cj4+IE1hcmsgUnV0bGFuZCA8 bWFyay5ydXRsYW5kQGFybS5jb20+OyBWbGFkaW1pciBaYXBvbHNraXkKPj4gPHZsYWRpbWlyX3ph cG9sc2tpeUBtZW50b3IuY29tPjsgLCBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcsCj4+IGxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcsIHNydl9oZXVwc3RyZWFt IDxsaW51eC1hcm0tCj4+IGtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnPjsgRGV2aWNldHJlZSBM aXN0IDxkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZz47Cj4+IGRsLWxpbnV4LWlteCA8bGludXgt aW14QG54cC5jb20+Cj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjcgMy82XSBkdC1iaW5kaW5nczog bWFpbGJveDogaW14LW11OiBhZGQgZ2VuZXJpYyBNVQo+PiBjaGFubmVsIHN1cHBvcnQKPj4KPj4g T24gRnJpLCBKdWwgMjcsIDIwMTggYXQgOTozMiBBTSwgQS5zLiBEb25nIDxhaXNoZW5nLmRvbmdA bnhwLmNvbT4gd3JvdGU6Cj4+ID4+Cj4+ID4+ID4+Cj4+ID4+ID4+ID4gRWFjaCBNVSBoYXMgZm91 ciBwYWlycyBvZiByeC90eCBkYXRhIHJlZ2lzdGVyIHdpdGggZm91ciByeC90eAo+PiA+PiA+PiA+ IGludGVycnVwdHMgd2hpY2ggY2FuIGFsc28gYmUgdXNlZCBhcyBhIHNlcGFyYXRlIGNoYW5uZWwu Cj4+ID4+ID4+ID4KPj4gPj4gPj4gU28gdGhlIGhhcmR3YXJlIGFjdHVhbGx5IHN1cHBvcnRzIDQg Y2hhbm5lbHMuCj4+ID4+ID4+Cj4+ID4+ID4+ID4gLS0gI21ib3gtY2VsbHM6ICBNdXN0IGJlIDAu IE51bWJlciBvZiBjZWxscyBpbiBhIG1haWxib3gKPj4gPj4gPj4gPiArLSAjbWJveC1jZWxsczog IE11c3QgYmU6Cj4+ID4+ID4+ID4gKyAgICAgICAgICAgICAgIDAgLSBmb3Igc2luZ2xlIGNoYW5u ZWwgbW9kZS4gaS5NWDgqIFNDVSBwcm90b2NvbCBzcGVjaWZpYy4KPj4gPj4gPj4gPiArICAgICAg ICAgICAgICAgMSAtIGZvciBtdWx0aWNoYW5uZWwgKGdlbmVyaWMpIG1vZGUuCj4+ID4+ID4+ID4g Kwo+PiA+PiA+PiBObywgcGxlYXNlLgo+PiA+PiA+PiBEVCBiaW5kaW5ncyBzaG91bGQgcmVmbGVj dCB0aGUgcmVhbCBoYXJkd2FyZSwgYW5kIG5vdCB0aGUgc29mdHdhcmUKPj4gPj4gPj4gbW9kZSB3 ZSB3YW50IHRoZSBkcml2ZXIgdG8gd29yayBpbi4KPj4gPj4gPj4gUGxlYXNlIGRlZmluZSBtYm94 LWNlbGxzPTEgIGFuZCBoYXZlIHRoZSBpLk1YOCogcGxhdGZvcm0gYWx3YXlzCj4+ID4+ID4+IGFz ayBmb3IgY2hhbm5lbC0wLgo+PiA+PiA+Cj4+ID4+ID4gVGhlIHJlYWxpdHkgaXMgdGhhdCBNVSBo YXJkd2FyZSBkb2VzIG5vdCBkZWZpbmUgY2hhbm5lbHMgaW4KPj4gPj4gPiByZWZlcmVuY2UKPj4g Pj4gbWFudWFsLgo+PiA+PiA+IEhvd2V2ZXIsIGl0IGRvZXMgaGF2ZSBmb3VyIHNlcGFyYXRlIGRh dGEgdHgvcnggcmVnaXN0ZXIgd2hpY2ggY2FuCj4+ID4+ID4gYmUgdXNlZCBhcyAndmlydHVhbCcg Y2hhbm5lbHMgd2hpY2ggaXMgc3VwcG9ydGVkIGJ5IHRoaXMgY3VycmVudCBkcml2ZXIuCj4+ID4+ ID4KPj4gPj4gPiBTZWUgYmVsb3cgSFcgZGVzY3JpcHRpb24gZnJvbSB0aGUgcmVmZXJlbmNlIG1h bnVhbDoKPj4gPj4gPiBGb3IgbWVzc2FnaW5nLCB0aGUgTVUgaGFzIGZvdXIsIDMyLWJpdCB3cml0 ZS1vbmx5IHRyYW5zbWl0Cj4+ID4+ID4gcmVnaXN0ZXJzIGFuZCBmb3VyLCAzMi1iaXQgcmVhZC1v bmx5IHJlY2VpdmUgcmVnaXN0ZXJzIG9uIHRoZQo+PiA+PiA+IFByb2Nlc3NvciBCIGFuZCBQcm9j ZXNzb3IgQS1zaWRlcy4gVGhlc2UgcmVnaXN0ZXJzIGFyZSB1c2VkIGZvcgo+PiA+PiA+IHNlbmRp bmcgbWVzc2FnZXMgdG8gZWFjaAo+PiA+PiBvdGhlci4KPj4gPj4gPgo+PiA+PiBGb3IgYSB3aGls ZSBwbGVhc2UgZm9yZ2V0IHRoZSBwcm90b2NvbCh1c2VyKSBsZXZlbCB1c2FnZSwgYW5kCj4+ID4+ IGNvbnNpZGVyIG9ubHkgd2hhdCB5b3VyIGgvdyBpcy4KPj4gPj4KPj4gPj4gTVUgaGFzIDQgcGFp cnMgb2YgVFhfUmVnICsgVFhfSVJRLCBhbmQgNCBwYWlycyBvZiBSWF9SZWcgKyBSWF9JUlEuCj4+ ID4+IChNVSBhbHNvIGhhcyA0ICJkb29yYmVsbCIgdHlwZSBjaGFubmVscyB0aGF0IGl0IGNhbGxz IEdQLCBidXQgdGhvc2UKPj4gPj4gYXJlIG5vdCBtYW5hZ2VkIGhlcmUsIHNvIGxldHMgbm90IHdv cnJ5IGF0bSkuCj4+ID4+Cj4+ID4+IEJ5IGRlZmluaXRpb24sIGEgbWFpbGJveCBjaGFubmVsIGlz IHNpbXBseSBhIHNpZ25hbCwgb3B0aW9uYWxseSB3aXRoCj4+ID4+IGRhdGEgYXR0YWNoZWQuIFNv LCBNVSBoYXMgNCBUWCBhbmQgNCBSWCBjaGFubmVscy4KPj4gPj4KPj4gPj4gVGhlIE1VIGRyaXZl ciBzaG91bGQgcG9wdWxhdGUgOCB1bmlkaXJlY3Rpb25hbCAoNCBUeCBhbmQgNCBSWCkKPj4gPj4g Y2hhbm5lbHMgYW5kIHNldCBlYWNoIHR4L3J4IG9wZXJhdGlvbiB0byB0cmlnZ2VyIHRoZSBjb3Jy ZXNwb25kaW5nCj4+ID4+IGludGVycnVwdC4gVGhpcyBpcyBub3QgbXkgd2hpbSwgdGhpcyBpcyBo b3cgdGhlIGNvbnRyb2xsZXIgaXMhCj4+ID4+Cj4+ID4KPj4gPiBUaGlzIGxvb2tzIGxpa2UgcmVh c29uYWJsZSB0byBtZSwgdGhlb3JldGljYWxseS4KPj4gPiBKdXN0IG5vdCBzdXJlIHdoZXRoZXIg aXQncyBuZWNlc3NhcnkgdG8gc3VwcG9ydCBpdCBiZWNhdXNlIHdlIHByb2JhYmx5Cj4+ID4gd2ls bCBuZXZlciB1c2UgbGlrZSB0aGF0IGluIHJlYWxpdHksIHRoZW4gaXQgbWlnaHQgYmVjb21lIG1l YW5pbmdsZXNzCj4+ID4gY29tcGxpY2l0eSBpbnRyb2R1Y2VkIGFuZCBlcnJvciBwcm9uZS4KPj4g Pgo+PiBJdCBfaXNfIG5lY2Vzc2FyeSB0byB3cml0ZSBjb250cm9sbGVyIGRyaXZlciBpbmRlcGVu ZGVudCBvZiBjbGllbnQgZHJpdmVycy4KPj4KPgo+IFllcywgdGhhdCdzIHRydWUuIFdoYXQgaWYg d2UgdGhpbmsgd2UncmUgd3JpdGluZyBkcml2ZXIgYWdhaW5zdCBIVyBjYXBhYmlsaXRpZXMKPiB3 aGljaCBzdXBwb3J0IDQgcGFpciBvZiBjaGFubmVsIGxpbmtzKHR4L3J4KT8KPiBJdCBsb29rcyBs aWtlIGluZGVwZW5kZW50IG9mIGNsaWVudCBkcml2ZXJzIGFuZCBtYXkgbWFrZSBsaWZlIGVhc2ls eS4KPiBEb2VzIGl0IG1ha2Ugc2Vuc2U/Cj4KTm8sIHRoYXQgd291bGQgYmUgZW11bGF0aW9uLgpX aHkgZG9lc24ndCBhIHVzYiBkZXZpY2UgY29udHJvbGxlciAodWRjKSBkcml2ZXIgZW11bGF0ZSBG U0cvSElEIGV0YywKYnkgInRoaW5raW5nIiBpdCBoYXMgYSBoYXJkd2FyZSBiYWNrZWQgc3RvcmFn ZS9rZXlib2FyZD8gSXQgZG9lc24ndApiZWNhdXNlIHRoYXQgaXMgdGhlIGpvYiBvZiB1cHBlciBw cm90b2NvbCBsYXllci4KCgo+Pgo+PiA+IEFuZCBBRkFJSyBBUk0gTUhVIGlzIGRvaW5nIHRoZSBz YW1lIHdheSBhcyBNVSB3aGljaCBsb29rcyBsaWtlIGFsc28KPj4gdW5pZGlyZWN0aW9uYWwgY2hh bm5lbC4KPj4gPgo+PiBodHRwczovL2VtZWEwMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29r LmNvbS8/dXJsPWh0dHAlM0ElMkYlMkZpbmZvCj4+ID4KPj4gY2VudGVyLmFybS5jb20lMkZoZWxw JTJGaW5kZXguanNwJTNGdG9waWMlM0QlMkZjb20uYXJtLmRvYy5kZGkwNTE1Cj4+IGIlMkYKPj4g Pgo+PiBDSERHQkdJRi5odG1sJmFtcDtkYXRhPTAyJTdDMDElN0NhaXNoZW5nLmRvbmclNDBueHAu Y29tJTdDYjcyOAo+PiAxNjM2Mjk4Mwo+PiA+Cj4+IDQyMDhmOWU5MDhkNWYzN2QzZTAwJTdDNjg2 ZWExZDNiYzJiNGM2ZmE5MmNkOTljNWMzMDE2MzUlN0MwJTdDMCUKPj4gN0M2MzY2Cj4+ID4KPj4g ODI2NDE1OTM3ODUwMDkmYW1wO3NkYXRhPVZzRzBvWHhFT2JQUndUNUtWc3MyZVp0aFNUTVRSMiUy Qk1ydgo+PiBQcWhEVXBQR1UKPj4gPiAlM0QmYW1wO3Jlc2VydmVkPTAKPj4gPiBkcml2ZXJzL21h aWxib3gvYXJtX21odS5jCj4+ID4KPj4gTUhVIGRyaXZlciBpcyBkb2luZyBleGFjdGx5IHdoYXQg dGhlIGRhdGEgc2hlZXQgc2F5cy4gSSBrbm93IGJlY2F1c2UgSSB3cm90ZQo+PiB0aGUgZHJpdmVy Lgo+Pgo+Cj4gSG1tLi4uIE1heWJlIEkgbWlzc2VkIHNvbWV0aGluZywgYnV0IHNlZW1zIG5vIGZy b20gd2hhdCBJIHNlZToKPiBodHRwOi8vaW5mb2NlbnRlci5hcm0uY29tL2hlbHAvaW5kZXguanNw P3RvcGljPS9jb20uYXJtLmRvYy5kdWkwOTIyZy9DQ0hIR0lBSC5odG1sCj4KVGhhdCBpcyBub3Qg dGhlIE1IVSBkYXRhc2hlZXQuCgpSZWFkIFNlY3Rpb24gMy42IGF0IHBhZ2UtMy00MSBvZgpodHRw Oi8vaW5mb2NlbnRlci5hcm0uY29tL2hlbHAvdG9waWMvY29tLmFybS5kb2MuZGRpMDUxNWIvRERJ MDUxNUJfanVub19hcm1fZGV2ZWxvcG1lbnRfcGxhdGZvcm1fc29jX3RybS5wZGYKClRoaXMgaXMg YW5vdGhlciByZWFzb24gSSBjYW4ndCBsZXQgYSBiYWQgY29kZSAoZW11bGF0aW9uIGNvZGUpCnRo cm91Z2gsIGJlY2F1c2UgcGVvcGxlIHN0YXJ0IGxvb2tpbmcgZm9yIGV4YW1wbGVzIHRvIGp1c3Rp ZnkgdGhlaXIKaW1wbGVtZW50YXRpb24gcmF0aGVyIHRoYW4gZml4aW5nIGl0LgoKCj4+Cj4+ID4+ IFRoZSBTQ1UgaXMgcG9vcmx5IGltcGxlbWVudGVkIGFzIGl0IGlnbm9yZXMgMyBpcnFzIGFuZCBj bHViIGFsbCA0Cj4+ID4+IHJlZ2lzdGVyIHRvZ2V0aGVyICh0aGVyZSBhcmUgbWFueSBvdGhlciBj b25zIG9mIHRoaXMgYXBwcm9hY2ggYnV0Cj4+ID4+IGxldHMgbm90IGdldCBpbnRvIHRoYXQpLgo+ PiA+PiBQZXJzb25hbGx5LCBJIHdvdWxkIHB1c2gtYmFjayBvbiBzdWNoIGEgYmFkIGRlc2lnbi4g QnV0IGlmIHlvdSBjbGFpbQo+PiA+PiB5b3UgaGF2ZSBubyBjaG9pY2UgYnV0IHRvIHN1cHBvcnQg U0NVIGFzIHN1Y2gsIHRoZSB3b3JrIGFyb3VuZCBjb3VsZAo+PiA+PiBiZSBzaW1wbGVyIHRoYW4g ZGVmaW5pbmcgYSBuZXcgInNjdSBtb2RlIiBhbHRvZ2V0aGVyLgo+PiA+Pgo+PiA+Cj4+ID4gVGhp cyBpcyBvbmUgb2YgdGhlIHJlY29tbWVuZGVkIHdheXMgZGVzaWduZWQgaW4gSFcgcmVmZXJlbmNl IG1hbnVhbAo+PiA+IGFuZCBpdCBhbGxvd3MgdG8gc2VuZCBmcmFtZSBpbmZvcm1hdGlvbiB1cCB0 byA0IHdvcmRzIHdpdGhvdXQgdXNpbmcgc2hhcmVkCj4+IG1lbW9yeS4KPj4gPiBTQ1UganVzdCBm b2xsb3dzIGl0LCBzbyBpdCdzIGhhcmQgdG8gYmVsaWV2ZSBpdCdzIGEgYmFkIGRlc2lnbi4KPj4g Pgo+PiA+PiAjbWJveC1jZWxsczogIE11c3QgYmUgMy4KPj4gPj4gICAgICAgICAgICAgICAgICAg ICAgIEZpcnN0IGNlbGwgaXMgMSBmb3IgVFggYW5kIDAgZm9yIFJYIGNoYW5uZWwKPj4gPj4gICAg ICAgICAgICAgICAgICAgICAgIFNlY29uZCBjZWxsIGlzIGluZGV4IG9mIHRoZSBjaGFubmVsIFsw LDEsMiBvciAzXQo+PiA+PiAgICAgICAgICAgICAgICAgICAgICAgVGhpcmQgY2VsbCBpcyAxIGlm IHRoZSBjaGFubmVsIHRyaWdnZXJzIGFuIElSUSwKPj4gPj4gMCBpZiBub3QuIFRoYXQgaXMgQUNS LlJJRS9USUUgYml0cyBhcmUgc2V0IG9yIG5vdC4KPj4gPj4KPj4gPj4gTm9ybWFsIGNsaWVudHMg d291bGQgYWx3YXlzIHJlcXVlc3QgYSBjaGFubmVsIHdpdGggaXJxcyBlbmFibGVkLgo+PiA+PiBU aGUgU0NVIGNsaWVudCB3b3VsZCByZXF1ZXN0IGFsbCA4IGNoYW5uZWxzIC0tIFRYL1JYWzAsMSwy XSB3aXRoIGlycXMKPj4gPj4gZGlzYWJsZWQsIFRYL1JYWzNdIHdpdGggaXJxcyBlbmFibGVkLiBB bmQgU0NVIHdpbGwgcmVhZC93cml0ZSA0IHdvcmQKPj4gPj4gZGF0YSBvdmVyIDQgcngvdHggY2hh bm5lbHMsIGluc3RlYWQgb2YgdGhlIHZpcnR1YWxseSBjb25jb2N0ZWQgb25lLgo+PiA+Pgo+PiA+ Cj4+ID4gSXQgbWF5IHdvcmsgSWYgU0NVIHByb3RvY29sIGRhdGEgbGVuZ3RoIGlzIGZpeGVkIHRv IDQgd29yZHMuIEhvd2V2ZXIsCj4+ID4gaXQncyBsZW5ndGggaXMgZmxleGlibGUgZm9yIGRpZmZl cmVudCBTVkMgc2VydmljZS4gVGhhdCBtZWFucyB0aGlzIGJpbmRpbmcKPj4gd29uJ3Qgd29yayBm b3IgU0NVLgo+PiA+IEFuZCBpdCB3aWxsIGludHJvZHVjZSBtdWNoIGNvbXBsZXhpdGllcyBkdXJp bmcgdGhlIGltcGxlbWVudGF0aW9uLgo+PiA+Cj4+ID4gSW5zdGVhZCwgd2UncmUgdXNpbmcgcG9s bGluZyBtb2RlIGZvciBib3RoIFRYL1JYIGFuZCB0aGUgZGF0YSBzaXplIGlzCj4+ID4gc3RvcmVk IGluIHRoZSBtc2cgaGVhZGVyIGFuZCBzZW5kaW5nIG1zZ3MgdXNpbmcgYWxsIDQgZGF0YSB0eC9y eCByZWdpc3RlcnMKPj4gYXMgYSBjaGFubmVsIGZpZm8uCj4+ID4KPj4gWW91IGZpcnN0IGdpdmUg bWUgdGhlICJQYXNzaW5nIHNob3J0IG1lc3NhZ2VzIiB1c2VjYXNlIChxdWl0ZSBhIGJhZAo+PiBv bmUpIGFuZCBhc2sgaG93IGl0IGNhbiB3b3JrLiBXaGVuIEkgZ2l2ZSB5b3UgYSBzb2x1dGlvbiwg eW91IGVmZmVjdGl2ZWx5IHNheQo+PiAid2VsbCwgbXkgdXNlY2FzZSBpc24ndCBldmVuIHRoYXQi LiBJIGZlZWwgSSBqdXN0IHdhc3RlZCBteSB0aW1lLgo+Pgo+Cj4gU29ycnkgZm9yIG1heSBub3Qg Y2xlYXIsICJQYXNzaW5nIHNob3J0IG1lc3NhZ2UnIHVzZWNhc2UgaXMgdG8gdGVsbCBob3cgdGhl Cj4gSFcgaXMgd29ya2luZyBvbiBvbmUgY2hhbm5lbCBtb2RlIHNlbmRpbmcgdXAgdG8gNCB3b3Jk cyBpbiBvbmUgdGltZQo+IEFzIHNwZWNpZmllZCBpbiByZWZlcmVuY2UgbWFudWFsLgo+Cj4gU0NV IGRvZXMgd29yayB0aGF0IHdheSwgdGhlIG9ubHkgZGlmZmVyZW5jZSBpcyBpdCdzIHVzaW5nIHBv bGxpbmcgbW9kZQo+IHJhdGhlciB0aGFuIGludGVycnVwdCBkcml2ZW4uICBUaGUgcG9pbnQgaXMg dGhlIGRhdGEgc2l6ZSBtYXkgYmUgZGlmZmVyZW50Cj4gZm9yIGVhY2ggbXNnLCBzbyB3ZSBjYW4n dCBzaW1wbHkga25vdyB3aGljaCBkYXRhIHJlZ2lzdGVyIGludGVycnVwdAo+IHNob3VsZCBiZSBl bmFibGUgZnJvbSBzdGF0aWMgZGF0YSBkZWZpbmVkIGluIGRldmljZSB0cmVlLgo+CkFuZCB5b3Ug dGhpbmsgcGFzc2luZyB2YXJpYWJsZSBkYXRhIHRocm91Z2ggcmVnaXN0ZXJzIGlzIGEgYmV0dGVy IGlkZWEKdGhhbiBwYXNzaW5nIHBhY2tldHMgdmlhIHNoYXJlZC1tZW1vcnk/CgoKPj4KPj4gPj4K Pj4gPj4gPiBzaG9ydCBtZXNzYWdlcwo+PiA+PiA+IFRyYW5zbWl0IHJlZ2lzdGVyKHMpIGNhbiBi ZSB1c2VkIHRvIHBhc3Mgc2hvcnQgbWVzc2FnZXMgZnJvbSBvbmUgdG8KPj4gPj4gPiBmb3VyIHdv cmRzIGluIGxlbmd0aC4gRm9yIGV4YW1wbGUsIHdoZW4gYSBmb3VyLXdvcmQgbWVzc2FnZSBpcwo+ PiA+PiA+IGRlc2lyZWQsIG9ubHkgb25lIG9mIHRoZSByZWdpc3RlcnMgbmVlZHMgdG8gaGF2ZSBp dHMgY29ycmVzcG9uZGluZwo+PiA+PiA+IGludGVycnVwdCBlbmFibGUgYml0IHNldCBhdCB0aGUg cmVjZWl2ZXIgc2lkZTsgdGhlIG1lc3NhZ2XigJlzIGZpcnN0Cj4+ID4+ID4gdGhyZWUgd29yZHMg YXJlIHdyaXR0ZW4gdG8gdGhlIHJlZ2lzdGVycyB3aG9zZSBpbnRlcnJ1cHQgaXMgbWFza2VkLAo+ PiA+PiA+IGFuZCB0aGUgZm91cnRoIHdvcmQgaXMgd3JpdHRlbiB0byB0aGUgb3RoZXIgcmVnaXN0 ZXIgKHdoaWNoCj4+ID4+ID4gdHJpZ2dlcnMgYW4KPj4gPj4gaW50ZXJydXB0IGF0IHRoZSByZWNl aXZlciBzaWRlKS4KPj4gPj4gPgo+PiA+PiA+IFRoZSByZWZlcmVuY2UgbWFudWFsIGlzIGF0IGhl cmU6IChDaGFwdGVyIDQyIE1lc3NhZ2luZyBVbml0IChNVSkKPj4gPj4gPgo+PiA+Pgo+PiBodHRw czovL2VtZWEwMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/dXJsPWh0dHBzJTNB JTJGJTJGdwo+PiA+PiB3dwo+PiA+PiA+IC5ueHAuY29tJTJGZG9jcyUyRmVuJTJGcmVmZXJlbmNl LQo+PiA+PiBtYW51YWwlMkZJTVg2VUxSTS5wZGYmYW1wO2RhdGE9MDIlN0MwCj4+ID4+ID4KPj4g Pj4KPj4gMSU3Q2Fpc2hlbmcuZG9uZyU0MG54cC5jb20lN0NlZjM0OWQ3YzljYWY0NmM0MjYwMDA4 ZDVmMzBlOWVmNSU3QzYKPj4gPj4gODZlYTEKPj4gPj4gPgo+PiA+Pgo+PiBkM2JjMmI0YzZmYTky Y2Q5OWM1YzMwMTYzNSU3QzAlN0MwJTdDNjM2NjgyMTY2NDk0ODYwMzMyJmFtcDtzZGF0Cj4+ID4+ IGE9NTRyRQo+PiA+PiA+Cj4+ID4+Cj4+IGlEbSUyQkdENkVZOE5FNjRjazFMWFZHb1VDdFdZckhY UG9XcWN1alVvJTNEJmFtcDtyZXNlcnZlZD0wCj4+ID4+ID4KPj4gPj4gPiBBbmQgU0NVIGZpcm13 YXJlIGRvZXMgdXNlIE1VIGluIGFib3ZlIHdheSBzcGVjaWZpZWQgYnkgcmVmZXJlbmNlCj4+ID4+ IG1hbnVhbC4KPj4gPj4gPiBFdmVuIGZyb20gSFcgcG9pbnQgb2YgdmlldywgaXQncyBzdGlsbCBv bmUgY2hhbm5lbCBvbmx5IG1haWxib3guCj4+ID4+ID4KPj4gPj4gUGxlYXNlIHJlYWxpc2UgdGhh dCBhbnkgbWFudWFsIGlzIHdyaXR0ZW4gYnkgYSBtZXJlIG1vcnRhbCBhZnRlcmFsbC4KPj4gPj4g SG93IHRoZSBjb250cm9sbGVyIHdvcmtzIGlzIHNldCBpbiBzdG9uZSwgYnV0IGhvdyB0aGUgY29u dHJvbGxlciBjYW4KPj4gPj4gYmUgdXNlZCAuLi4gaXMganVzdCBzb21lb25lcyBzdWdnZXN0aW9u Lgo+PiA+Pgo+PiA+PiBUaGUgYXBwcm9hY2ggSSBzdWdnZXN0IGFib3ZlLCBjb25mb3JtcyB0byB0 aGUgYXBpIGFuZCBwcmV2ZW50cyBhCj4+ID4+IHByb3ZpZGVyIGRhbmNpbmcgdG8gdGhlIHR1bmVz IG9mIGEgdXNlci4KPj4gPgo+PiA+IEZpcnN0IG9mIGFsbCwgcmVhbGx5IGFwcHJlY2lhdGUgZm9y IHlvdXIgc3VnZ2VzdGlvbnMuCj4+ID4gSXQgbWF5IGJlIGhhcmQgdG8gZmluZCBhIGNvbW1vbiBi aW5kaW5nIHdpdGggdGhlIHNhbWUgbWJveC1jZWxscy4KPj4gPiBJdCBsb29rcyBsaWtlIHdlIGp1 c3QgbmVlZCBhIHByb3BlcnR5IGlzIGRpc3Rpbmd1aXNoIGhvdyB0aGUgTWFpbGJveAo+PiA+IGlz IHVzZWQgSW4gb25lIGNoYW5uZWwgb3IgbXVsdGkgY2hhbm5lbCBtb2RlLgo+PiA+Cj4+IEkgZ2V0 IHRoZSBpZGVhIHlvdSB3ZXJlIHJlYWR5IHRvIHNlZSB0aGUgY29kZSBtZXJnZWQgaW4gdGhlIGNv bWluZyB3aW5kb3cKPj4gYW5kIGJlIGRvbmUgd2l0aCBpdC4gQW5kIG5vdyBpdCBmZWVscyBsYXp5 IHRvIGNoYW5nZSB0aGUgY29kZS4KPgo+IEZvciBtZSwgSSdtIGdsYWQgdG8gY2hhbmdlIGlmIHdl IGhhdmUgYSBjbGVhciBiZXR0ZXIgc29sdXRpb24uCj4gQW5kIEkgZG8gYXBwcmVjaWF0ZSB5b3Vy IHN1Z2dlc3Rpb24gYW5kIHJldmlldyB0aW1lLgo+Cj4gV2h5IEknbSBhIGJpdCBoZXNpdGF0ZSBu b3cgaXMgYmVjYXVzZSB5b3VyIHN1Z2dlc3Rpb24gbWF5IG5vdCB3b3JrIGZvciBTQ1UsCj4gKHNl ZSBhYm92ZSBleHBsYW5hdGlvbiksIGJ1dCBpdCBkb2VzIHdvcmsgZm9yIGdlbmVyaWMgTTQgY2Fz ZS4KPiBCdXQgd2UnIHJlIG5vdyBnb2luZyB0byBzdXBwb3J0IGJvdGggcHJvdG9jb2wgaW4gb25l IG1haWxib3ggZHJpdmVyLgo+IEFueSBzdWdnZXN0aW9uIG9uIGhvdyB0byB0cmVhdCB0aGVtIHBy b3Blcmx5IGlmIGNoYW5nZSB0aGUgYmluZGluZz8KPgpJbiB5b3VyIGxhc3QgcG9zdCB5b3Ugc2Fp ZCAiVGhpcyBsb29rcyBsaWtlIHJlYXNvbmFibGUgdG8gbWUsIHRoZW9yZXRpY2FsbHkiCk15IHN1 Z2dlc3Rpb24gaXMgdGhlIHNhbWUgYmVjYXVzZSBJIGRvbid0IHNlZSB3aHkgaXQgd29uJ3Qgd29y ay4KCgo+PiBJIGFtIHNvcnJ5LCBidXQgSSBjYW4ndCBhbGxvdyBjb250cm9sbGVyIGRyaXZlcnMg ImVtdWxhdGluZyIgc29tZSBtb2RlIGZvciBhCj4+IGNsaWVudCBkcml2ZXIuIFRoYXQgaXMgbW92 aW5nIGEgcGFydCBvZiBjbGllbnQgY29kZSBpbnRvIHRoZSBjb250cm9sbGVyIGRyaXZlci4KPj4K Pgo+IE9rYXksIGxldCdzIGZpZ3VyZSBvdXQgaXQgZmlyc3QuCj4gV291bGQgeW91IGJlIG1vcmUg c3BlY2lmaWMgb24gd2hhdCAiZW11bGF0aW5nIiBkaWQgeW91IG1lYW4gaW4gY29udHJvbGxlciBk cml2ZXI/Cj4gU2VuZGluZyB1cCB0byA0IHdvcmRzIGNhcGFiaWxpdHkgaW4gb25lIGNoYW5uZWwg bW9kZSBhcyBzcGVjaWZpZWQgaW4gcmVmZXJlbmNlIG1hbnVhbD8KPiBUaGF0J3MgSSdtIGEgYml0 IGNvbmZ1c2luZyBiZWNhdXNlIEkgdGhvdWdodCBpdCdzIEhXIGNhcGFiaWxpdHkgaW5kZXBlbmRl bnQgb2YgY2xpZW50IGRyaXZlci4KPgo+IE9yIGFueXRoaW5nIGVsc2U/Cj4KRW11bGF0aW9uIG1l YW5zIHByZXRlbmRpbmcgc29tZXRoaW5nIHRoYXQgd2UgYXJlIG5vdC4KClRoZSBoYXJkd2FyZSBo YXMgOCB1bmlkaXJlY3Rpb25hbCBjaGFubmVscy4gQnV0IHlvdXIgcHJvdG9jb2wgKFNDVQppbXBs ZW1lbnRhdGlvbikgYXNzdW1lcyB0aGVyZSBpcyBvbmUgX3ZpcnR1YWxfIGNoYW5uZWwgdGhhdCBo YXMgNApyZWdpc3RlcnMgYW5kIDEvMCBpcnEgLS0tIHdoaWNoIGlzIG5vdCB0cnVlLiBJbnN0ZWFk IG9mIGZpeGluZyB0aGUKYXNzdW1wdGlvbiBpbiB5b3VyIHByb3RvY29sIG9yIGVtdWxhdGluZyB0 aGUgdmlydHVhbCBjaGFubmVsIGluIHRoZQpwcm90b2NvbCBsZXZlbCAodXNlciBvZiBhIE1VKSwg eW91IHdhbnQgdG8gYWRkIGNvZGUgaW4gdGhlIGNvbnRyb2xsZXIKZHJpdmVyIHRoYXQgaWdub3Jl cyBpbnRlcnJ1cHRzIGFuZCBjbHViIHRoZSA0IGluZGVwZW5kZW50IGNoYW5uZWxzCnRvZ2V0aGVy LgoKVGhlcmUgaXMgbm8gZW5kIHRvIHByb3RvY29scyBhbmQgdGhlaXIga2lua3kgYXNzdW1wdGlv bnMsIGFkZGluZwoieHl6LW1vZGUiIHN1cHBvcnQgZm9yIGVhY2ggcHJvdG9jb2wgaXNuJ3Qgc2Nh bGFibGUuCgoKPj4KPj4gPiBEaXJlY3RseSBjaGVja2luZyBtYm94LWNlbGxzIHNlZW1zIHRoZSBt b3N0IGVhc3kgd2F5IGFuZCBpdCBpcyBhbHJlYWR5Cj4+ID4gQWNrZWQgYnkgUm9iLiBDYW4ndCB0 aGlzIHdheSBiZSBPa2F5IHRvIHlvdT8KPj4gPgo+PiBSb2IgaXMgaW5kZWVkIGZhciBiZXR0ZXIg dGhhbiBJIGFtLiBCdXQgaGUgYWxzbyBoYXMgdG8gbG9vayBpbnRvIDEwMCBvdGhlcgo+PiBzdWJz eXN0ZW1zLCB3aGVyZWFzIEkgYW0gb25seSBsb29raW5nIGludG8gbWFpbGJveC4gSSBoYXZlIHRp bWUgdG8gZGlnIGludG8KPj4geW91ciBkYXRhc2hlZXRzLiBJIGJlbGlldmUgUm9iIHdpbGwgcG9p bnQgb3V0IGFueXRoaW5nIHdyb25nIEkgc3VnZ2VzdC4KPj4KPgo+IFllcywgeW91J3JlIGluIHRo ZSBmYWlyIGVub3VnaCBhdXRob3JpdHkgdG8ganVkZ2UgaXQuIFRoYW5rcyBmb3IgeW91ciBlZmZv cnQuCj4KPj4gQlRXLCB0aGUgc3VibWl0dGVkIGRyaXZlciBkb2Vzbid0IGV2ZW4gc3VwcG9ydCB0 aGUgU0NVIHVzZWNhc2UuIFdoeSB0aGUKPj4gYmluZGluZ3M/Cj4KPiBCZWNhdXNlIHRoYXQgcGF0 Y2ggaXMgZmlyc3RseSBBY2tlZCBieSBSb2IuIE90aGVycyBhcmUgcmV3b3JrZWQgYW5kIHJlYWR5 IHRvIGJlIHNlbnQKPiBvdXQgYWdhaW5zdCB0aGlzIHBhdGNoIHNlcmllcy4gQnV0IGl0IHNlZW1z IHdlIHN0aWxsIGhhdmUgdW5yZXNvbHZlZCBpc3N1ZXMgbm93IGFzIHlvdQo+IHBvaW50ZWQgb3V0 LiBXZSBjYW4gZmlyc3QgcmVzb2x2ZSB0aGVtLiBPciBkbyB5b3UgbmVlZCBtZSB0byBzZW5kIG91 dCBmb3IgeW91ciByZWZlcmVuY2U/Cj4KSSBhbSBzdXJlIFJvYiB0b29rIHRoZSBiZXN0IGRlY2lz aW9uIGF0IHRoZSB0aW1lIHdpdGggd2hhdGV2ZXIKaW5mb3JtYXRpb24gcHJvdmlkZWQgdG8gaGlt LgpOb3csIGFmdGVyIHJlYWRpbmcgdGhlIGRhdGFzaGVldCwgd2UgaGF2ZSB0aGUgb3B0aW9uIHRv IGF2b2lkCmltcGxlbWVudGluZyBjb25zdW1lciBjb2RlIGluIHRoZSBwcm92aWRlciBkcml2ZXIu CgpUaGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: jassisinghbrar@gmail.com (Jassi Brar) Date: Fri, 27 Jul 2018 12:16:40 +0530 Subject: [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support In-Reply-To: References: <20180726065331.6186-1-o.rempel@pengutronix.de> <20180726065331.6186-4-o.rempel@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jul 27, 2018 at 11:30 AM, A.s. Dong wrote: >> -----Original Message----- >> From: Jassi Brar [mailto:jassisinghbrar at gmail.com] >> Sent: Friday, July 27, 2018 12:56 PM >> To: A.s. Dong >> Cc: Oleksij Rempel ; , Sascha Hauer >> ; Shawn Guo ; Fabio >> Estevam ; Rob Herring ; >> Mark Rutland ; Vladimir Zapolskiy >> ; , linux-arm-kernel at lists.infradead.org, >> linux-mediatek at lists.infradead.org, srv_heupstream > kernel at lists.infradead.org>; Devicetree List ; >> dl-linux-imx >> Subject: Re: [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU >> channel support >> >> On Fri, Jul 27, 2018 at 9:32 AM, A.s. Dong wrote: >> >> >> >> >> >> >> >> > Each MU has four pairs of rx/tx data register with four rx/tx >> >> >> > interrupts which can also be used as a separate channel. >> >> >> > >> >> >> So the hardware actually supports 4 channels. >> >> >> >> >> >> > -- #mbox-cells: Must be 0. Number of cells in a mailbox >> >> >> > +- #mbox-cells: Must be: >> >> >> > + 0 - for single channel mode. i.MX8* SCU protocol specific. >> >> >> > + 1 - for multichannel (generic) mode. >> >> >> > + >> >> >> No, please. >> >> >> DT bindings should reflect the real hardware, and not the software >> >> >> mode we want the driver to work in. >> >> >> Please define mbox-cells=1 and have the i.MX8* platform always >> >> >> ask for channel-0. >> >> > >> >> > The reality is that MU hardware does not define channels in >> >> > reference >> >> manual. >> >> > However, it does have four separate data tx/rx register which can >> >> > be used as 'virtual' channels which is supported by this current driver. >> >> > >> >> > See below HW description from the reference manual: >> >> > For messaging, the MU has four, 32-bit write-only transmit >> >> > registers and four, 32-bit read-only receive registers on the >> >> > Processor B and Processor A-sides. These registers are used for >> >> > sending messages to each >> >> other. >> >> > >> >> For a while please forget the protocol(user) level usage, and >> >> consider only what your h/w is. >> >> >> >> MU has 4 pairs of TX_Reg + TX_IRQ, and 4 pairs of RX_Reg + RX_IRQ. >> >> (MU also has 4 "doorbell" type channels that it calls GP, but those >> >> are not managed here, so lets not worry atm). >> >> >> >> By definition, a mailbox channel is simply a signal, optionally with >> >> data attached. So, MU has 4 TX and 4 RX channels. >> >> >> >> The MU driver should populate 8 unidirectional (4 Tx and 4 RX) >> >> channels and set each tx/rx operation to trigger the corresponding >> >> interrupt. This is not my whim, this is how the controller is! >> >> >> > >> > This looks like reasonable to me, theoretically. >> > Just not sure whether it's necessary to support it because we probably >> > will never use like that in reality, then it might become meaningless >> > complicity introduced and error prone. >> > >> It _is_ necessary to write controller driver independent of client drivers. >> > > Yes, that's true. What if we think we're writing driver against HW capabilities > which support 4 pair of channel links(tx/rx)? > It looks like independent of client drivers and may make life easily. > Does it make sense? > No, that would be emulation. Why doesn't a usb device controller (udc) driver emulate FSG/HID etc, by "thinking" it has a hardware backed storage/keyboard? It doesn't because that is the job of upper protocol layer. >> >> > And AFAIK ARM MHU is doing the same way as MU which looks like also >> unidirectional channel. >> > >> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Finfo >> > >> center.arm.com%2Fhelp%2Findex.jsp%3Ftopic%3D%2Fcom.arm.doc.ddi0515 >> b%2F >> > >> CHDGBGIF.html&data=02%7C01%7Caisheng.dong%40nxp.com%7Cb728 >> 16362983 >> > >> 4208f9e908d5f37d3e00%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% >> 7C6366 >> > >> 82641593785009&sdata=VsG0oXxEObPRwT5KVss2eZthSTMTR2%2BMrv >> PqhDUpPGU >> > %3D&reserved=0 >> > drivers/mailbox/arm_mhu.c >> > >> MHU driver is doing exactly what the data sheet says. I know because I wrote >> the driver. >> > > Hmm... Maybe I missed something, but seems no from what I see: > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0922g/CCHHGIAH.html > That is not the MHU datasheet. Read Section 3.6 at page-3-41 of http://infocenter.arm.com/help/topic/com.arm.doc.ddi0515b/DDI0515B_juno_arm_development_platform_soc_trm.pdf This is another reason I can't let a bad code (emulation code) through, because people start looking for examples to justify their implementation rather than fixing it. >> >> >> The SCU is poorly implemented as it ignores 3 irqs and club all 4 >> >> register together (there are many other cons of this approach but >> >> lets not get into that). >> >> Personally, I would push-back on such a bad design. But if you claim >> >> you have no choice but to support SCU as such, the work around could >> >> be simpler than defining a new "scu mode" altogether. >> >> >> > >> > This is one of the recommended ways designed in HW reference manual >> > and it allows to send frame information up to 4 words without using shared >> memory. >> > SCU just follows it, so it's hard to believe it's a bad design. >> > >> >> #mbox-cells: Must be 3. >> >> First cell is 1 for TX and 0 for RX channel >> >> Second cell is index of the channel [0,1,2 or 3] >> >> Third cell is 1 if the channel triggers an IRQ, >> >> 0 if not. That is ACR.RIE/TIE bits are set or not. >> >> >> >> Normal clients would always request a channel with irqs enabled. >> >> The SCU client would request all 8 channels -- TX/RX[0,1,2] with irqs >> >> disabled, TX/RX[3] with irqs enabled. And SCU will read/write 4 word >> >> data over 4 rx/tx channels, instead of the virtually concocted one. >> >> >> > >> > It may work If SCU protocol data length is fixed to 4 words. However, >> > it's length is flexible for different SVC service. That means this binding >> won't work for SCU. >> > And it will introduce much complexities during the implementation. >> > >> > Instead, we're using polling mode for both TX/RX and the data size is >> > stored in the msg header and sending msgs using all 4 data tx/rx registers >> as a channel fifo. >> > >> You first give me the "Passing short messages" usecase (quite a bad >> one) and ask how it can work. When I give you a solution, you effectively say >> "well, my usecase isn't even that". I feel I just wasted my time. >> > > Sorry for may not clear, "Passing short message' usecase is to tell how the > HW is working on one channel mode sending up to 4 words in one time > As specified in reference manual. > > SCU does work that way, the only difference is it's using polling mode > rather than interrupt driven. The point is the data size may be different > for each msg, so we can't simply know which data register interrupt > should be enable from static data defined in device tree. > And you think passing variable data through registers is a better idea than passing packets via shared-memory? >> >> >> >> >> > short messages >> >> > Transmit register(s) can be used to pass short messages from one to >> >> > four words in length. For example, when a four-word message is >> >> > desired, only one of the registers needs to have its corresponding >> >> > interrupt enable bit set at the receiver side; the message?s first >> >> > three words are written to the registers whose interrupt is masked, >> >> > and the fourth word is written to the other register (which >> >> > triggers an >> >> interrupt at the receiver side). >> >> > >> >> > The reference manual is at here: (Chapter 42 Messaging Unit (MU) >> >> > >> >> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw >> >> ww >> >> > .nxp.com%2Fdocs%2Fen%2Freference- >> >> manual%2FIMX6ULRM.pdf&data=02%7C0 >> >> > >> >> >> 1%7Caisheng.dong%40nxp.com%7Cef349d7c9caf46c4260008d5f30e9ef5%7C6 >> >> 86ea1 >> >> > >> >> >> d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636682166494860332&sdat >> >> a=54rE >> >> > >> >> >> iDm%2BGD6EY8NE64ck1LXVGoUCtWYrHXPoWqcujUo%3D&reserved=0 >> >> > >> >> > And SCU firmware does use MU in above way specified by reference >> >> manual. >> >> > Even from HW point of view, it's still one channel only mailbox. >> >> > >> >> Please realise that any manual is written by a mere mortal afterall. >> >> How the controller works is set in stone, but how the controller can >> >> be used ... is just someones suggestion. >> >> >> >> The approach I suggest above, conforms to the api and prevents a >> >> provider dancing to the tunes of a user. >> > >> > First of all, really appreciate for your suggestions. >> > It may be hard to find a common binding with the same mbox-cells. >> > It looks like we just need a property is distinguish how the Mailbox >> > is used In one channel or multi channel mode. >> > >> I get the idea you were ready to see the code merged in the coming window >> and be done with it. And now it feels lazy to change the code. > > For me, I'm glad to change if we have a clear better solution. > And I do appreciate your suggestion and review time. > > Why I'm a bit hesitate now is because your suggestion may not work for SCU, > (see above explanation), but it does work for generic M4 case. > But we' re now going to support both protocol in one mailbox driver. > Any suggestion on how to treat them properly if change the binding? > In your last post you said "This looks like reasonable to me, theoretically" My suggestion is the same because I don't see why it won't work. >> I am sorry, but I can't allow controller drivers "emulating" some mode for a >> client driver. That is moving a part of client code into the controller driver. >> > > Okay, let's figure out it first. > Would you be more specific on what "emulating" did you mean in controller driver? > Sending up to 4 words capability in one channel mode as specified in reference manual? > That's I'm a bit confusing because I thought it's HW capability independent of client driver. > > Or anything else? > Emulation means pretending something that we are not. The hardware has 8 unidirectional channels. But your protocol (SCU implementation) assumes there is one _virtual_ channel that has 4 registers and 1/0 irq --- which is not true. Instead of fixing the assumption in your protocol or emulating the virtual channel in the protocol level (user of a MU), you want to add code in the controller driver that ignores interrupts and club the 4 independent channels together. There is no end to protocols and their kinky assumptions, adding "xyz-mode" support for each protocol isn't scalable. >> >> > Directly checking mbox-cells seems the most easy way and it is already >> > Acked by Rob. Can't this way be Okay to you? >> > >> Rob is indeed far better than I am. But he also has to look into 100 other >> subsystems, whereas I am only looking into mailbox. I have time to dig into >> your datasheets. I believe Rob will point out anything wrong I suggest. >> > > Yes, you're in the fair enough authority to judge it. Thanks for your effort. > >> BTW, the submitted driver doesn't even support the SCU usecase. Why the >> bindings? > > Because that patch is firstly Acked by Rob. Others are reworked and ready to be sent > out against this patch series. But it seems we still have unresolved issues now as you > pointed out. We can first resolve them. Or do you need me to send out for your reference? > I am sure Rob took the best decision at the time with whatever information provided to him. Now, after reading the datasheet, we have the option to avoid implementing consumer code in the provider driver. Thanks.