From: Jassi Brar <jassisinghbrar@gmail.com>
To: Giridhar Maruthy <giridhar.maruthy@linaro.org>
Cc: naveenkrishna.ch@gmail.com, linux-samsung-soc@vger.kernel.org,
dp@opensource.wolfsonmicro.com, Kyung-Kwee.Ryu@wolfsonmicro.com,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: SAMSUNG: 24-bit audio playback on Exynos4210
Date: Wed, 13 Jul 2011 19:36:51 +0530 [thread overview]
Message-ID: <CABb+yY17WxP7qCbH=QoQyGY3DuH85-0zMS5O2UugQe9_djUGgw@mail.gmail.com> (raw)
In-Reply-To: <1310556126-13784-1-git-send-email-giridhar.maruthy@linaro.org>
On Wed, Jul 13, 2011 at 4:52 PM, Giridhar Maruthy
<giridhar.maruthy@linaro.org> wrote:
> Using 256fs or 512fs will result in distortion of 24-bit
> audio samples. This is because the lrclk generated is not
> proper. Using 384 fs generates proper output.
>
> Signed-off-by: Giridhar Maruthy <giridhar.maruthy@linaro.org>
> ---
> sound/soc/samsung/smdk_wm8994.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c
> index e7c1009..45fbe2b 100644
> --- a/sound/soc/samsung/smdk_wm8994.c
> +++ b/sound/soc/samsung/smdk_wm8994.c
> @@ -8,6 +8,7 @@
> */
>
> #include "../codecs/wm8994.h"
> +#include <sound/pcm_params.h>
>
> /*
> * Default CFG switch settings to use this driver:
> @@ -44,7 +45,9 @@ static int smdk_hw_params(struct snd_pcm_substream *substream,
> int ret;
>
> /* AIF1CLK should be >=3MHz for optimal performance */
> - if (params_rate(params) == 8000 || params_rate(params) == 11025)
> + if (params_format(params) == SNDRV_PCM_FORMAT_S24_LE)
> + pll_out = params_rate(params) * 384;
> + else if (params_rate(params) == 8000 || params_rate(params) == 11025)
> pll_out = params_rate(params) * 512;
> else
> pll_out = params_rate(params) * 256;
It might be a good idea to maintain a matrix of sample rates and sizes
tested cleanly.
Thanks,
Jassi
next prev parent reply other threads:[~2011-07-13 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 11:22 [PATCH] ASoC: SAMSUNG: 24-bit audio playback on Exynos4210 Giridhar Maruthy
2011-07-13 11:48 ` Naveen Krishna Ch
2011-07-13 14:06 ` Jassi Brar [this message]
2011-07-13 23:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABb+yY17WxP7qCbH=QoQyGY3DuH85-0zMS5O2UugQe9_djUGgw@mail.gmail.com' \
--to=jassisinghbrar@gmail.com \
--cc=Kyung-Kwee.Ryu@wolfsonmicro.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=giridhar.maruthy@linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.