All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	linux-usb@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH v2 2/2] usb: gadget: add udc driver for max3420
Date: Wed, 8 Jan 2020 15:13:29 -0600	[thread overview]
Message-ID: <CABb+yY1cSGZRZJEenweRFNPVfkMKiMwowTdnURuFoXnB5+FKGA@mail.gmail.com> (raw)
In-Reply-To: <20200108164159.GA2494836@kroah.com>

On Wed, Jan 8, 2020 at 10:42 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Jan 05, 2020 at 04:55:57PM -0600, jassisinghbrar@gmail.com wrote:
> > --- /dev/null
> > +++ b/drivers/usb/gadget/udc/max3420_udc.c
> > @@ -0,0 +1,1333 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * MAX3420 Device Controller driver for USB.
> > + *
> > + * Author: Jaswinder Singh Brar <jaswinder.singh@linaro.org>
> > + * (C) Copyright 2019 Linaro Ltd
> > + *
> > + * Based on:
> > + *   o MAX3420E datasheet
> > + *           http://datasheets.maximintegrated.com/en/ds/MAX3420E.pdf
> > + *   o MAX342{0,1}E Programming Guides
> > + *           https://pdfserv.maximintegrated.com/en/an/AN3598.pdf
> > + *           https://pdfserv.maximintegrated.com/en/an/AN3785.pdf
> > + *
> > + * This file is licenced under the GPL v2.
>
> This line says that the SPDX line above is a lie :(
>
> Please fix this.
>
Sorry, that is a relic from forward porting the driver. I updated the
copyright year (guess need to again) but missed that line.

> As pennance, please re-read Documentation/process/license-rules.rst.
>
I will take a dozen lines each day before bed.

Cheers still !

      reply	other threads:[~2020-01-08 21:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-05 22:55 [PATCH v2 0/2] Max3420 udc driver jassisinghbrar
2020-01-05 22:55 ` [PATCH v2 1/2] dt-bindings: max3421-udc: add dt bindings for MAX3420 UDC jassisinghbrar
2020-01-06 22:18   ` Rob Herring
2020-01-05 22:55 ` [PATCH v2 2/2] usb: gadget: add udc driver for max3420 jassisinghbrar
2020-01-08 16:41   ` Greg KH
2020-01-08 21:13     ` Jassi Brar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABb+yY1cSGZRZJEenweRFNPVfkMKiMwowTdnURuFoXnB5+FKGA@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.