From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC6D5C433EF for ; Mon, 20 Jun 2022 19:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241494AbiFTTsl (ORCPT ); Mon, 20 Jun 2022 15:48:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343659AbiFTTsi (ORCPT ); Mon, 20 Jun 2022 15:48:38 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A1F219017; Mon, 20 Jun 2022 12:48:37 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id n20so16339572ejz.10; Mon, 20 Jun 2022 12:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s5KulNPMeo7HI8Wh3XOzXN/pOGB2fVu2iIF6zPeqNoQ=; b=HCUgciW1F5vOG395wRxz+cu181/EMw+laM6S+0jZOffpN8a69qw7Xdt7vOIFDLAcQR Zoa2D3OLxtjtUfIXb3+5IpGiDiXbNYbTW1lu7HgORiTCtl5fMl7KsuCWHRroLmwsUx4h ftBZdKHik4Z4LrvGFmU8zeKa9cVEKksz3L8rrJwykvPwsbxlGmMmovysK6ksrloclT3f VPtW+N6YqIdzoAX733KTfX3lX1ULjWM0vWN6Lm9rH6yquLxURdcC9h0OFh0oAtsAGNAC 2LEVUt8L96fz8vmWUzcnvRe49NkP1ZJu+s1KBDMvoBepKrjf8JxZlLTfv0BfPt4++L20 XMdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s5KulNPMeo7HI8Wh3XOzXN/pOGB2fVu2iIF6zPeqNoQ=; b=wJqu5oq/fUBqUElxo1xb4XMW0w5cEHoAQZzAL3GdbZRK3Lx7xK2TO7Vi3JBpdUhfFa dTgTJzoiYb+qcCN0fsFG9M1PYrG5Q2G+G71X/upWL4L7CIVt7t1jBTddIND47H5tWfjK UKJ6RnsLsGS6C4Z8kGGCqL4nOIcphtxixJ9r5YoxRiblMmFeuazUuoUluX8xSnaOFLOL OSGR/k+s4ZscN1SIUlQ/OTe+H39v0pFDckpPYfBNsh3z2if4vazINZj2etxIMlwDTUgC xzS/M8VC4VGKf+32cMD2yCrwovgqz1GvWXvRbbv+YFgPTvcHYKnJeL40yhJM+aAmPKgh HV5Q== X-Gm-Message-State: AJIora+DS1HTNQGttlYQ7yob5tSz+E+vZY9wlzIP5pCzKNUgFAcaMWFl Iio2UxSrmLylRV6a2KIDKsoFsYVw3LWquqJ3UXE= X-Google-Smtp-Source: AGRyM1ta4B0jrT2K8Pn5nSnr2kzekIbKZsWJOBQOjPnQ3zKyEuRnqnZV7sJFu08rjWc7xIIIkj1oLe8LyAtycTl5v64= X-Received: by 2002:a17:906:a202:b0:711:29a:c96c with SMTP id r2-20020a170906a20200b00711029ac96cmr23096630ejy.407.1655754516062; Mon, 20 Jun 2022 12:48:36 -0700 (PDT) MIME-Version: 1.0 References: <20220501103428.111286-1-krzysztof.kozlowski@linaro.org> <20220501103428.111286-2-krzysztof.kozlowski@linaro.org> <09e8c5cf-12fc-a10e-dacd-338b7e271202@linaro.org> In-Reply-To: <09e8c5cf-12fc-a10e-dacd-338b7e271202@linaro.org> From: Jassi Brar Date: Mon, 20 Jun 2022 14:48:24 -0500 Message-ID: Subject: Re: [PATCH 2/2] mailbox: imx: fix duplicated initializer To: Krzysztof Kozlowski Cc: Peng Fan , Viresh Kumar , Tushar Khandelwal , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Jun 20, 2022 at 1:39 PM Krzysztof Kozlowski wrote: > > On 07/05/2022 08:52, Peng Fan wrote: > >> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer > >> > >> rxdb field is being initialized twice: > >> > >> drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [- > >> Werror=override-init] > >> 889 | .rxdb = imx_mu_generic_rxdb, > >> > >> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback") > >> Signed-off-by: Krzysztof Kozlowski > > > > Reviewed-by: Peng Fan > > Thanks for the review. This was a month ago... Anyone willing to pick it up? > There was a predated fix, which was picked. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mailbox?id=262190a8ca2b1e1ec75b8a4f1c7f07e585facd6f Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 372A8C43334 for ; Mon, 20 Jun 2022 19:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DDK44eaSea6W7/6KGjw5OaJ15p/yVd/gNWaf1ZLV18o=; b=n6vPHglvRExTvo jAye82IzH8xiK+w7KshRvd0vwGHDBEeo9KcUJbpfkEZAPMGo1GshPACYSv4S2xaulLDNa0HUz6XKn FL0OjmNx1lqi/htmRskTFvdxGTihGtBVqxk6RsAtnVEEb/EpkR7w8jjNJh16MEq6zE0zmlEKThZzc CH4iPYegCRnc0w0upcJPTUWUwH0Da0zt/OUDeIVe2rKOCE+4LX167jcyE2icrYOni6OrATmqQaai9 SVqVRC4hnbUra4xwCkwC0mN+p+cVKyRsQkF6z9udZxPyFqGxp6/k5MjO0hcoFPGutDPmtmwgCzk8k xBQSfQNA5k2sN0s/Itwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3NO8-0024AL-9T; Mon, 20 Jun 2022 19:48:44 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3NO4-002480-GB for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2022 19:48:42 +0000 Received: by mail-ej1-x62a.google.com with SMTP id v1so23061837ejg.13 for ; Mon, 20 Jun 2022 12:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s5KulNPMeo7HI8Wh3XOzXN/pOGB2fVu2iIF6zPeqNoQ=; b=HCUgciW1F5vOG395wRxz+cu181/EMw+laM6S+0jZOffpN8a69qw7Xdt7vOIFDLAcQR Zoa2D3OLxtjtUfIXb3+5IpGiDiXbNYbTW1lu7HgORiTCtl5fMl7KsuCWHRroLmwsUx4h ftBZdKHik4Z4LrvGFmU8zeKa9cVEKksz3L8rrJwykvPwsbxlGmMmovysK6ksrloclT3f VPtW+N6YqIdzoAX733KTfX3lX1ULjWM0vWN6Lm9rH6yquLxURdcC9h0OFh0oAtsAGNAC 2LEVUt8L96fz8vmWUzcnvRe49NkP1ZJu+s1KBDMvoBepKrjf8JxZlLTfv0BfPt4++L20 XMdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s5KulNPMeo7HI8Wh3XOzXN/pOGB2fVu2iIF6zPeqNoQ=; b=GyKLjBcYdtJ8U6eK4wU960p8RNDqBsWs4Znb7J+STqnGr3UgGCXoLn20genQ8xEWKv 0Bi3s2yxVmDLnKBR9ii0r8vKLi+9MAZjVmhjqSUakzxo0otqbUxGBY1WohL18TaWTplR rOqXFblvAEhfiSAjBF1kdL6ilW5/6ghVTMd+KC/FYaTVDSrmRKwYLuITRsBnyND/x4Mm IDDV+AQ7usbXcUJ4LF0aN75r5qX6KvsR9w377IcIYB9+lxkmOV35MldEheTwbGCD10aC je829a7FgGdp2gnHjp1YQGFI2rblEEAfZWHKcuZtUEjLLZtYd7bmk+tRC4olt3Hj9D8B 5+cg== X-Gm-Message-State: AJIora+fiXu3vjvT+eucVPstk94DbG8GfMs754aJxq2Sx92msQuNS7aI zmFMARXZdglf17TT7UvKqXY3Q4WYY2O4RfDch9A= X-Google-Smtp-Source: AGRyM1ta4B0jrT2K8Pn5nSnr2kzekIbKZsWJOBQOjPnQ3zKyEuRnqnZV7sJFu08rjWc7xIIIkj1oLe8LyAtycTl5v64= X-Received: by 2002:a17:906:a202:b0:711:29a:c96c with SMTP id r2-20020a170906a20200b00711029ac96cmr23096630ejy.407.1655754516062; Mon, 20 Jun 2022 12:48:36 -0700 (PDT) MIME-Version: 1.0 References: <20220501103428.111286-1-krzysztof.kozlowski@linaro.org> <20220501103428.111286-2-krzysztof.kozlowski@linaro.org> <09e8c5cf-12fc-a10e-dacd-338b7e271202@linaro.org> In-Reply-To: <09e8c5cf-12fc-a10e-dacd-338b7e271202@linaro.org> From: Jassi Brar Date: Mon, 20 Jun 2022 14:48:24 -0500 Message-ID: Subject: Re: [PATCH 2/2] mailbox: imx: fix duplicated initializer To: Krzysztof Kozlowski Cc: Peng Fan , Viresh Kumar , Tushar Khandelwal , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_124840_606072_93B67DD7 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 20, 2022 at 1:39 PM Krzysztof Kozlowski wrote: > > On 07/05/2022 08:52, Peng Fan wrote: > >> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer > >> > >> rxdb field is being initialized twice: > >> > >> drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [- > >> Werror=override-init] > >> 889 | .rxdb = imx_mu_generic_rxdb, > >> > >> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback") > >> Signed-off-by: Krzysztof Kozlowski > > > > Reviewed-by: Peng Fan > > Thanks for the review. This was a month ago... Anyone willing to pick it up? > There was a predated fix, which was picked. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mailbox?id=262190a8ca2b1e1ec75b8a4f1c7f07e585facd6f Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel