All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/3] ASoC: h1940: Fix compilation error due to missing header
Date: Sat, 13 Aug 2011 12:37:00 +0530	[thread overview]
Message-ID: <CABb+yY2jDYYOQGsgRZPtOyJmdcLmnd=JsYNftouvVevjvKai9w@mail.gmail.com> (raw)
In-Reply-To: <1313160780-20633-2-git-send-email-anarsoul@gmail.com>

On Fri, Aug 12, 2011 at 8:22 PM, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> Add linux/types.h to fix this compilation error:
>
> In file included from arch/arm/mach-s3c2410/include/mach/gpio-fns.h:27:0,
>                 from arch/arm/mach-s3c2410/include/mach/gpio.h:27,
>                 from /home/anarsoul/work/pda-linux/linux-next/arch/arm/include/asm/gpio.h:5,
>                 from include/linux/gpio.h:18,
>                 from sound/soc/samsung/rx1950_uda1380.c:20:
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:29:34: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘s3c_gpio_pull_t’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:30:34: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘s5p_gpio_drvstr_t’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:57:2: error: expected specifier-qualifier-list before ‘s3c_gpio_pull_t’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:148:47: error: expected declaration specifiers or ‘...’ before ‘s3c_gpio_pull_t’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:156:24: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘s3c_gpio_getpull’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:175:24: error: expected declaration specifiers or ‘...’ before ‘s3c_gpio_pull_t’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h: In function ‘s3c_gpio_cfgrange_nopull’:
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:180:47: error: ‘s3c_gpio_pull_t’ undeclared (first use in this function)
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:180:47: note: each undeclared identifier is reported only once for each function it appears in
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:180:47: error: expected ‘)’ before numeric constant
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:180:47: error: too many arguments to function ‘s3c_gpio_cfgall_range’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:174:12: note: declared here
> arch/arm/plat-samsung/include/plat/gpio-cfg.h: At top level:
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:199:26: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘s5p_gpio_get_drvstr’
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:210:50: error: expected declaration specifiers or ‘...’ before ‘s5p_gpio_drvstr_t’
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Should be ok if the changelog is trimmed ?

Patch 2 and 3
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2011-08-13  7:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 14:52 [PATCH 1/3] soc/soc-io.c: Use regmap_init_{i2c, spi} only if it's available Vasily Khoruzhick
2011-08-12 14:52 ` [PATCH 2/3] ASoC: h1940: Fix compilation error due to missing header Vasily Khoruzhick
2011-08-13  7:07   ` Jassi Brar [this message]
2011-08-14 10:23     ` Mark Brown
2011-08-12 14:53 ` [PATCH 3/3] ASoC: rx1950: " Vasily Khoruzhick
2011-08-12 14:59 ` [PATCH 1/3] soc/soc-io.c: Use regmap_init_{i2c, spi} only if it's available Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABb+yY2jDYYOQGsgRZPtOyJmdcLmnd=JsYNftouvVevjvKai9w@mail.gmail.com' \
    --to=jassisinghbrar@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anarsoul@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.