From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Subject: Re: [PATCH v8 2/4] dt-bindings: mailbox: imx-mu: add generic MU channel support Date: Wed, 1 Aug 2018 15:28:02 +0530 Message-ID: References: <20180731141146.10788-1-o.rempel@pengutronix.de> <20180731141146.10788-3-o.rempel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "A.s. Dong" Cc: Mark Rutland , Devicetree List , Oleksij Rempel , Rob Herring , ", linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream" , ", Sascha Hauer" , Fabio Estevam , Shawn Guo , Vladimir Zapolskiy , dl-linux-imx List-Id: devicetree@vger.kernel.org On Wed, Aug 1, 2018 at 2:28 PM, A.s. Dong wrote: > Hi Jassi, > >> > + The doorbell channels should be used with shared memory and >> protocol >> > + level acknowledgment if needed. >> > + >> I would avoid this. People might get notions that they have to use shmem >> with doorbell -- a trivial protocol might mean doing some fixed action (like >> reset) whenever the doorbell rings. >> > > That's right. > i.MX8 using the general purpose interrupt for peripherals. No shmem needed. > e.g. RTC, Watchdog and ON/OFF interrupt. > > BTW, this means the peripheral will use mailbox doorbell channels to handle > Interrupts. Is there such user case in kernel we can refer to? > I don't find any publicly in kernel. It should be simple though. Acquire the RX channel, and populate the rx_callback() with the "interrupt" handler. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jassisinghbrar@gmail.com (Jassi Brar) Date: Wed, 1 Aug 2018 15:28:02 +0530 Subject: [PATCH v8 2/4] dt-bindings: mailbox: imx-mu: add generic MU channel support In-Reply-To: References: <20180731141146.10788-1-o.rempel@pengutronix.de> <20180731141146.10788-3-o.rempel@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 1, 2018 at 2:28 PM, A.s. Dong wrote: > Hi Jassi, > >> > + The doorbell channels should be used with shared memory and >> protocol >> > + level acknowledgment if needed. >> > + >> I would avoid this. People might get notions that they have to use shmem >> with doorbell -- a trivial protocol might mean doing some fixed action (like >> reset) whenever the doorbell rings. >> > > That's right. > i.MX8 using the general purpose interrupt for peripherals. No shmem needed. > e.g. RTC, Watchdog and ON/OFF interrupt. > > BTW, this means the peripheral will use mailbox doorbell channels to handle > Interrupts. Is there such user case in kernel we can refer to? > I don't find any publicly in kernel. It should be simple though. Acquire the RX channel, and populate the rx_callback() with the "interrupt" handler.