From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752869AbeB1SOW (ORCPT ); Wed, 28 Feb 2018 13:14:22 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:50545 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbeB1SOU (ORCPT ); Wed, 28 Feb 2018 13:14:20 -0500 X-Google-Smtp-Source: AH8x227Q5W8nOGFUS4LRrt07Xex2ASMPXkvoKLqUUoPIaUHZp65KWoNow6He+EERbrpJFSecKxCFnNmf5ynjReoB7Mw= MIME-Version: 1.0 In-Reply-To: References: <20180228022714.30068-1-samuel@sholland.org> <20180228022714.30068-4-samuel@sholland.org> From: Jassi Brar Date: Wed, 28 Feb 2018 23:44:18 +0530 Message-ID: Subject: Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver To: Samuel Holland Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linux Kernel Mailing List , <", linux-arm-kernel"@lists.infradead.org>, ", linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream" , srv_heupstream , Devicetree List , Andre Przywara Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: > Hi, > > On 02/28/18 03:16, Jassi Brar wrote: >> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: >> .... >> >>> +/* >>> + * The message box hardware provides 8 unidirectional channels. As the mailbox >>> + * framework expects them to be bidirectional >>> >> That is incorrect. Mailbox framework does not require a channel to be >> TX and RX capable. > > Sorry, it would be more accurate to say that the intended mailbox _client_ > expects the channels to be bidirectional. > Mailbox clients are very mailbox provider specific. Your client driver is unlikely to be reuseable over another controller+remote combo. Your client has to know already what a physical channel can do (RX, TX or RXTX). There is no api to provide that info. thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Subject: Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver Date: Wed, 28 Feb 2018 23:44:18 +0530 Message-ID: References: <20180228022714.30068-1-samuel@sholland.org> <20180228022714.30068-4-samuel@sholland.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Samuel Holland Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linux Kernel Mailing List , ", linux-arm-kernel"@lists.infradead.org, ", linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream" srv_heupstream , Devicetree List , Andre Przywara List-Id: devicetree@vger.kernel.org On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: > Hi, > > On 02/28/18 03:16, Jassi Brar wrote: >> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: >> .... >> >>> +/* >>> + * The message box hardware provides 8 unidirectional channels. As the mailbox >>> + * framework expects them to be bidirectional >>> >> That is incorrect. Mailbox framework does not require a channel to be >> TX and RX capable. > > Sorry, it would be more accurate to say that the intended mailbox _client_ > expects the channels to be bidirectional. > Mailbox clients are very mailbox provider specific. Your client driver is unlikely to be reuseable over another controller+remote combo. Your client has to know already what a physical channel can do (RX, TX or RXTX). There is no api to provide that info. thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: jassisinghbrar@gmail.com (Jassi Brar) Date: Wed, 28 Feb 2018 23:44:18 +0530 Subject: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver In-Reply-To: References: <20180228022714.30068-1-samuel@sholland.org> <20180228022714.30068-4-samuel@sholland.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: > Hi, > > On 02/28/18 03:16, Jassi Brar wrote: >> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: >> .... >> >>> +/* >>> + * The message box hardware provides 8 unidirectional channels. As the mailbox >>> + * framework expects them to be bidirectional >>> >> That is incorrect. Mailbox framework does not require a channel to be >> TX and RX capable. > > Sorry, it would be more accurate to say that the intended mailbox _client_ > expects the channels to be bidirectional. > Mailbox clients are very mailbox provider specific. Your client driver is unlikely to be reuseable over another controller+remote combo. Your client has to know already what a physical channel can do (RX, TX or RXTX). There is no api to provide that info. thanks