Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

[Pratik Jain <pratik.jain0509@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

Yes, that can be done. But isn't 80 column limit more of a history based
convention?

On Fri, Mar 16, 2018 at 3:47 PM, Ian Abbott <abbotti@mev.co.uk> wrote:

> On 15/03/2018 18:59, Pratik Jain wrote:
>
>> Fixed coding style issue.
>>
>> Signed-off-by: Pratik Jain <pratik.jain0509@gmail.com>
>> ---
>>   drivers/staging/comedi/drivers/ni_atmio.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
>> b/drivers/staging/comedi/drivers/ni_atmio.c
>> index b9e9ab548c4b..4e27a2959b64 100644
>> --- a/drivers/staging/comedi/drivers/ni_atmio.c
>> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
>> @@ -226,8 +226,8 @@ static int ni_isapnp_find_board(struct pnp_dev **dev)
>>         for (i = 0; i < ARRAY_SIZE(ni_boards); i++) {
>>                 isapnp_dev = pnp_find_dev(NULL,
>>                                           ISAPNP_VENDOR('N', 'I', 'C'),
>> -                                         ISAPNP_FUNCTION(ni_boards[i].
>> -                                                         isapnp_id),
>> NULL);
>> +                                         ISAPNP_FUNCTION(ni_boards[i].
>> isapnp_id),
>> +                                         NULL);
>>                 if (!isapnp_dev || !isapnp_dev->card)
>>                         continue;
>>
>>
> I suggest splitting the expression just after the '=' to avoid going over
> 80 columns.
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-
>

[-- Attachment #2: Type: text/html, Size: 2542 bytes --]