From mboxrd@z Thu Jan 1 00:00:00 1970 From: Praveen Kumar Subject: Re: [PATCH v3] xen: sched: removal of redundant check in Credit Date: Sat, 17 Dec 2016 13:44:39 +0530 Message-ID: References: <1481916226-19177-1-git-send-email-kpraveen.lkml@gmail.com> <1481939188.3445.473.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0773650833892740389==" Return-path: In-Reply-To: <1481939188.3445.473.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Dario Faggioli Cc: George Dunlap , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============0773650833892740389== Content-Type: multipart/alternative; boundary=94eb2c076daa2de5950543d647d1 --94eb2c076daa2de5950543d647d1 Content-Type: text/plain; charset=UTF-8 Hi, On Sat, Dec 17, 2016 at 7:16 AM, Dario Faggioli wrote: > On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote: > > The patch gets rid of a redundant check in csched_vcpu_acct. In fact, > > the function is only called from csched_tick, which already checks > > that current is not the idle vcpu. The patch also adds an ASSERT to > > the same effect, in order to make assumption ( i.e., no calling this > > on idle vcpus) even more clear and as a guard for future mis-use. > > > > Signed-off-by: Praveen Kumar > > Acked-by: Dario Faggioli > > > Better than before. But still, if I: > - save this mail as mbox > - try to import it in git > it fails. > > OTOH, if I: > - save this mail as mbox > - run dos2unix on the mbox file > - try to import it in git > it works! > > Which, since you're now using git-send-email, makes me think it may be > your editor/OS which is at fault and inserts spurious stuff at line > breaks (the classic CR vs. CR+LF thing). > > What editor on what OS are you using? > I am using SLED machine and vim editor. I tried checking with vimdiff over the patch generated and mbox file ( create by evolution ), I found spurious stuff (^M) as mentioned added. After dos2unix, the mbox file was same to that of the patch sent. > > Another possibility is that there is something wrong here at my hand. > George, do you have (similar) issues when trying to apply this patch? > > Regards, > Dario > -- > <> (Raistlin Majere) > ----------------------------------------------------------------- > Dario Faggioli, Ph.D, http://about.me/dario.faggioli > Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --94eb2c076daa2de5950543d647d1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

On Sat, Dec 17, 2016 at 7:16 AM, Dario Faggioli &l= t;dario.fagg= ioli@citrix.com> wrote:
On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote:
> The patch gets rid of a redundant check in csched_vcpu_acct. In fact,<= br> > the function is only called from csched_tick, which already checks
> that current is not the idle vcpu. The patch also adds an ASSERT to > the same effect, in order to make assumption ( i.e., no calling this > on idle vcpus) even more clear and as a guard for future mis-use.
>
> Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
> Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
>
Better than before. But still, if I:
=C2=A0- save this mail as mbox
=C2=A0- try to import it in git
it fails.

OTOH, if I:
=C2=A0- save this mail as mbox
=C2=A0- run dos2unix on the mbox file
=C2=A0- try to import it in git
it works!

Which, since you're now using git-send-email, makes me think it may be<= br> your editor/OS which is at fault and inserts spurious stuff at line
breaks (the classic CR vs. CR+LF thing).

What editor on what OS are you using?

I= am using SLED machine and vim editor. I tried checking with vimdiff over t= he patch generated and mbox file ( create by evolution ), I found spurious = stuff (^M) as mentioned added. After dos2unix, the mbox file was same to th= at of the patch sent.=C2=A0

Another possibility is that there is something wrong here at my hand.
George, do you have (similar) issues when trying to apply this patch?

Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majer= e)
-----------------------------------------------------------------=
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

--94eb2c076daa2de5950543d647d1-- --===============0773650833892740389== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0773650833892740389==--