All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Larson <chris_larson@mentor.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] watchdog: kill update-rc.d when not using sysvinit
Date: Thu, 30 Jul 2015 08:13:20 -0700	[thread overview]
Message-ID: <CABcZAN=FEL8O2nW4o8cJmFaJTfm_eE6tFRDODr8+ZPN6kvh=tw@mail.gmail.com> (raw)
In-Reply-To: <CAJTo0LatBaSsow-h=3UTjurFyY9=PLvzi8efSohni8uXtMf=Nw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

On Thu, Jul 30, 2015 at 5:53 AM, Burton, Ross <ross.burton@intel.com> wrote:

> On 29 July 2015 at 21:09, Christopher Larson <chris_larson@mentor.com>
> wrote:
>
>> The dependency on initscripts via VIRTUAL-RUNTIME_initscripts is a
>>> DEPENDS, so it's build time.  The runtime dependency is on
>>> initscripts-functions.
>>>
>>> As far as I'm aware the sysv-generator used the rcX.d symlinks generated
>>> by update-rcd to decide what to start when, so you can't just disable the
>>> class and expect it to still work.
>>>
>>
>> VIRTUAL-RUNTIME_initscripts is installed at runtime (as you can tell by
>> its name) in packagegroup-core-boot and packagegroup-core-full-cmdline
>> both. If I don’t want it in my images, wiping the variable is the only
>> method that makes any sense.
>
>
> So there's the problem, and breaking watchdog isn't solving it.


I don’t think taking a package that won’t even install, breaking image
creation entirely, and letting it install, though not autostart, is
“breaking watchdog” any worse than it already was.

That said, a better approach would probably be for update-rc.d.bbclass to
explicitly DEPENDS on initscripts, not VIRTUAL-RUNTIME_initscripts. The
latter isn’t guaranteed to provide initscripts-functions, it could be any
recipe that provides baseline startup scripts. Adding initscripts directly
would ensure that the initscripts-functions runtime dependency is satisfied
in all cases.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2563 bytes --]

  reply	other threads:[~2015-07-30 15:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 17:11 [PATCH] watchdog: kill update-rc.d when not using sysvinit Abdur Rehman
2015-07-28 20:46 ` Burton, Ross
2015-07-29 18:05   ` Rehman, Abdur
2015-07-29 18:35     ` Burton, Ross
2015-07-29 19:27       ` Christopher Larson
2015-07-29 19:48         ` Burton, Ross
2015-07-29 20:09           ` Christopher Larson
2015-07-30 12:53             ` Burton, Ross
2015-07-30 15:13               ` Christopher Larson [this message]
2015-07-29 20:19         ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABcZAN=FEL8O2nW4o8cJmFaJTfm_eE6tFRDODr8+ZPN6kvh=tw@mail.gmail.com' \
    --to=chris_larson@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.