Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

From: "Christopher Larson" <kergoth@gmail.com>
To: bkylerussell@gmail.com
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build
Date: Fri, 30 Jul 2021 14:16:09 -0700	[thread overview]
Message-ID: <CABcZANk3YS-mnR8d0ScZA3E4coCa5Zze0UAueJxQjpwO1L1x6A@mail.gmail.com> (raw)
In-Reply-To: <20210730190357.369782-1-bkylerussell@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

This will result in a behavior change, making it so `bitbake gcc-runtime`
will run the check task. Are there implications to this?

On Fri, Jul 30, 2021 at 12:04 PM <bkylerussell@gmail.com> wrote:

> Otherwise, when rm_work is used, do_check may not execute before rm_work
> causing do_check failures if the workdir has been removed underneath it.
>
> Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-runtime.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc
> b/meta/recipes-devtools/gcc/gcc-runtime.inc
> index 59d9a24686..607971adca 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
> @@ -314,5 +314,5 @@ do_check() {
>
>      oe_runmake -i ${MAKE_CHECK_TARGETS}
> RUNTESTFLAGS="${MAKE_CHECK_RUNTESTFLAGS}"
>  }
> -addtask check after do_compile do_populate_sysroot
> +addtask check after do_compile do_populate_sysroot before do_build
>
> --
> 2.25.1
>
>
> 
>
>

-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1750 bytes --]