All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Larson <clarson@kergoth.com>
To: Openembedded Discussion <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-networking][PATCH 2/2] meta-networking: override SECURITY_CFLAGS for c-ares
Date: Fri, 15 Jul 2016 07:34:33 -0700	[thread overview]
Message-ID: <CABcZANna5ip=FF0NknkneG6pj6w3SvKyrRdP+zmK+vMJgGbnxA@mail.gmail.com> (raw)
In-Reply-To: <1468587261-18160-2-git-send-email-git@andred.net>

On Fri, Jul 15, 2016 at 5:54 AM, <git@andred.net> wrote:

> From: André Draszik <adraszik@tycoint.com>
>
> c-ares doesn't build if the distro has enabled usage of the
> security_flags.inc file as it is picky about what is placed
> into CPPFLAGS and CFLAGS. It complains and errors out if any
> preprocessor options appear in CFLAGS.
>
> Fix this by providing an additional include file that is
> require'd from conf/layer.conf.
>
> Signed-off-by: André Draszik <adraszik@tycoint.com>
>

This commit message is a little misleading. The fact that you added a .inc
isn't what fixed the problem, the move of the defines from CFLAGS to
CPPFLAGS was.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics


  reply	other threads:[~2016-07-15 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15 12:54 [meta-networking][PATCH 1/2] c-ares: use our compilation flags git
2016-07-15 12:54 ` [meta-networking][PATCH 2/2] meta-networking: override SECURITY_CFLAGS for c-ares git
2016-07-15 14:34   ` Christopher Larson [this message]
2016-07-16 10:52     ` André Draszik
2016-07-21 13:51   ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABcZANna5ip=FF0NknkneG6pj6w3SvKyrRdP+zmK+vMJgGbnxA@mail.gmail.com' \
    --to=clarson@kergoth.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.