All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Allred <allred.sean@gmail.com>
To: git@vger.kernel.org
Subject: Bug report: 'filtering content' delayed progress message does not respect --quiet
Date: Sun, 21 Mar 2021 15:53:07 -0500	[thread overview]
Message-ID: <CABceR4ZFVW=zeSwef7_dP+TWZ29J7BUkmMEB1CzCz=et_yYS9w@mail.gmail.com> (raw)

Hi folks,

Submitting the filled-out template from git-bugreport. Let me know if
I can be of any assistance.

Thanks!
-Sean

Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.

What did you do before the bug happened? (Steps to reproduce your issue)

  Called `git clone --quiet git://path/to/private/repo`

What did you expect to happen? (Expected behavior)

  Expected git to be quiet :-)  Did not expect writes to stderr/stdout.

What happened instead? (Actual behavior)

  Received output that looked like

      Filtering content:  --% (--/--), --.-- MiB | --.-- MiB/s

What's different between what you expected and what actually happened?

  `--quiet` should suppress all output, but in actuality, that line
  was still output.

Anything else you want to add:

  Submitting from https://github.com/git-lfs/git-lfs/issues/1270 (re
  https://github.com/git-lfs/git-lfs/issues/1270#issuecomment-461176647).
  Other details may be available there.

  I've verified I can still reproduce on the current version of git
  (listed below) with a private repo (note to self:
  gid://gitlab/Project/2458).

  It looks like we need similar handling from
  index_pack.c:resolve_deltas at entry.c:finish_delayed_checkout.  It
  looks like the necessary state may not be available where it's
  needed, but this is based on about two minutes of reading :-)

Please review the rest of the bug report below.
You can delete any lines you don't wish to share.


[System Info]
git version:
git version 2.31.0.windows.1
cpu: x86_64
built from commit: 959b2f0c6fb12f8ba13f9015c4482fa8133b7f9c
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon
uname: Windows 10.0 17763
compiler info: gnuc: 10.2
libc info: no libc information available
$SHELL (typically, interactive shell): <unset>


[Enabled Hooks]
not run from a git repository - no hooks to show


-- 
-Sean

             reply	other threads:[~2021-03-21 20:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21 20:53 Sean Allred [this message]
2021-03-26  8:31 ` Bug report: 'filtering content' delayed progress message does not respect --quiet Jeff King
2021-08-25 18:15   ` [PATCH] checkout: make delayed checkout respect --quiet and --no-progress Matheus Tavares
2021-08-25 23:35     ` Ævar Arnfjörð Bjarmason
2021-08-26 14:26       ` Matheus Tavares Bernardino
2021-08-27  2:26         ` Jeff King
2021-08-26 19:10     ` [PATCH v2] " Matheus Tavares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABceR4ZFVW=zeSwef7_dP+TWZ29J7BUkmMEB1CzCz=et_yYS9w@mail.gmail.com' \
    --to=allred.sean@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.