From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31320C432BE for ; Tue, 31 Aug 2021 19:41:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 943B960F6C for ; Tue, 31 Aug 2021 19:41:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 943B960F6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:59408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL9d8-0007gg-Kt for qemu-devel@archiver.kernel.org; Tue, 31 Aug 2021 15:41:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL9a2-0003dY-Uu for qemu-devel@nongnu.org; Tue, 31 Aug 2021 15:37:58 -0400 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]:36779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL9a0-0008FC-P5 for qemu-devel@nongnu.org; Tue, 31 Aug 2021 15:37:58 -0400 Received: by mail-oo1-xc31.google.com with SMTP id y47-20020a4a9832000000b00290fb9f6d3fso94966ooi.3 for ; Tue, 31 Aug 2021 12:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H0tU/y9/j09/hyYmNZiveYjYN7sJfhDHgXlzEnFKnnE=; b=gTqpyQezSuQ+9HzdZ61lSQ2PLt6xKzIYSUSdABGURfFZ0Yi7ilorc5csMPS6xQO3rs XPEavtbkLe432Xkc8dbMd6KhbMgNE2k9d370Rr9YQzgQvM2VMxtGBUGG8Bo9rLC4qS1X ixMiYSmoAnJpxL/we+30Sgen09AHpFGt0L4gH6NglIMU6fbaytaVE6U4Z05vZySf5BXk aCvx2eTANwWVN44R5Z/4CsFZ9TebP7UCHeR0BuHX2udoRXjKFDR4NGhf7MA7//0Ciz3T Dm4K/mh2qgcds2nKREx8rhTK/gHycTd55Yx+wtFMsG3BvGE4vvPr0z53qnaez9ccMA+m ThXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H0tU/y9/j09/hyYmNZiveYjYN7sJfhDHgXlzEnFKnnE=; b=dhZegf7xUhoQbjEjXlQ/Habt/NT4s2shyHuvNFhXUugH3RMYPtUrkSdeEAWEZ1Hp3R fv6Qn3zdT90wT93R9+7gGJR1iWM0HcO7XEN4IGkQBQasrQR/piNvpVkfJclbPcEvpE5d vzx7Og+cedblN+48138cTibvogDQCuDVGCPyFPXpIqutREuF72MZcUjVSfv+bcHN787e AHj0KC+g5Py6TYBI8OSgwKpCJk2dZHAednZhao27rSF6KVHHG1btKzmEDJ0/aHPHQHqz XJQqzz89A7So2nogLtw2xtXL1D/MJqJh/df3cEPwffjH2p3feZVVo+m25/FIZHwngsIC txlg== X-Gm-Message-State: AOAM531yP8ae+pQ61gOfnmawMti9Ow3xShkbh/UiufxjP67F9lshQLOI PSCTdZ0ZKiB8zRYhupxSvbQZUIwUu9RTtmTj72hvbw== X-Google-Smtp-Source: ABdhPJxEja5/mZkO9Tc4qR2Tj6qsJ+X9M7v02+csDH4au6wSMw+NfBOZFXvFaPZLKLjdmuxo9xkSa98jXKUk+yjZuKw= X-Received: by 2002:a4a:3e58:: with SMTP id t85mr15745785oot.81.1630438674987; Tue, 31 Aug 2021 12:37:54 -0700 (PDT) MIME-Version: 1.0 References: <20210713153758.323614-1-andrew@daynix.com> <20210713153758.323614-6-andrew@daynix.com> <87y29dct4m.fsf@dusky.pond.sub.org> <877dgbpco1.fsf@dusky.pond.sub.org> <87v93n8nu3.fsf@dusky.pond.sub.org> <87a6kz8i4g.fsf@dusky.pond.sub.org> <87k0k1wtfc.fsf@dusky.pond.sub.org> In-Reply-To: <87k0k1wtfc.fsf@dusky.pond.sub.org> From: Andrew Melnichenko Date: Tue, 31 Aug 2021 22:37:44 +0300 Message-ID: Subject: Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command. To: Markus Armbruster Content-Type: multipart/alternative; boundary="0000000000000d0d1a05cae01690" Received-SPF: none client-ip=2607:f8b0:4864:20::c31; envelope-from=andrew@daynix.com; helo=mail-oo1-xc31.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Yuri Benditovich , Yan Vugenfirer , Eric Blake Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000000d0d1a05cae01690 Content-Type: text/plain; charset="UTF-8" Hi, > Got something I could git-pull? > I can share some links for tests: https://github.com/daynix/qemu/tree/HelperEBPFv3 - qemu with helper https://github.com/daynix/libvirt/tree/RSS_RFC_v1 - libvirt with RSS On Tue, Aug 31, 2021 at 6:00 PM Markus Armbruster wrote: > Yuri Benditovich writes: > > > On Mon, Aug 30, 2021 at 11:14 AM Markus Armbruster > wrote: > >> > >> Yuri Benditovich writes: > >> > >> > On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster > wrote: > > [...] > > >> >> So let's try again: if libvirt does use the wrong RSS helper, how > does > >> >> the system behave? > >> > > >> > The receive-side scaling may work incorrectly, i.e. finally may move > >> > incoming packets to a virtqueue different than expected one. > >> > >> Then I'm confused about the purpose of "the stamp" mentioned below. Can > >> you enlighten me? > > > > The stamp is a string (common for qemu executable and RSS helper > > executable during build) that qemu can later retrieve from the helper > > in run-time and ensure this helper is fully compatible with this build > > of qemu (in terms of eBPF operation). The helper is built with the > > same C headers (related to ebpf operation) as the qemu, the qemu is > > able to receive file descriptors created by the helper (of ebpf > > program and ebpf data structure's maps) from libvirt and deal with > > them as if it has created them. > > Thanks. > > I tried to apply your series to check a few of my assumptions, but I'm > getting conflicts. Got something I could git-pull? > > [...] > > --0000000000000d0d1a05cae01690 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
Got something I could git-pull?
I can sha= re some links for tests:

On Tue, Aug 31, 2021 at 6:00 PM Markus Armbruster <armbru@redhat.com> wrote:
Yuri Benditovich <yuri.bendito= vich@daynix.com> writes:

> On Mon, Aug 30, 2021 at 11:14 AM Markus Armbruster <armbru@redhat.com> wrote: >>
>> Yuri Benditovich <yuri.benditovich@daynix.com> writes:
>>
>> > On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster <armbru@redhat.com> w= rote:

[...]

>> >> So let's try again: if libvirt does use the wrong RSS= helper, how does
>> >> the system behave?
>> >
>> > The receive-side scaling may work incorrectly, i.e. finally m= ay move
>> > incoming packets to a virtqueue different than expected one.<= br> >>
>> Then I'm confused about the purpose of "the stamp" m= entioned below.=C2=A0 Can
>> you enlighten me?
>
> The stamp is a string (common for qemu executable and RSS helper
> executable during build) that qemu can later retrieve from the helper<= br> > in run-time and ensure this helper is fully compatible with this build=
> of qemu (in terms of eBPF operation). The helper is built with the
> same C headers (related to ebpf operation) as the qemu, the qemu is > able to receive file descriptors created by the helper (of ebpf
> program and ebpf data structure's maps) from libvirt and deal with=
> them as if it has created them.

Thanks.

I tried to apply your series to check a few of my assumptions, but I'm<= br> getting conflicts.=C2=A0 Got something I could git-pull?

[...]

--0000000000000d0d1a05cae01690--