From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46846)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <davidkiarie4@gmail.com>) id 1bLPnX-0005dg-Ek
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 03:02:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <davidkiarie4@gmail.com>) id 1bLPnV-0006Ii-JK
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 03:02:02 -0400
Received: from mail-yw0-x241.google.com ([2607:f8b0:4002:c05::241]:35657)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <davidkiarie4@gmail.com>) id 1bLPnV-0006Ie-F1
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 03:02:01 -0400
Received: by mail-yw0-x241.google.com with SMTP id c13so4845350ywh.2
	for <qemu-devel@nongnu.org>; Fri, 08 Jul 2016 00:02:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5779F708.7060704@web.de>
References: <1465993312-18119-1-git-send-email-davidkiarie4@gmail.com>
	<1465993312-18119-4-git-send-email-davidkiarie4@gmail.com>
	<576AF3E2.4060108@web.de>
	<CABdVeABO79bNBm-RuO2zw5JpiVDoPLwOM6ssw=Ye9MdbAmz+qQ@mail.gmail.com>
	<5779F708.7060704@web.de>
From: David Kiarie <davidkiarie4@gmail.com>
Date: Fri, 8 Jul 2016 10:01:59 +0300
Message-ID: <CABdVeABLWxmTRGw1c+OYnuiwB6rUGQLMfPhi=Vq-dBLaO_TD4w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [V12 3/4] hw/i386: Introduce AMD IOMMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Marcel Apfelbaum <marcel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Peter Xu <peterx@redhat.com>, alex.williamson@redhat.com, Valentine Sinitsyn <valentine.sinitsyn@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>

On Mon, Jul 4, 2016 at 8:41 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
> On 2016-07-04 07:06, David Kiarie wrote:
>> On Wed, Jun 22, 2016 at 11:24 PM, Jan Kiszka <jan.kiszka@web.de> wrote:
>>> On 2016-06-15 14:21, David Kiarie wrote:
>>>> +
>>>> +
>>>> +/* PCI SIG constants */
>>>> +#define PCI_BUS_MAX 256
>>>> +#define PCI_SLOT_MAX 32
>>>> +#define PCI_FUNC_MAX 8
>>>> +#define PCI_DEVFN_MAX 256
>>>
>>> Shouldn't those four go to the pci header?
>>
>> The macros/defines in PCI header are picked from linux while some of
>> these are not picked from linux. I'v prefixed them with AMDVI_ though.
>
> They are not AMDVI-specific, rather PCI-generic.

Am I getting you right here, the above should go into PCI header, right ?

>
> Jan
>
>