From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ladi Prosek <lprosek@redhat.com>
Subject: Re: [PATCH] KVM: SVM: handle singlestep exception when skipping
 emulated instructions
Date: Wed, 21 Jun 2017 22:17:18 +0200
Message-ID: <CABdb736pjnPuP7bFh43uqGoNgW3M=zGvQ_=WM-z8vFVoSuNC5w@mail.gmail.com>
References: <20170621133741.25627-1-lprosek@redhat.com> <20170621165501.GA27032@potion>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Cc: KVM list <kvm@vger.kernel.org>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ua0-f172.google.com ([209.85.217.172]:36357 "EHLO
        mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751976AbdFUURU (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 21 Jun 2017 16:17:20 -0400
Received: by mail-ua0-f172.google.com with SMTP id g40so124714039uaa.3
        for <kvm@vger.kernel.org>; Wed, 21 Jun 2017 13:17:19 -0700 (PDT)
In-Reply-To: <20170621165501.GA27032@potion>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jun 21, 2017 at 6:55 PM, Radim Krčmář <rkrcmar@redhat.com> wrote:
> 2017-06-21 15:37+0200, Ladi Prosek:
>> kvm_skip_emulated_instruction handles the singlestep debug exception
>> which is something we almost always want. This commit (specifically
>> the change in rdmsr_interception) makes the debug.flat KVM unit test
>> pass on AMD.
>
> kvm_skip_emulated_instruction() also has a return value, which says
> whether the debug exception was requested by the userspace or by the
> guest (userspace has priority).
>
> This patch fixes the guest debugging, but userspace still won't receive
> its events.  I think it would be better to fix both at once,

Will do, thanks!