From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26EFC11F67 for ; Tue, 29 Jun 2021 17:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96E2361DE2 for ; Tue, 29 Jun 2021 17:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233299AbhF2RiE (ORCPT ); Tue, 29 Jun 2021 13:38:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232308AbhF2RiD (ORCPT ); Tue, 29 Jun 2021 13:38:03 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7852BC061760 for ; Tue, 29 Jun 2021 10:35:34 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id c17so11760559ejk.13 for ; Tue, 29 Jun 2021 10:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AR518AYffDucPqzd6GpEc0fpZu1ity7ryBoeYS6VKpM=; b=s/B5H56H4gU82Gp6P64hMNmHHdlcpEN6YXZM9aJVcRaJAWvqnQ6jgSriUY14Ic/NcP dy5st7yhJ4DU0QHwDNFaXUCWEi0m50cR/OjM2krNjL94wOLgwxueH8cKfmlxXjkTYY7B 6ffKcHtucifvn4CLA/aYFqkxWyGHZLlq1qRDom+3IIF3tWZAjOSQIWUnF7vR7Uk1RpgF aKihl+5b1owtWMmuiX7vEerJEmi5wO8MftxzE4fFgUKZg8NhVwQesUIdp7lSDtxmZreQ Grrc6g+MLQULEp7PnSU23VE+CqzpPDzegwf8tPAKFWkNw04CXuXzOK9+29pVzVjOokN+ KfJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AR518AYffDucPqzd6GpEc0fpZu1ity7ryBoeYS6VKpM=; b=JuquOAKpmoMWojo9vjNuiYfaq+4/LVriJ+1cWNysudrlAKG3tMd9TlIdMW8/9EO6Y9 0KeZSxrmmR5wsQWGMyVDniv8HC7ERP6bWNXJv4XNyO8BCQ+AeYJZ8xSmE/4MV30JOvpI WNtd9mFHGH2+S4QpVEWnyl3Y+DQEWzcWEikbXKS871xWn2X3bk1ITeCQ24vt2YIjdCtL DI6GK+bReu3WHfEIbhsJeEK+SFKDimwcgPvM9Kz6yuhTVxN4UT31Xda3bTtDSZopUh5k 3MyLYblI2HuzLoPYxkqYF87jnFuzxwvaGZs/Ma0+xYfLmDe6eoaVWodkwLxvmLU5uPfG n56w== X-Gm-Message-State: AOAM530lMMu/Qnoku/eHsBFwHFxZzSNFr+9mQTlm8k/pWjsJkl/z+7xz H4j/xce3MZlSxZaZwfLYQ8jje3UoVwz9uV2Mt2fnZQ== X-Google-Smtp-Source: ABdhPJx357cBFSDeJIq+SFagT0F9i3UmguYWEoihimZ4PczMNFpyw7EKJ6U7OhMqBkG4xqQtWP0detZF5ur4Z8O/+4o= X-Received: by 2002:a17:906:5d06:: with SMTP id g6mr31659399ejt.342.1624988133039; Tue, 29 Jun 2021 10:35:33 -0700 (PDT) MIME-Version: 1.0 References: <20210524110222.2212-1-shameerali.kolothum.thodi@huawei.com> <20210524110222.2212-4-shameerali.kolothum.thodi@huawei.com> <9e788789-c1c2-10f1-d99c-93cfa6ea3348@arm.com> <3206cd67962242a69fb83adac892e34c@huawei.com> In-Reply-To: <3206cd67962242a69fb83adac892e34c@huawei.com> From: Jon Nettleton Date: Tue, 29 Jun 2021 19:34:56 +0200 Message-ID: Subject: Re: [PATCH v5 3/8] ACPI/IORT: Add a helper to retrieve RMR memory regions To: Shameerali Kolothum Thodi Cc: Robin Murphy , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Linuxarm , "steven.price@arm.com" , "Guohanjun (Hanjun Guo)" , yangyicong , "Sami.Mujawar@arm.com" , wanghuiqiang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jun 14, 2021 at 2:49 PM Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Robin Murphy [mailto:robin.murphy@arm.com] > > Sent: 14 June 2021 12:23 > > To: Shameerali Kolothum Thodi ; > > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > iommu@lists.linux-foundation.org > > Cc: jon@solid-run.com; Linuxarm ; > > steven.price@arm.com; Guohanjun (Hanjun Guo) ; > > yangyicong ; Sami.Mujawar@arm.com; > > wanghuiqiang > > Subject: Re: [PATCH v5 3/8] ACPI/IORT: Add a helper to retrieve RMR memory > > regions > > > > On 2021-05-24 12:02, Shameer Kolothum wrote: > > > Add a helper function that retrieves RMR memory descriptors > > > associated with a given IOMMU. This will be used by IOMMU > > > drivers to setup necessary mappings. > > > > > > Now that we have this, invoke it from the generic helper > > > interface. > > > > > > Signed-off-by: Shameer Kolothum > > > > > --- > > > drivers/acpi/arm64/iort.c | 50 > > +++++++++++++++++++++++++++++++++++++++ > > > drivers/iommu/dma-iommu.c | 4 ++++ > > > include/linux/acpi_iort.h | 7 ++++++ > > > 3 files changed, 61 insertions(+) > > > > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > > index fea1ffaedf3b..01917caf58de 100644 > > > --- a/drivers/acpi/arm64/iort.c > > > +++ b/drivers/acpi/arm64/iort.c > > > @@ -12,6 +12,7 @@ > > > > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -837,6 +838,53 @@ static inline int iort_add_device_replay(struct > > device *dev) > > > return err; > > > } > > > > > > +/** > > > + * iort_iommu_get_rmrs - Helper to retrieve RMR info associated with > > IOMMU > > > + * @iommu: fwnode for the IOMMU > > > + * @head: RMR list head to be populated > > > + * > > > + * Returns: 0 on success, <0 failure > > > + */ > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *head) > > > +{ > > > + struct iort_rmr_entry *e; > > > + struct acpi_iort_node *iommu; > > > + int rmrs = 0; > > > + > > > + iommu = iort_get_iort_node(iommu_fwnode); > > > + if (!iommu || list_empty(&iort_rmr_list)) > > > + return -ENODEV; > > > + > > > + list_for_each_entry(e, &iort_rmr_list, list) { > > > + int prot = IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | > > IOMMU_MMIO; > > > + struct iommu_resv_region *region; > > > + enum iommu_resv_type type; > > > + struct acpi_iort_rmr_desc *rmr_desc; > > > + > > > + if (e->smmu != iommu) > > > + continue; > > > + > > > + rmr_desc = e->rmr_desc; > > > + if (e->flags & IOMMU_RMR_REMAP_PERMITTED) > > > + type = IOMMU_RESV_DIRECT_RELAXABLE; > > > + else > > > + type = IOMMU_RESV_DIRECT; > > I have been looking at this a bit more and looking at the history of RMR_REMAP_PERMITTED. Based on the history I have found it seems to me like this would be the better options for prot. @@ -840,7 +840,7 @@ int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, return -ENODEV; list_for_each_entry(e, &iort_rmr_list, list) { - int prot = IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_MMIO; + int prot = IOMMU_READ | IOMMU_WRITE; struct iommu_resv_region *region; enum iommu_resv_type type; struct acpi_iort_rmr_desc *rmr_desc; @@ -849,10 +849,13 @@ int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, continue; rmr_desc = e->rmr_desc; - if (e->flags & IOMMU_RMR_REMAP_PERMITTED) + if (e->flags & IOMMU_RMR_REMAP_PERMITTED) { type = IOMMU_RESV_DIRECT_RELAXABLE; - else + prot |= IOMMU_CACHE; + } else { type = IOMMU_RESV_DIRECT; + prot |= IOMMU_MMIO; + } region = iommu_alloc_resv_region(rmr_desc->base_address, rmr_desc->length, any input on this? My reasoning is that IOMMU_RESV_DIRECT is specifically referenced for things like MSI doorbell and in all the examples needs IOMMU_MMIO, while REMAP_PERMITTED seems to be used for allocated system memory that is then used for device specific reserved regions which commits say would be like a GPU or USB device. -Jon > > Wasn't the idea that we can do all this during the initial parsing, i.e. > > we don't even have iort_rmr_entry, we store them as iommu_resv_regions > > and simply kmemdup() or whatever at this point? > > > Hmm... Not yet. I removed struct iommu_rmr() from v4. But yes, it looks like > we can get rid of iort_rmr_entry as well. Will give it a go in next. > > Thanks, > Shameer > > > Robin. > > > > > + > > > + region = iommu_alloc_resv_region(rmr_desc->base_address, > > > + rmr_desc->length, > > > + prot, type); > > > + if (region) { > > > + region->fw_data.rmr.flags = e->flags; > > > + region->fw_data.rmr.sid = e->sid; > > > + list_add_tail(®ion->list, head); > > > + rmrs++; > > > + } > > > + } > > > + > > > + return (rmrs == 0) ? -ENODEV : 0; > > > +} > > > + > > > /** > > > * iort_iommu_msi_get_resv_regions - Reserved region driver helper > > > * @dev: Device from iommu_get_resv_regions() > > > @@ -1108,6 +1156,8 @@ int iort_iommu_msi_get_resv_regions(struct > > device *dev, struct list_head *head) > > > const struct iommu_ops *iort_iommu_configure_id(struct device *dev, > > > const u32 *input_id) > > > { return NULL; } > > > +int iort_iommu_get_rmrs(struct fwnode_handle *fwnode, struct list_head > > *head) > > > +{ return -ENODEV; } > > > #endif > > > > > > static int nc_dma_get_range(struct device *dev, u64 *size) > > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > > > index 229ec65d98be..f893d460cfa4 100644 > > > --- a/drivers/iommu/dma-iommu.c > > > +++ b/drivers/iommu/dma-iommu.c > > > @@ -185,6 +185,9 @@ EXPORT_SYMBOL(iommu_put_dma_cookie); > > > int iommu_dma_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > struct list_head *list) > > > { > > > + if (!is_of_node(iommu_fwnode)) > > > + return iort_iommu_get_rmrs(iommu_fwnode, list); > > > + > > > return -EINVAL; > > > } > > > EXPORT_SYMBOL(iommu_dma_get_rmrs); > > > @@ -200,6 +203,7 @@ EXPORT_SYMBOL(iommu_dma_get_rmrs); > > > void iommu_dma_put_rmrs(struct fwnode_handle *iommu_fwnode, > > > struct list_head *list) > > > { > > > + generic_iommu_put_resv_regions(iommu_fwnode->dev, list); > > > } > > > EXPORT_SYMBOL(iommu_dma_put_rmrs); > > > > > > diff --git a/include/linux/acpi_iort.h b/include/linux/acpi_iort.h > > > index 1a12baa58e40..e8c45fa59531 100644 > > > --- a/include/linux/acpi_iort.h > > > +++ b/include/linux/acpi_iort.h > > > @@ -39,6 +39,8 @@ const struct iommu_ops > > *iort_iommu_configure_id(struct device *dev, > > > const u32 *id_in); > > > int iort_iommu_msi_get_resv_regions(struct device *dev, struct list_head > > *head); > > > phys_addr_t acpi_iort_dma_get_max_cpu_address(void); > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *list); > > > #else > > > static inline void acpi_iort_init(void) { } > > > static inline u32 iort_msi_map_id(struct device *dev, u32 id) > > > @@ -59,6 +61,11 @@ int iort_iommu_msi_get_resv_regions(struct device > > *dev, struct list_head *head) > > > > > > static inline phys_addr_t acpi_iort_dma_get_max_cpu_address(void) > > > { return PHYS_ADDR_MAX; } > > > + > > > +static inline > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *list) > > > +{ return -ENODEV; } > > > #endif > > > > > > #endif /* __ACPI_IORT_H__ */ > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF32C11F67 for ; Tue, 29 Jun 2021 17:35:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43BC361DE4 for ; Tue, 29 Jun 2021 17:35:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43BC361DE4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=solid-run.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 11B5260A6B; Tue, 29 Jun 2021 17:35:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kOHENJwC7Hl8; Tue, 29 Jun 2021 17:35:39 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id BC4AE60A41; Tue, 29 Jun 2021 17:35:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A4A60C001A; Tue, 29 Jun 2021 17:35:38 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 274CFC001A for ; Tue, 29 Jun 2021 17:35:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2853E40410 for ; Tue, 29 Jun 2021 17:35:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=solid-run-com.20150623.gappssmtp.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e1EoR3AJ8JcH for ; Tue, 29 Jun 2021 17:35:35 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by smtp2.osuosl.org (Postfix) with ESMTPS id CFAD04041E for ; Tue, 29 Jun 2021 17:35:34 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id b2so6372352ejg.8 for ; Tue, 29 Jun 2021 10:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AR518AYffDucPqzd6GpEc0fpZu1ity7ryBoeYS6VKpM=; b=s/B5H56H4gU82Gp6P64hMNmHHdlcpEN6YXZM9aJVcRaJAWvqnQ6jgSriUY14Ic/NcP dy5st7yhJ4DU0QHwDNFaXUCWEi0m50cR/OjM2krNjL94wOLgwxueH8cKfmlxXjkTYY7B 6ffKcHtucifvn4CLA/aYFqkxWyGHZLlq1qRDom+3IIF3tWZAjOSQIWUnF7vR7Uk1RpgF aKihl+5b1owtWMmuiX7vEerJEmi5wO8MftxzE4fFgUKZg8NhVwQesUIdp7lSDtxmZreQ Grrc6g+MLQULEp7PnSU23VE+CqzpPDzegwf8tPAKFWkNw04CXuXzOK9+29pVzVjOokN+ KfJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AR518AYffDucPqzd6GpEc0fpZu1ity7ryBoeYS6VKpM=; b=kxyJWrMGljAnIMhNsFd6lr5ZsgxBiDB/LKjwU2Ye1ZVt+oHqXUPHxE53yzkzCX+41P 4QRiUCSWFRPXg+ZpEobVwx3hzvDzPRph4yUz78RMKSzvGMnqhpVOEuDTpp5tsdb1IhT1 /pMnWwd8ShNQmncG4elsCQE24QWRxZjsxSW3seeYRz6LZCwMmKXyFipoZ4H4rOcNXIr3 NV3+oRKbOFaby/wOLxlHsKNQ90C/oq6SUxEw8DlLk4pbp9aP35gB0IiEhpRCBRpTyg5W rg/RKrPGLtKav0SBhIE4EAtuAxmkBYv47zkTwcmAB9fXxjMlqagjE51K+iLKPJllWxQD X/KA== X-Gm-Message-State: AOAM531p3mwAYMBovfhQUAVO4Jg76s1Q9iAF/DyWFwW9ph7LJh+xaH9j SupiEfElm3vEMm+xinnzz5lvawKZLzQoLH4vPVu4lg== X-Google-Smtp-Source: ABdhPJx357cBFSDeJIq+SFagT0F9i3UmguYWEoihimZ4PczMNFpyw7EKJ6U7OhMqBkG4xqQtWP0detZF5ur4Z8O/+4o= X-Received: by 2002:a17:906:5d06:: with SMTP id g6mr31659399ejt.342.1624988133039; Tue, 29 Jun 2021 10:35:33 -0700 (PDT) MIME-Version: 1.0 References: <20210524110222.2212-1-shameerali.kolothum.thodi@huawei.com> <20210524110222.2212-4-shameerali.kolothum.thodi@huawei.com> <9e788789-c1c2-10f1-d99c-93cfa6ea3348@arm.com> <3206cd67962242a69fb83adac892e34c@huawei.com> In-Reply-To: <3206cd67962242a69fb83adac892e34c@huawei.com> From: Jon Nettleton Date: Tue, 29 Jun 2021 19:34:56 +0200 Message-ID: Subject: Re: [PATCH v5 3/8] ACPI/IORT: Add a helper to retrieve RMR memory regions To: Shameerali Kolothum Thodi Cc: Linuxarm , "steven.price@arm.com" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" , wanghuiqiang , "Guohanjun \(Hanjun Guo\)" , yangyicong , "Sami.Mujawar@arm.com" , Robin Murphy , "linux-arm-kernel@lists.infradead.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Jun 14, 2021 at 2:49 PM Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Robin Murphy [mailto:robin.murphy@arm.com] > > Sent: 14 June 2021 12:23 > > To: Shameerali Kolothum Thodi ; > > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > iommu@lists.linux-foundation.org > > Cc: jon@solid-run.com; Linuxarm ; > > steven.price@arm.com; Guohanjun (Hanjun Guo) ; > > yangyicong ; Sami.Mujawar@arm.com; > > wanghuiqiang > > Subject: Re: [PATCH v5 3/8] ACPI/IORT: Add a helper to retrieve RMR memory > > regions > > > > On 2021-05-24 12:02, Shameer Kolothum wrote: > > > Add a helper function that retrieves RMR memory descriptors > > > associated with a given IOMMU. This will be used by IOMMU > > > drivers to setup necessary mappings. > > > > > > Now that we have this, invoke it from the generic helper > > > interface. > > > > > > Signed-off-by: Shameer Kolothum > > > > > --- > > > drivers/acpi/arm64/iort.c | 50 > > +++++++++++++++++++++++++++++++++++++++ > > > drivers/iommu/dma-iommu.c | 4 ++++ > > > include/linux/acpi_iort.h | 7 ++++++ > > > 3 files changed, 61 insertions(+) > > > > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > > index fea1ffaedf3b..01917caf58de 100644 > > > --- a/drivers/acpi/arm64/iort.c > > > +++ b/drivers/acpi/arm64/iort.c > > > @@ -12,6 +12,7 @@ > > > > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -837,6 +838,53 @@ static inline int iort_add_device_replay(struct > > device *dev) > > > return err; > > > } > > > > > > +/** > > > + * iort_iommu_get_rmrs - Helper to retrieve RMR info associated with > > IOMMU > > > + * @iommu: fwnode for the IOMMU > > > + * @head: RMR list head to be populated > > > + * > > > + * Returns: 0 on success, <0 failure > > > + */ > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *head) > > > +{ > > > + struct iort_rmr_entry *e; > > > + struct acpi_iort_node *iommu; > > > + int rmrs = 0; > > > + > > > + iommu = iort_get_iort_node(iommu_fwnode); > > > + if (!iommu || list_empty(&iort_rmr_list)) > > > + return -ENODEV; > > > + > > > + list_for_each_entry(e, &iort_rmr_list, list) { > > > + int prot = IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | > > IOMMU_MMIO; > > > + struct iommu_resv_region *region; > > > + enum iommu_resv_type type; > > > + struct acpi_iort_rmr_desc *rmr_desc; > > > + > > > + if (e->smmu != iommu) > > > + continue; > > > + > > > + rmr_desc = e->rmr_desc; > > > + if (e->flags & IOMMU_RMR_REMAP_PERMITTED) > > > + type = IOMMU_RESV_DIRECT_RELAXABLE; > > > + else > > > + type = IOMMU_RESV_DIRECT; > > I have been looking at this a bit more and looking at the history of RMR_REMAP_PERMITTED. Based on the history I have found it seems to me like this would be the better options for prot. @@ -840,7 +840,7 @@ int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, return -ENODEV; list_for_each_entry(e, &iort_rmr_list, list) { - int prot = IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_MMIO; + int prot = IOMMU_READ | IOMMU_WRITE; struct iommu_resv_region *region; enum iommu_resv_type type; struct acpi_iort_rmr_desc *rmr_desc; @@ -849,10 +849,13 @@ int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, continue; rmr_desc = e->rmr_desc; - if (e->flags & IOMMU_RMR_REMAP_PERMITTED) + if (e->flags & IOMMU_RMR_REMAP_PERMITTED) { type = IOMMU_RESV_DIRECT_RELAXABLE; - else + prot |= IOMMU_CACHE; + } else { type = IOMMU_RESV_DIRECT; + prot |= IOMMU_MMIO; + } region = iommu_alloc_resv_region(rmr_desc->base_address, rmr_desc->length, any input on this? My reasoning is that IOMMU_RESV_DIRECT is specifically referenced for things like MSI doorbell and in all the examples needs IOMMU_MMIO, while REMAP_PERMITTED seems to be used for allocated system memory that is then used for device specific reserved regions which commits say would be like a GPU or USB device. -Jon > > Wasn't the idea that we can do all this during the initial parsing, i.e. > > we don't even have iort_rmr_entry, we store them as iommu_resv_regions > > and simply kmemdup() or whatever at this point? > > > Hmm... Not yet. I removed struct iommu_rmr() from v4. But yes, it looks like > we can get rid of iort_rmr_entry as well. Will give it a go in next. > > Thanks, > Shameer > > > Robin. > > > > > + > > > + region = iommu_alloc_resv_region(rmr_desc->base_address, > > > + rmr_desc->length, > > > + prot, type); > > > + if (region) { > > > + region->fw_data.rmr.flags = e->flags; > > > + region->fw_data.rmr.sid = e->sid; > > > + list_add_tail(®ion->list, head); > > > + rmrs++; > > > + } > > > + } > > > + > > > + return (rmrs == 0) ? -ENODEV : 0; > > > +} > > > + > > > /** > > > * iort_iommu_msi_get_resv_regions - Reserved region driver helper > > > * @dev: Device from iommu_get_resv_regions() > > > @@ -1108,6 +1156,8 @@ int iort_iommu_msi_get_resv_regions(struct > > device *dev, struct list_head *head) > > > const struct iommu_ops *iort_iommu_configure_id(struct device *dev, > > > const u32 *input_id) > > > { return NULL; } > > > +int iort_iommu_get_rmrs(struct fwnode_handle *fwnode, struct list_head > > *head) > > > +{ return -ENODEV; } > > > #endif > > > > > > static int nc_dma_get_range(struct device *dev, u64 *size) > > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > > > index 229ec65d98be..f893d460cfa4 100644 > > > --- a/drivers/iommu/dma-iommu.c > > > +++ b/drivers/iommu/dma-iommu.c > > > @@ -185,6 +185,9 @@ EXPORT_SYMBOL(iommu_put_dma_cookie); > > > int iommu_dma_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > struct list_head *list) > > > { > > > + if (!is_of_node(iommu_fwnode)) > > > + return iort_iommu_get_rmrs(iommu_fwnode, list); > > > + > > > return -EINVAL; > > > } > > > EXPORT_SYMBOL(iommu_dma_get_rmrs); > > > @@ -200,6 +203,7 @@ EXPORT_SYMBOL(iommu_dma_get_rmrs); > > > void iommu_dma_put_rmrs(struct fwnode_handle *iommu_fwnode, > > > struct list_head *list) > > > { > > > + generic_iommu_put_resv_regions(iommu_fwnode->dev, list); > > > } > > > EXPORT_SYMBOL(iommu_dma_put_rmrs); > > > > > > diff --git a/include/linux/acpi_iort.h b/include/linux/acpi_iort.h > > > index 1a12baa58e40..e8c45fa59531 100644 > > > --- a/include/linux/acpi_iort.h > > > +++ b/include/linux/acpi_iort.h > > > @@ -39,6 +39,8 @@ const struct iommu_ops > > *iort_iommu_configure_id(struct device *dev, > > > const u32 *id_in); > > > int iort_iommu_msi_get_resv_regions(struct device *dev, struct list_head > > *head); > > > phys_addr_t acpi_iort_dma_get_max_cpu_address(void); > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *list); > > > #else > > > static inline void acpi_iort_init(void) { } > > > static inline u32 iort_msi_map_id(struct device *dev, u32 id) > > > @@ -59,6 +61,11 @@ int iort_iommu_msi_get_resv_regions(struct device > > *dev, struct list_head *head) > > > > > > static inline phys_addr_t acpi_iort_dma_get_max_cpu_address(void) > > > { return PHYS_ADDR_MAX; } > > > + > > > +static inline > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *list) > > > +{ return -ENODEV; } > > > #endif > > > > > > #endif /* __ACPI_IORT_H__ */ > > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE393C11F67 for ; Tue, 29 Jun 2021 17:37:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86D6C61DD1 for ; Tue, 29 Jun 2021 17:37:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86D6C61DD1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=solid-run.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vlm+jz4hK1VJ3cogA2pcwZbM5UOJ7a/8JpXvrcSNp6E=; b=sA5vne7gynC++H VM5WjqHPEbcuPW0DikPHtM6AqP0vB3dPxZLb3wSBbu6RkbjQFNIeIe0zHIUIuXDBXLknT0mONZZMu z/876Z8JN3E2YqhzsS2TdHHRMqVxWvVwbubwq52ddkpDJ7FqqkorS2AqBybSEphxR2PuosENNIQE4 pZlPo1tNIrFrm+89JRkT5RzVOhhKqGK3nfYG+4euOgdHdNdz18mzPwS4/U2QEblBv/Xh1kVCdPAsm wbWQOivYr7K+hdf4h0Ad9l1kn0NTaroojuo4sfeqihQH7Sr/7s7TvAAgVDHYFBTZ57LWTL9U+yH5/ CkpmEZjP2dfXYFskUMeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyHe6-00BjVL-O2; Tue, 29 Jun 2021 17:35:38 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyHe2-00BjUP-QU for linux-arm-kernel@lists.infradead.org; Tue, 29 Jun 2021 17:35:36 +0000 Received: by mail-ej1-x62c.google.com with SMTP id v20so19132462eji.10 for ; Tue, 29 Jun 2021 10:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AR518AYffDucPqzd6GpEc0fpZu1ity7ryBoeYS6VKpM=; b=s/B5H56H4gU82Gp6P64hMNmHHdlcpEN6YXZM9aJVcRaJAWvqnQ6jgSriUY14Ic/NcP dy5st7yhJ4DU0QHwDNFaXUCWEi0m50cR/OjM2krNjL94wOLgwxueH8cKfmlxXjkTYY7B 6ffKcHtucifvn4CLA/aYFqkxWyGHZLlq1qRDom+3IIF3tWZAjOSQIWUnF7vR7Uk1RpgF aKihl+5b1owtWMmuiX7vEerJEmi5wO8MftxzE4fFgUKZg8NhVwQesUIdp7lSDtxmZreQ Grrc6g+MLQULEp7PnSU23VE+CqzpPDzegwf8tPAKFWkNw04CXuXzOK9+29pVzVjOokN+ KfJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AR518AYffDucPqzd6GpEc0fpZu1ity7ryBoeYS6VKpM=; b=ANEisWnjcilavNjhD3vfFsLZ7vRM/mtAPMv8P3EMPRk3vjXibUnFRgSNl2hObP2yPM 9D93/pq4AWvEiBlQ74RLLb/IcCqohdEErVNhaY0ELW/TQRIjvUE9TkpUoAFYWTrbkGHp /CaVvFW5vKgh/AYEVAj7HlwQh3GZDok12oPHA+2c3NhH82C+mgMRU3GRWK8ubFs3aQ4Z 0TaeHXPsn7/s8x7xCStlWOWrjB22Wwu/bP4Xc7Q6UiQUJ3PHqiN/UaNefPFG79wg/yXH 5ZFghRhOcVb/pZqwb4nXR2mgqsMd1Fen8BAqa8OZxSKGwBTSci+Q9nIlnMnb6jjfOilD dhgg== X-Gm-Message-State: AOAM530zP0cbOGl0ajUtZfGHxOAG3Lv7/kLc1Ht2SUyO4bOoVsTJ/vG5 Hqsc4R6HEPUibQWSH7BSlj+SdQfh8TNgUU5RZhwOIw== X-Google-Smtp-Source: ABdhPJx357cBFSDeJIq+SFagT0F9i3UmguYWEoihimZ4PczMNFpyw7EKJ6U7OhMqBkG4xqQtWP0detZF5ur4Z8O/+4o= X-Received: by 2002:a17:906:5d06:: with SMTP id g6mr31659399ejt.342.1624988133039; Tue, 29 Jun 2021 10:35:33 -0700 (PDT) MIME-Version: 1.0 References: <20210524110222.2212-1-shameerali.kolothum.thodi@huawei.com> <20210524110222.2212-4-shameerali.kolothum.thodi@huawei.com> <9e788789-c1c2-10f1-d99c-93cfa6ea3348@arm.com> <3206cd67962242a69fb83adac892e34c@huawei.com> In-Reply-To: <3206cd67962242a69fb83adac892e34c@huawei.com> From: Jon Nettleton Date: Tue, 29 Jun 2021 19:34:56 +0200 Message-ID: Subject: Re: [PATCH v5 3/8] ACPI/IORT: Add a helper to retrieve RMR memory regions To: Shameerali Kolothum Thodi Cc: Robin Murphy , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Linuxarm , "steven.price@arm.com" , "Guohanjun (Hanjun Guo)" , yangyicong , "Sami.Mujawar@arm.com" , wanghuiqiang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210629_103534_987719_7F9BD45A X-CRM114-Status: GOOD ( 38.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 14, 2021 at 2:49 PM Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Robin Murphy [mailto:robin.murphy@arm.com] > > Sent: 14 June 2021 12:23 > > To: Shameerali Kolothum Thodi ; > > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > iommu@lists.linux-foundation.org > > Cc: jon@solid-run.com; Linuxarm ; > > steven.price@arm.com; Guohanjun (Hanjun Guo) ; > > yangyicong ; Sami.Mujawar@arm.com; > > wanghuiqiang > > Subject: Re: [PATCH v5 3/8] ACPI/IORT: Add a helper to retrieve RMR memory > > regions > > > > On 2021-05-24 12:02, Shameer Kolothum wrote: > > > Add a helper function that retrieves RMR memory descriptors > > > associated with a given IOMMU. This will be used by IOMMU > > > drivers to setup necessary mappings. > > > > > > Now that we have this, invoke it from the generic helper > > > interface. > > > > > > Signed-off-by: Shameer Kolothum > > > > > --- > > > drivers/acpi/arm64/iort.c | 50 > > +++++++++++++++++++++++++++++++++++++++ > > > drivers/iommu/dma-iommu.c | 4 ++++ > > > include/linux/acpi_iort.h | 7 ++++++ > > > 3 files changed, 61 insertions(+) > > > > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > > index fea1ffaedf3b..01917caf58de 100644 > > > --- a/drivers/acpi/arm64/iort.c > > > +++ b/drivers/acpi/arm64/iort.c > > > @@ -12,6 +12,7 @@ > > > > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -837,6 +838,53 @@ static inline int iort_add_device_replay(struct > > device *dev) > > > return err; > > > } > > > > > > +/** > > > + * iort_iommu_get_rmrs - Helper to retrieve RMR info associated with > > IOMMU > > > + * @iommu: fwnode for the IOMMU > > > + * @head: RMR list head to be populated > > > + * > > > + * Returns: 0 on success, <0 failure > > > + */ > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *head) > > > +{ > > > + struct iort_rmr_entry *e; > > > + struct acpi_iort_node *iommu; > > > + int rmrs = 0; > > > + > > > + iommu = iort_get_iort_node(iommu_fwnode); > > > + if (!iommu || list_empty(&iort_rmr_list)) > > > + return -ENODEV; > > > + > > > + list_for_each_entry(e, &iort_rmr_list, list) { > > > + int prot = IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | > > IOMMU_MMIO; > > > + struct iommu_resv_region *region; > > > + enum iommu_resv_type type; > > > + struct acpi_iort_rmr_desc *rmr_desc; > > > + > > > + if (e->smmu != iommu) > > > + continue; > > > + > > > + rmr_desc = e->rmr_desc; > > > + if (e->flags & IOMMU_RMR_REMAP_PERMITTED) > > > + type = IOMMU_RESV_DIRECT_RELAXABLE; > > > + else > > > + type = IOMMU_RESV_DIRECT; > > I have been looking at this a bit more and looking at the history of RMR_REMAP_PERMITTED. Based on the history I have found it seems to me like this would be the better options for prot. @@ -840,7 +840,7 @@ int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, return -ENODEV; list_for_each_entry(e, &iort_rmr_list, list) { - int prot = IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_MMIO; + int prot = IOMMU_READ | IOMMU_WRITE; struct iommu_resv_region *region; enum iommu_resv_type type; struct acpi_iort_rmr_desc *rmr_desc; @@ -849,10 +849,13 @@ int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, continue; rmr_desc = e->rmr_desc; - if (e->flags & IOMMU_RMR_REMAP_PERMITTED) + if (e->flags & IOMMU_RMR_REMAP_PERMITTED) { type = IOMMU_RESV_DIRECT_RELAXABLE; - else + prot |= IOMMU_CACHE; + } else { type = IOMMU_RESV_DIRECT; + prot |= IOMMU_MMIO; + } region = iommu_alloc_resv_region(rmr_desc->base_address, rmr_desc->length, any input on this? My reasoning is that IOMMU_RESV_DIRECT is specifically referenced for things like MSI doorbell and in all the examples needs IOMMU_MMIO, while REMAP_PERMITTED seems to be used for allocated system memory that is then used for device specific reserved regions which commits say would be like a GPU or USB device. -Jon > > Wasn't the idea that we can do all this during the initial parsing, i.e. > > we don't even have iort_rmr_entry, we store them as iommu_resv_regions > > and simply kmemdup() or whatever at this point? > > > Hmm... Not yet. I removed struct iommu_rmr() from v4. But yes, it looks like > we can get rid of iort_rmr_entry as well. Will give it a go in next. > > Thanks, > Shameer > > > Robin. > > > > > + > > > + region = iommu_alloc_resv_region(rmr_desc->base_address, > > > + rmr_desc->length, > > > + prot, type); > > > + if (region) { > > > + region->fw_data.rmr.flags = e->flags; > > > + region->fw_data.rmr.sid = e->sid; > > > + list_add_tail(®ion->list, head); > > > + rmrs++; > > > + } > > > + } > > > + > > > + return (rmrs == 0) ? -ENODEV : 0; > > > +} > > > + > > > /** > > > * iort_iommu_msi_get_resv_regions - Reserved region driver helper > > > * @dev: Device from iommu_get_resv_regions() > > > @@ -1108,6 +1156,8 @@ int iort_iommu_msi_get_resv_regions(struct > > device *dev, struct list_head *head) > > > const struct iommu_ops *iort_iommu_configure_id(struct device *dev, > > > const u32 *input_id) > > > { return NULL; } > > > +int iort_iommu_get_rmrs(struct fwnode_handle *fwnode, struct list_head > > *head) > > > +{ return -ENODEV; } > > > #endif > > > > > > static int nc_dma_get_range(struct device *dev, u64 *size) > > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > > > index 229ec65d98be..f893d460cfa4 100644 > > > --- a/drivers/iommu/dma-iommu.c > > > +++ b/drivers/iommu/dma-iommu.c > > > @@ -185,6 +185,9 @@ EXPORT_SYMBOL(iommu_put_dma_cookie); > > > int iommu_dma_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > struct list_head *list) > > > { > > > + if (!is_of_node(iommu_fwnode)) > > > + return iort_iommu_get_rmrs(iommu_fwnode, list); > > > + > > > return -EINVAL; > > > } > > > EXPORT_SYMBOL(iommu_dma_get_rmrs); > > > @@ -200,6 +203,7 @@ EXPORT_SYMBOL(iommu_dma_get_rmrs); > > > void iommu_dma_put_rmrs(struct fwnode_handle *iommu_fwnode, > > > struct list_head *list) > > > { > > > + generic_iommu_put_resv_regions(iommu_fwnode->dev, list); > > > } > > > EXPORT_SYMBOL(iommu_dma_put_rmrs); > > > > > > diff --git a/include/linux/acpi_iort.h b/include/linux/acpi_iort.h > > > index 1a12baa58e40..e8c45fa59531 100644 > > > --- a/include/linux/acpi_iort.h > > > +++ b/include/linux/acpi_iort.h > > > @@ -39,6 +39,8 @@ const struct iommu_ops > > *iort_iommu_configure_id(struct device *dev, > > > const u32 *id_in); > > > int iort_iommu_msi_get_resv_regions(struct device *dev, struct list_head > > *head); > > > phys_addr_t acpi_iort_dma_get_max_cpu_address(void); > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *list); > > > #else > > > static inline void acpi_iort_init(void) { } > > > static inline u32 iort_msi_map_id(struct device *dev, u32 id) > > > @@ -59,6 +61,11 @@ int iort_iommu_msi_get_resv_regions(struct device > > *dev, struct list_head *head) > > > > > > static inline phys_addr_t acpi_iort_dma_get_max_cpu_address(void) > > > { return PHYS_ADDR_MAX; } > > > + > > > +static inline > > > +int iort_iommu_get_rmrs(struct fwnode_handle *iommu_fwnode, > > > + struct list_head *list) > > > +{ return -ENODEV; } > > > #endif > > > > > > #endif /* __ACPI_IORT_H__ */ > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel