From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepa Dinamani Subject: Re: [PATCH] utimes: Clamp the timestamps in notify_change() Date: Mon, 25 Nov 2019 10:16:57 -0800 Message-ID: References: <20191124193145.22945-1-amir73il@gmail.com> <20191125164625.GB28608@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191125164625.GB28608@fieldses.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: "J . Bruce Fields" Cc: Linux NFS Mailing List , Arnd Bergmann , Miklos Szeredi , y2038 Mailman List , Amir Goldstein , Jeff Layton , overlayfs , Al Viro , Linux FS-devel Mailing List List-Id: linux-unionfs@vger.kernel.org T24gTW9uLCBOb3YgMjUsIDIwMTkgYXQgODo0NiBBTSBKIC4gQnJ1Y2UgRmllbGRzIDxiZmllbGRz QGZpZWxkc2VzLm9yZz4gd3JvdGU6Cj4KPiBPbiBTdW4sIE5vdiAyNCwgMjAxOSBhdCAwOTozMTo0 NVBNICswMjAwLCBBbWlyIEdvbGRzdGVpbiB3cm90ZToKPiA+IFB1c2ggY2xhbXBpbmcgdGltZXN0 YW1wcyBkb3duIHRoZSBjYWxsIHN0YWNrIGludG8gbm90aWZ5X2NoYW5nZSgpLCBzbwo+ID4gaW4t a2VybmVsIGNhbGxlcnMgbGlrZSBuZnNkIGFuZCBvdmVybGF5ZnMgd2lsbCBnZXQgc2ltaWxhciB0 aW1lc3RhbXAKPiA+IHNldCBiZWhhdmlvciBhcyB1dGltZXMuCj4KPiBTbywgbmZzZCBoYXMgYWx3 YXlzIGJ5cGFzc2VkIHRpbWVzdGFtcF90cnVuY2F0ZSgpIGFuZCB3ZSd2ZSBuZXZlcgo+IG5vdGlj ZWQgdGlsbCBub3c/ICBXaGF0IGFyZSB0aGUgc3ltcHRvbXM/ICAoRG8gdGltZXN0YW1wcyBnbyBi YWNrd2FyZHMKPiBhZnRlciBjYWNoZSBldmljdGlvbiBvbiBmaWxlc3lzdGVtcyB3aXRoIGxhcmdl IHRpbWUgZ3JhbnVsYXJpdHk/KQo+Cj4gTG9va3MgbGlrZSBnZW5lcmljLzQwMiBoYXMgbmV2ZXIg cnVuIGluIG15IHRlc3RzOgo+Cj4gICAgICAgICBnZW5lcmljLzQwMiAgICAgW25vdCBydW5dIG5v IGtlcm5lbCBzdXBwb3J0IGZvciB5MjAzOCBzeXNmcyBzd2l0Y2gKCllvdSBuZWVkIHRoaXMgaW4g eW91ciB4ZnN0ZXN0OgpodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzExMDQ5NzQ1 LyAuIFRoZSB0ZXN0IGhhcyBiZWVuCnVwZGF0ZWQgcmVjZW50bHkuCgpBbmQsIHlvdSBuZWVkIGEg Y2hhbmdlIGxpa2UgZm9yIG92ZXJsYXlmcyBhcyBBbWlyIHBvaW50ZWQgb3V0LgoKLURlZXBhCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClkyMDM4IG1haWxp bmcgbGlzdApZMjAzOEBsaXN0cy5saW5hcm8ub3JnCmh0dHBzOi8vbGlzdHMubGluYXJvLm9yZy9t YWlsbWFuL2xpc3RpbmZvL3kyMDM4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307EAC432C3 for ; Mon, 25 Nov 2019 18:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E11820748 for ; Mon, 25 Nov 2019 18:17:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cfpPCKzt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727985AbfKYSRM (ORCPT ); Mon, 25 Nov 2019 13:17:12 -0500 Received: from mail-il1-f195.google.com ([209.85.166.195]:36506 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727865AbfKYSRL (ORCPT ); Mon, 25 Nov 2019 13:17:11 -0500 Received: by mail-il1-f195.google.com with SMTP id s75so15105333ilc.3; Mon, 25 Nov 2019 10:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XNvmuvfR13K+bepkBmPkJQDh2DcCBvXY1vhlGmjrkSQ=; b=cfpPCKztKRoWFw9gU0+NsNuYAetbF3Z/a4D/7R0eDl7/zhS7+oVdMGW62X2CKXoRwH jfeDbMcGYFyGsRJ6DY2ACog0bpH++4TlJeHXHBbAN4UTbjWyCzBQOXQbTfmBkqtOFffb L2cifP060mBBHiocqRCzV7sTnJb+CGEp+hkt1h3OVURv+kRe5ddgiaA9SmZHEE81PHly QFY3FDXZswnaPgB3kqmMJLdTbghNw5MNntz8P7mTwEDUej5pr5fNq7+7+T/gEczCO+XN hXUjtj70mm5RIC5G7pb1J875Gpr+43Ed3rWK7wCi71W4StwsMwzr1exl4jD5rBlvyT65 qTwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XNvmuvfR13K+bepkBmPkJQDh2DcCBvXY1vhlGmjrkSQ=; b=RTZFKUoPhSyaEotRxD0LhOf5eqAJnPS0pGPg2sd80SmZUCxYrx9D/tTVEMkIWUx4Lj 9gOaupdnWNvMNB4PEvOJn/fnHX8fcmYdV114hQHaUsIyHtWvXLqncDnGx+JD3lVQKoyP sOcPEa3S8VONXifC36D6Eo/ymlYDP+KOV3F/Sp1ljcDtnoLx3JNSFLE+looVxZy+qgaV TcjIcKmlLUSPVIMw+aFthbp1xvgn1LU6dp1O1FOkal13Ky0pBXpMzlH7ojelIlo37/XL jnHppFXsJbmX77hRF7w2VHOiBdv6GmVUuynHQEU/cvs2TnQqZC2Y3Cnt/gQiP+2bCUMl uo1A== X-Gm-Message-State: APjAAAWWV5wOgEhpjW4mLVo4s+hHQKgvD9Q0vhUGT+wxH3PPTyA8tltZ 9oTuW1zEiAB6XFd57kej1uuNmkwrWTinAKRZdyM= X-Google-Smtp-Source: APXvYqw78v3arYJMRZHIVLUyH0UknW8rGs2UZ5LBxnpquKgU2PPRG0oB/krijAz/74tFXtSGiOCOUuYep3Lc7hWfR5U= X-Received: by 2002:a92:d390:: with SMTP id o16mr34224478ilo.110.1574705830800; Mon, 25 Nov 2019 10:17:10 -0800 (PST) MIME-Version: 1.0 References: <20191124193145.22945-1-amir73il@gmail.com> <20191125164625.GB28608@fieldses.org> In-Reply-To: <20191125164625.GB28608@fieldses.org> From: Deepa Dinamani Date: Mon, 25 Nov 2019 10:16:57 -0800 Message-ID: Subject: Re: [PATCH] utimes: Clamp the timestamps in notify_change() To: "J . Bruce Fields" Cc: Amir Goldstein , Arnd Bergmann , Jeff Layton , Miklos Szeredi , Al Viro , Linux FS-devel Mailing List , overlayfs , Linux NFS Mailing List , y2038 Mailman List Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Nov 25, 2019 at 8:46 AM J . Bruce Fields wrote: > > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > > Push clamping timestamps down the call stack into notify_change(), so > > in-kernel callers like nfsd and overlayfs will get similar timestamp > > set behavior as utimes. > > So, nfsd has always bypassed timestamp_truncate() and we've never > noticed till now? What are the symptoms? (Do timestamps go backwards > after cache eviction on filesystems with large time granularity?) > > Looks like generic/402 has never run in my tests: > > generic/402 [not run] no kernel support for y2038 sysfs switch You need this in your xfstest: https://patchwork.kernel.org/patch/11049745/ . The test has been updated recently. And, you need a change like for overlayfs as Amir pointed out. -Deepa