From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034000AbcJ0WZP (ORCPT ); Thu, 27 Oct 2016 18:25:15 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34736 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941575AbcJ0WZO (ORCPT ); Thu, 27 Oct 2016 18:25:14 -0400 MIME-Version: 1.0 In-Reply-To: <20161027025616.GC14832@jelly> References: <1476761253-13450-1-git-send-email-deepa.kernel@gmail.com> <1476761253-13450-4-git-send-email-deepa.kernel@gmail.com> <20161027025616.GC14832@jelly> From: Deepa Dinamani Date: Thu, 27 Oct 2016 15:24:55 -0700 Message-ID: Subject: Re: [PATCH v2 3/4] input: Deprecate real timestamps beyond year 2106 To: Peter Hutterer Cc: Dmitry Torokhov , linux-input@vger.kernel.org, Linux Kernel Mailing List , Arnd Bergmann , y2038 Mailman List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2016 at 7:56 PM, Peter Hutterer wrote: > On Mon, Oct 17, 2016 at 08:27:32PM -0700, Deepa Dinamani wrote: >> struct timeval is not y2038 safe. >> All usage of timeval in the kernel will be replaced by >> y2038 safe structures. >> >> struct input_event maintains time for each input event. >> Real time timestamps are not ideal for input as this >> time can go backwards as noted in the patch a80b83b7b8 >> by John Stultz. Hence, having the input_event.time fields >> only big enough for monotonic and boot times are >> sufficient. >> >> Leave the original input_event as is. This is to maintain >> backward compatibility with existing userspace interfaces >> that use input_event. >> Introduce a new replacement struct raw_input_event. > > general comment here - please don't name it "raw_input_event". > First, when you grep for input_event you want the new ones to show up too, > so a struct input_event_raw would be better here. That also has better > namespacing in general. Second though: the event isn't any more "raw" than > the previous we had. > > I can't think of anything better than struct input_event_v2 though. The general idea was to leave the original struct input_event as a common interface for userspace (as it cannot be deleted). So reading raw data unformatted by the userspace will have the new struct raw_input_event format. This was the reason for the "raw" in the name. struct input_event_v2 is fine too, if this is more preferred. >> This replaces timeval with struct input_timeval. This structure >> maintains time in __kernel_ulong_t or compat_ulong_t to allow >> for architectures to override types as in the case of x32. >> >> The change requires any userspace utilities reading or writing >> from event nodes to update their reading format to match >> raw_input_event. The changes to the popular libraries will be >> posted along with the kernel changes. >> The driver version is also updated to reflect the change in >> event format. > > Doesn't this break *all* of userspace then? I don't see anything to > negotiate the type of input event the kernel gives me. And nothing right now > checks for EVDEV_VERSION, so they all just assume it's a struct > input_event. Best case, if the available events aren't a multiple of > sizeof(struct input_event) userspace will bomb out, but unless that happens, > everyone will just happily read old-style events. > > So we need some negotiation what is acceptable. Which also needs to address > the race conditions we're going to get when events start coming in before > the client has announced that it supports the new-style events. No, this does not break any userspace right now. Both struct input_event and struct raw_input_event are exactly the same today. This will be the case until a 2038-safe glibc is used with a 64 bit time_t flag. So these are the scenarios: 1. old kernel driver + new userspace -- should still be ok until 2038. Version checks could help discover these 2. new kernel driver + old userspace (without recompiled with new 2038 gblic) -- works because the format is really the same. The patch I posted to libevdev checks this driver version. And, hence any library that results in a call to libevdev_set_fd() will fail if it is not this updated driver. We could just do a similar check in every library also. I think the latter would be better. So, the kernel patches can go in as a no-op right now and then I can add version checks to respective user space libraries. -Deepa From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepa Dinamani Subject: Re: [PATCH v2 3/4] input: Deprecate real timestamps beyond year 2106 Date: Thu, 27 Oct 2016 15:24:55 -0700 Message-ID: References: <1476761253-13450-1-git-send-email-deepa.kernel@gmail.com> <1476761253-13450-4-git-send-email-deepa.kernel@gmail.com> <20161027025616.GC14832@jelly> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161027025616.GC14832@jelly> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Peter Hutterer Cc: y2038 Mailman List , Dmitry Torokhov , Linux Kernel Mailing List , Arnd Bergmann , linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org T24gV2VkLCBPY3QgMjYsIDIwMTYgYXQgNzo1NiBQTSwgUGV0ZXIgSHV0dGVyZXIKPHBldGVyLmh1 dHRlcmVyQHdoby10Lm5ldD4gd3JvdGU6Cj4gT24gTW9uLCBPY3QgMTcsIDIwMTYgYXQgMDg6Mjc6 MzJQTSAtMDcwMCwgRGVlcGEgRGluYW1hbmkgd3JvdGU6Cj4+IHN0cnVjdCB0aW1ldmFsIGlzIG5v dCB5MjAzOCBzYWZlLgo+PiBBbGwgdXNhZ2Ugb2YgdGltZXZhbCBpbiB0aGUga2VybmVsIHdpbGwg YmUgcmVwbGFjZWQgYnkKPj4geTIwMzggc2FmZSBzdHJ1Y3R1cmVzLgo+Pgo+PiBzdHJ1Y3QgaW5w dXRfZXZlbnQgbWFpbnRhaW5zIHRpbWUgZm9yIGVhY2ggaW5wdXQgZXZlbnQuCj4+IFJlYWwgdGlt ZSB0aW1lc3RhbXBzIGFyZSBub3QgaWRlYWwgZm9yIGlucHV0IGFzIHRoaXMKPj4gdGltZSBjYW4g Z28gYmFja3dhcmRzIGFzIG5vdGVkIGluIHRoZSBwYXRjaCBhODBiODNiN2I4Cj4+IGJ5IEpvaG4g U3R1bHR6LiBIZW5jZSwgaGF2aW5nIHRoZSBpbnB1dF9ldmVudC50aW1lIGZpZWxkcwo+PiBvbmx5 IGJpZyBlbm91Z2ggZm9yIG1vbm90b25pYyBhbmQgYm9vdCB0aW1lcyBhcmUKPj4gc3VmZmljaWVu dC4KPj4KPj4gTGVhdmUgdGhlIG9yaWdpbmFsIGlucHV0X2V2ZW50IGFzIGlzLiBUaGlzIGlzIHRv IG1haW50YWluCj4+IGJhY2t3YXJkIGNvbXBhdGliaWxpdHkgd2l0aCBleGlzdGluZyB1c2Vyc3Bh Y2UgaW50ZXJmYWNlcwo+PiB0aGF0IHVzZSBpbnB1dF9ldmVudC4KPj4gSW50cm9kdWNlIGEgbmV3 IHJlcGxhY2VtZW50IHN0cnVjdCByYXdfaW5wdXRfZXZlbnQuCj4KPiBnZW5lcmFsIGNvbW1lbnQg aGVyZSAtIHBsZWFzZSBkb24ndCBuYW1lIGl0ICJyYXdfaW5wdXRfZXZlbnQiLgo+IEZpcnN0LCB3 aGVuIHlvdSBncmVwIGZvciBpbnB1dF9ldmVudCB5b3Ugd2FudCB0aGUgbmV3IG9uZXMgdG8gc2hv dyB1cCB0b28sCj4gc28gYSBzdHJ1Y3QgaW5wdXRfZXZlbnRfcmF3IHdvdWxkIGJlIGJldHRlciBo ZXJlLiBUaGF0IGFsc28gaGFzIGJldHRlcgo+IG5hbWVzcGFjaW5nIGluIGdlbmVyYWwuIFNlY29u ZCB0aG91Z2g6IHRoZSBldmVudCBpc24ndCBhbnkgbW9yZSAicmF3IiB0aGFuCj4gdGhlIHByZXZp b3VzIHdlIGhhZC4KPgo+IEkgY2FuJ3QgdGhpbmsgb2YgYW55dGhpbmcgYmV0dGVyIHRoYW4gc3Ry dWN0IGlucHV0X2V2ZW50X3YyIHRob3VnaC4KClRoZSBnZW5lcmFsIGlkZWEgd2FzIHRvIGxlYXZl IHRoZSBvcmlnaW5hbCBzdHJ1Y3QgaW5wdXRfZXZlbnQgYXMgYQpjb21tb24gaW50ZXJmYWNlIGZv ciB1c2Vyc3BhY2UgKGFzIGl0IGNhbm5vdCBiZSBkZWxldGVkKS4KU28gcmVhZGluZyByYXcgZGF0 YSB1bmZvcm1hdHRlZCBieSB0aGUgdXNlcnNwYWNlIHdpbGwgaGF2ZSB0aGUgbmV3CnN0cnVjdCBy YXdfaW5wdXRfZXZlbnQgZm9ybWF0LgpUaGlzIHdhcyB0aGUgcmVhc29uIGZvciB0aGUgInJhdyIg aW4gdGhlIG5hbWUuCgpzdHJ1Y3QgaW5wdXRfZXZlbnRfdjIgaXMgZmluZSB0b28sIGlmIHRoaXMg aXMgbW9yZSBwcmVmZXJyZWQuCgo+PiBUaGlzIHJlcGxhY2VzIHRpbWV2YWwgd2l0aCBzdHJ1Y3Qg aW5wdXRfdGltZXZhbC4gVGhpcyBzdHJ1Y3R1cmUKPj4gbWFpbnRhaW5zIHRpbWUgaW4gX19rZXJu ZWxfdWxvbmdfdCBvciBjb21wYXRfdWxvbmdfdCB0byBhbGxvdwo+PiBmb3IgYXJjaGl0ZWN0dXJl cyB0byBvdmVycmlkZSB0eXBlcyBhcyBpbiB0aGUgY2FzZSBvZiB4MzIuCj4+Cj4+IFRoZSBjaGFu Z2UgcmVxdWlyZXMgYW55IHVzZXJzcGFjZSB1dGlsaXRpZXMgcmVhZGluZyBvciB3cml0aW5nCj4+ IGZyb20gZXZlbnQgbm9kZXMgdG8gdXBkYXRlIHRoZWlyIHJlYWRpbmcgZm9ybWF0IHRvIG1hdGNo Cj4+IHJhd19pbnB1dF9ldmVudC4gVGhlIGNoYW5nZXMgdG8gdGhlIHBvcHVsYXIgbGlicmFyaWVz IHdpbGwgYmUKPj4gcG9zdGVkIGFsb25nIHdpdGggdGhlIGtlcm5lbCBjaGFuZ2VzLgo+PiBUaGUg ZHJpdmVyIHZlcnNpb24gaXMgYWxzbyB1cGRhdGVkIHRvIHJlZmxlY3QgdGhlIGNoYW5nZSBpbgo+ PiBldmVudCBmb3JtYXQuCj4KPiBEb2Vzbid0IHRoaXMgYnJlYWsgKmFsbCogb2YgdXNlcnNwYWNl IHRoZW4/IEkgZG9uJ3Qgc2VlIGFueXRoaW5nIHRvCj4gbmVnb3RpYXRlIHRoZSB0eXBlIG9mIGlu cHV0IGV2ZW50IHRoZSBrZXJuZWwgZ2l2ZXMgbWUuIEFuZCBub3RoaW5nIHJpZ2h0IG5vdwo+IGNo ZWNrcyBmb3IgRVZERVZfVkVSU0lPTiwgc28gdGhleSBhbGwganVzdCBhc3N1bWUgaXQncyBhIHN0 cnVjdAo+IGlucHV0X2V2ZW50LiBCZXN0IGNhc2UsIGlmIHRoZSBhdmFpbGFibGUgZXZlbnRzIGFy ZW4ndCBhIG11bHRpcGxlIG9mCj4gc2l6ZW9mKHN0cnVjdCBpbnB1dF9ldmVudCkgdXNlcnNwYWNl IHdpbGwgYm9tYiBvdXQsIGJ1dCB1bmxlc3MgdGhhdCBoYXBwZW5zLAo+IGV2ZXJ5b25lIHdpbGwg anVzdCBoYXBwaWx5IHJlYWQgb2xkLXN0eWxlIGV2ZW50cy4KPgo+IFNvIHdlIG5lZWQgc29tZSBu ZWdvdGlhdGlvbiB3aGF0IGlzIGFjY2VwdGFibGUuIFdoaWNoIGFsc28gbmVlZHMgdG8gYWRkcmVz cwo+IHRoZSByYWNlIGNvbmRpdGlvbnMgd2UncmUgZ29pbmcgdG8gZ2V0IHdoZW4gZXZlbnRzIHN0 YXJ0IGNvbWluZyBpbiBiZWZvcmUKPiB0aGUgY2xpZW50IGhhcyBhbm5vdW5jZWQgdGhhdCBpdCBz dXBwb3J0cyB0aGUgbmV3LXN0eWxlIGV2ZW50cy4KCk5vLCB0aGlzIGRvZXMgbm90IGJyZWFrIGFu eSB1c2Vyc3BhY2UgcmlnaHQgbm93LgpCb3RoIHN0cnVjdCBpbnB1dF9ldmVudCBhbmQgc3RydWN0 IHJhd19pbnB1dF9ldmVudCBhcmUgZXhhY3RseSB0aGUgc2FtZSB0b2RheS4KVGhpcyB3aWxsIGJl IHRoZSBjYXNlIHVudGlsIGEgMjAzOC1zYWZlIGdsaWJjIGlzIHVzZWQgd2l0aCBhIDY0IGJpdCB0 aW1lX3QgZmxhZy4KClNvIHRoZXNlIGFyZSB0aGUgc2NlbmFyaW9zOgoxLiBvbGQga2VybmVsIGRy aXZlciArIG5ldyB1c2Vyc3BhY2UKICAtLSBzaG91bGQgc3RpbGwgYmUgb2sgdW50aWwgMjAzOC4g VmVyc2lvbiBjaGVja3MgY291bGQgaGVscCBkaXNjb3ZlciB0aGVzZQoyLiBuZXcga2VybmVsIGRy aXZlciArIG9sZCB1c2Vyc3BhY2UgKHdpdGhvdXQgcmVjb21waWxlZCB3aXRoIG5ldyAyMDM4IGdi bGljKQogIC0tIHdvcmtzIGJlY2F1c2UgdGhlIGZvcm1hdCBpcyByZWFsbHkgdGhlIHNhbWUuCgpU aGUgcGF0Y2ggSSBwb3N0ZWQgdG8gbGliZXZkZXYgY2hlY2tzIHRoaXMgZHJpdmVyIHZlcnNpb24u CkFuZCwgaGVuY2UgYW55IGxpYnJhcnkgdGhhdCByZXN1bHRzIGluIGEgY2FsbCB0byBsaWJldmRl dl9zZXRfZmQoKQp3aWxsIGZhaWwgaWYgaXQgaXMgbm90IHRoaXMgdXBkYXRlZCBkcml2ZXIuCldl IGNvdWxkIGp1c3QgZG8gYSBzaW1pbGFyIGNoZWNrIGluIGV2ZXJ5IGxpYnJhcnkgYWxzby4KSSB0 aGluayB0aGUgbGF0dGVyIHdvdWxkIGJlIGJldHRlci4KClNvLCB0aGUga2VybmVsIHBhdGNoZXMg Y2FuIGdvIGluIGFzIGEgbm8tb3AgcmlnaHQgbm93IGFuZCB0aGVuIEkgY2FuCmFkZCB2ZXJzaW9u IGNoZWNrcyB0byByZXNwZWN0aXZlIHVzZXIgc3BhY2UgbGlicmFyaWVzLgoKLURlZXBhCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClkyMDM4IG1haWxpbmcg bGlzdApZMjAzOEBsaXN0cy5saW5hcm8ub3JnCmh0dHBzOi8vbGlzdHMubGluYXJvLm9yZy9tYWls bWFuL2xpc3RpbmZvL3kyMDM4Cg==