From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Jo=C3=A3o_Marcos_Costa?= Date: Sun, 16 May 2021 21:44:53 -0300 Subject: [PATCH v2 27/28] fs/squashfs: sqfs_read: fragmented files are not supported In-Reply-To: <2f1e0760-1eb1-3d1b-a4c9-1104e21c50ab@posteo.net> References: <20201103111126.23600-1-richard.genoud@posteo.net> <20201103111126.23600-28-richard.genoud@posteo.net> <20201120013538.GE32272@bill-the-cat> <03f095f4-e803-e5e1-1406-c6ba50f42108@posteo.net> <2f1e0760-1eb1-3d1b-a4c9-1104e21c50ab@posteo.net> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, Em ter., 11 de mai. de 2021 ?s 10:04, Richard Genoud < richard.genoud@posteo.net> escreveu: > Hi all, > > Le 08/05/2021 ? 23:51, Simon Glass a ?crit : > > Hi, > > > > On Thu, 4 Feb 2021 at 15:32, Jo?o Marcos Costa > wrote: > >> > >> Em qua., 27 de jan. de 2021 ?s 12:15, Simon Glass > escreveu: > >>> > >>> Hi Joao, > >> > >> Hello! > >>> > >>> This test works the first time I run it but fails the second time, > >>> since the directory already exists. This makes it necessary to disable > >>> the test for development. > >>> > >>> It also uses the wrong quoting style - we have settled on a single > >>> quote by default in U-Boot. > >>> > >>> Finally, the tests and some functions need comments about what they do > >>> and what the arguments are. > >>> > >>> Please can you take a look? > >> > >> Absolutely. Excuse me for such a late reply. > > > > Any word on this please? Have you been able to repeat this? > Yes, for me, reading fragmented files doesn't work. > The test "test_sqfs_load" is OK because it only tests the file length not > its content. > > I've written a patch to check if the file is corrupted or not, and it > fails : > ./test/py/test.py --bd sandbox --build -k test_sqfs_load -v > [...] > I finally could get back to SquashFS support today, and I fixed a few bugs concerning the fragmented files. However, I still need to run a few more tests before submitting the patches. Best regards, Joao Marcos www.linkedin.com/in/jmarcoscosta/ https://github.com/jmarcoscosta