From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FDAC4708E for ; Sat, 29 May 2021 18:14:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FCDD61153 for ; Sat, 29 May 2021 18:14:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FCDD61153 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BC4081ECA; Sat, 29 May 2021 20:14:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jrZhkXdQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BCF0482AB2; Sat, 29 May 2021 20:14:27 +0200 (CEST) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CF59881CE7 for ; Sat, 29 May 2021 20:14:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jmcosta944@gmail.com Received: by mail-wr1-x429.google.com with SMTP id f11so6501283wrq.1 for ; Sat, 29 May 2021 11:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QEpqk5kXBntmIK6Uv7EONM/9789COY+NhYfk5JEEd5A=; b=jrZhkXdQNycxSaFuYSSEIBRXsz1sbSTALJjP0flmlfl+XHnA2qtsu5r1ITyvNUeiJc KKaa6pvtSJw2Tuou166+Q6oSDvvt2lCoLx4ox3kkjMGBVuaCeUX+z29zJMBnVj4g7IM4 dD6scpatm/YahDs+4o/BRTO0rr9ordM1sIDJRVG+LK9LjDY5oTEujQUG7PkvwRIM38dT Ae21MsBttj6EWz1/iiftDFZ38kG9vLOL7P+wx9EUb3l1zm44PeZGBwXULoWKY5umwkJD g8RX/XXDwCFwgMctauzEMFXyGbt4+lz/nL/M9vqrkk2Y/9hz4knTQSE44Vt0Sw/ApywT mv/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QEpqk5kXBntmIK6Uv7EONM/9789COY+NhYfk5JEEd5A=; b=UqyaxzNSuuAlDdbEmP4NiKc/KSVELWIAO3lCXDJkuN+m1D+udpRNpZE+EbEvkVC+1h PkUf+b6RV/6SgWJokfOgqgFlQtvbqlU9s7SJSWqtwJZJZHD2LMDLv3FJrhdV5iwwnFdY 1Z8VtIvYKIXG1q8r3ukDY9YXBZMk73/Z56rJnvyq3fkrXiDbu15cuUuberYzL99B7d/3 twJEm3s+uWXK+huU7VfJwbXnJmxemCSKzWLzxgpHyeWG9oAbGRnc6IOhbGTnVaRGOOHt AoCghhVeBJYZnt6FwSZNh+AwHlfkIZP7ZNN1Ys/cp4VGsoZ0Tgt3Ae/n/dKriZdOuP+8 2YUA== X-Gm-Message-State: AOAM531iPVN1itl2rNDzABS01Q65D5tJApXy1HTJ/O2QRre/s3YyOaRp Xb50ZSpV90Y7DV/76rGL8mdWVINFxGUimBg3WlE= X-Google-Smtp-Source: ABdhPJwI6Fg1OuwzcyBiO+2tGCNydoIF3rO2CQt7mepKLkAaciCgeXdueyezua9wwIxRTxd60XXbOVV4t4VgDPgEm40= X-Received: by 2002:adf:a28c:: with SMTP id s12mr15307175wra.105.1622312064321; Sat, 29 May 2021 11:14:24 -0700 (PDT) MIME-Version: 1.0 References: <20210524023133.22100-1-jmcosta944@gmail.com> <20210524023133.22100-2-jmcosta944@gmail.com> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_Marcos_Costa?= Date: Sat, 29 May 2021 15:14:13 -0300 Message-ID: Subject: Re: [PATCH 1/3] test/py: rewrite common tools for SquashFS tests To: Simon Glass Cc: U-Boot Mailing List , Thomas Petazzoni , Miquel Raynal , Richard Genoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hello, Em qui., 27 de mai. de 2021 =C3=A0s 10:44, Simon Glass escreveu: > Hi Joao, > > On Sun, 23 May 2021 at 20:31, Joao Marcos Costa > wrote: > > > > Remove the previous OOP approach, which was confusing and incomplete. > > Add more test cases by making SquashFS images with various options, > > concerning file fragmentation and its compression. Add comments to > > properly document the code. > > > > Signed-off-by: Joao Marcos Costa > > --- > [...] > > While we are here, can you please be a little more formal with your > function comments? pylint3 will tell you about it if you run it on > this file. > > [...] > > Regards, > Simon > Absolutely, Simon, and thanks for suggesting pylint3! --=20 Atenciosamente, Jo=C3=A3o Marcos Costa www.linkedin.com/in/jmarcoscosta/ https://github.com/jmarcoscosta