Re: [PATCH V6 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl

From: Tamas Lengyel <tamas.lengyel@zentific.com>
To: Tim Deegan <tim@xen.org>
Cc: Kevin Tian <kevin.tian@intel.com>,
	wei.liu2@citrix.com, Ian Campbell <ian.campbell@citrix.com>,
	Steven Maresca <steve@zentific.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Eddie Dong <eddie.dong@intel.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org,
	Andres Lagar-Cavilla <andres@lagarcavilla.org>,
	Jan Beulich <jbeulich@suse.com>,
	rshriram@cs.ubc.ca, Keir Fraser <keir@xen.org>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	yanghy@cn.fujitsu.com
Subject: Re: [PATCH V6 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl
Date: Thu, 12 Mar 2015 17:00:35 +0100	[thread overview]
Message-ID: <CABfawhkSrc-BD=fdaoJxL8=kVhCb-8_FqMVHJXoN7Bg3JPzqeQ@mail.gmail.com> (raw)
In-Reply-To: <20150312155604.GJ22158@deinos.phlegethon.org>

[-- Attachment #1.1: Type: text/plain, Size: 1361 bytes --]

On Thu, Mar 12, 2015 at 4:56 PM, Tim Deegan <tim@xen.org> wrote:

> At 01:11 +0100 on 18 Feb (1424218303), Tamas K Lengyel wrote:
> > Thus far mem_access and mem_sharing memops had been able to signal
> > to Xen to start pulling responses off the corresponding rings. In this
> patch
> > we retire these memops and add them to the option to the vm_event_op
> domctl.
> >
> > The vm_event_op domctl suboptions are the same for each ring thus we
> > consolidate them into XEN_VM_EVENT_ENABLE/DISABLE/RESUME.
> >
> > As part of this patch in libxc we also rename the
> mem_access_enable/disable
> > functions to monitor_enable/disable and move them into xc_monitor.c.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> I think there's still an outstanding question about the repeated code
> in vm_event.c, which could be unified -- last time you suggested maybe
> just getting rid of the wakeup operation entirely.
>

I'm still trying to figure out if there is a different use-case that may
necessitate having the two redundant operations that we have today. For now
it doesn't hurt and we can retire one if it is indeed verified there is no
need to have two.

>
> Nevertheless I think this patch is good on its own.  So,
>
> Acked-by: Tim Deegan <tim@xen.org>
>
> Cheers,
>
> Tim
>

Thanks,
Tamas

[-- Attachment #1.2: Type: text/html, Size: 2129 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel