From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH V3] xen/altp2m: set access_required properly for all altp2ms Date: Thu, 28 Jun 2018 10:19:34 -0600 Message-ID: References: <1530172441-2553-1-git-send-email-rcojocaru@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1530172441-2553-1-git-send-email-rcojocaru@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Razvan Cojocaru Cc: Tim Deegan , Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Xen-devel , Julien Grall , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMTo1NCBBTSBSYXp2YW4gQ29qb2NhcnUKPHJjb2pvY2Fy dUBiaXRkZWZlbmRlci5jb20+IHdyb3RlOgo+Cj4gRm9yIHRoZSBob3N0cDJtLCBhY2Nlc3NfcmVx dWlyZWQgc3RhcnRzIG9mZiBhcyAwLCB0aGVuIGl0IGNhbiBiZQo+IHNldCB3aXRoIHhjX2RvbWFp bl9zZXRfYWNjZXNzX3JlcXVpcmVkKCkuIEhvd2V2ZXIsIGFsbCB0aGUgYWx0cDJtcwo+IHNldCBp dCB0byAxIG9uIGluaXQsIGFuZCBpZ25vcmUgYm90aCB0aGUgaG9zdHAybSBhbmQgdGhlIGh5cGVy Y2FsbC4KPiBUaGlzIHBhdGNoIHNldHMgYWNjZXNzX3JlcXVpcmVkIHRvIHRoZSB2YWx1ZSBmcm9t IHRoZSBob3N0cDJtCj4gb24gYWx0cDJtIGluaXQsIGFuZCBwcm9wYWdhdGVzIHRoZSB2YWx1ZXMg cmVjZWl2ZWQgdmlhIGh5cGVyY2FsbAo+IHRvIGFsbCB0aGUgYWN0aXZlIGFsdHAybXMsIHdoZW4g YXBwbGljYWJsZS4KPgo+IFNpZ25lZC1vZmYtYnk6IFJhenZhbiBDb2pvY2FydSA8cmNvam9jYXJ1 QGJpdGRlZmVuZGVyLmNvbT4KCkxHVE0KCkFja2VkLWJ5OiBUYW1hcyBLIExlbmd5ZWwgPHRhbWFz QHRrbGVuZ3llbC5jb20+Cgo+Cj4gLS0tCj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4KPiBDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNv bT4KPiBDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPiBDYzog R2VvcmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBldS5jaXRyaXguY29tPgo+IENjOiBJYW4gSmFj a3NvbiA8aWFuLmphY2tzb25AZXUuY2l0cml4LmNvbT4KPiBDYzogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgo+IENjOiBLb25yYWQgUnplc3p1dGVrIFdpbGsgPGtvbnJhZC53aWxrQG9y YWNsZS5jb20+Cj4gQ2M6IFRpbSBEZWVnYW4gPHRpbUB4ZW4ub3JnPgo+IENjOiBXZWkgTGl1IDx3 ZWkubGl1MkBjaXRyaXguY29tPgo+IENjOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGV1 LmNpdHJpeC5jb20+Cj4gQ2M6IFRhbWFzIEsgTGVuZ3llbCA8dGFtYXNAdGtsZW5neWVsLmNvbT4K PiAtLS0KPiBDaGFuZ2VzIHNpbmNlIFYyOgo+ICAtIFJlbmFtZWQgYXJjaF9kb21haW5fc2V0X2Fj Y2Vzc19yZXF1aXJlZCgpIHRvCj4gICAgYXJjaF9wMm1fc2V0X2FjY2Vzc19yZXF1aXJlZCgpIChy ZXF1ZXN0ZWQgYnkgV2VpIExpdSkuCj4gIC0gQWRkZWQgQVNTRVJUKGF0b21pY19yZWFkKCZkLT5w YXVzZV9jb3VudCkpIHRvCj4gICAgYXJjaF9wMm1fc2V0X2FjY2Vzc19yZXF1aXJlZCgpIChyZXF1 ZXN0ZWQgYnkgV2VpIExpdSkuCj4gLS0tCj4gIHhlbi9hcmNoL2FybS9tZW1fYWNjZXNzLmMgICAg fCAgNiArKysrKysKPiAgeGVuL2FyY2gveDg2L21tL21lbV9hY2Nlc3MuYyB8IDIwICsrKysrKysr KysrKysrKysrKysrCj4gIHhlbi9hcmNoL3g4Ni9tbS9wMm0uYyAgICAgICAgfCAgMyArKy0KPiAg eGVuL2NvbW1vbi9kb21jdGwuYyAgICAgICAgICB8ICA0ICsrLS0KPiAgeGVuL2luY2x1ZGUveGVu L2RvbWFpbi5oICAgICB8ICAyICsrCj4gIDUgZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygr KSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vbWVtX2FjY2Vz cy5jIGIveGVuL2FyY2gvYXJtL21lbV9hY2Nlc3MuYwo+IGluZGV4IGFlMjY4NmYuLmJhNGVjNzgg MTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL21lbV9hY2Nlc3MuYwo+ICsrKyBiL3hlbi9hcmNo L2FybS9tZW1fYWNjZXNzLmMKPiBAQCAtNDUzLDYgKzQ1MywxMiBAQCBpbnQgcDJtX2dldF9tZW1f YWNjZXNzKHN0cnVjdCBkb21haW4gKmQsIGdmbl90IGdmbiwKPiAgICAgIHJldHVybiByZXQ7Cj4g IH0KPgo+ICt2b2lkIGFyY2hfcDJtX3NldF9hY2Nlc3NfcmVxdWlyZWQoc3RydWN0IGRvbWFpbiAq ZCwgYm9vbCBhY2Nlc3NfcmVxdWlyZWQpCj4gK3sKPiArICAgIEFTU0VSVChhdG9taWNfcmVhZCgm ZC0+cGF1c2VfY291bnQpKTsKPiArICAgIHAybV9nZXRfaG9zdHAybShkKS0+YWNjZXNzX3JlcXVp cmVkID0gYWNjZXNzX3JlcXVpcmVkOwo+ICt9Cj4gKwo+ICAvKgo+ICAgKiBMb2NhbCB2YXJpYWJs ZXM6Cj4gICAqIG1vZGU6IEMKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L21tL21lbV9hY2Nl c3MuYyBiL3hlbi9hcmNoL3g4Ni9tbS9tZW1fYWNjZXNzLmMKPiBpbmRleCBjMGNkMDE3Li40NjRi ZTQ5IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9tZW1fYWNjZXNzLmMKPiArKysgYi94 ZW4vYXJjaC94ODYvbW0vbWVtX2FjY2Vzcy5jCj4gQEAgLTQ2NSw2ICs0NjUsMjYgQEAgaW50IHAy bV9nZXRfbWVtX2FjY2VzcyhzdHJ1Y3QgZG9tYWluICpkLCBnZm5fdCBnZm4sIHhlbm1lbV9hY2Nl c3NfdCAqYWNjZXNzKQo+ICAgICAgcmV0dXJuIF9wMm1fZ2V0X21lbV9hY2Nlc3MocDJtLCBnZm4s IGFjY2Vzcyk7Cj4gIH0KPgo+ICt2b2lkIGFyY2hfcDJtX3NldF9hY2Nlc3NfcmVxdWlyZWQoc3Ry dWN0IGRvbWFpbiAqZCwgYm9vbCBhY2Nlc3NfcmVxdWlyZWQpCj4gK3sKPiArICAgIHVuc2lnbmVk IGludCBpOwo+ICsKPiArICAgIEFTU0VSVChhdG9taWNfcmVhZCgmZC0+cGF1c2VfY291bnQpKTsK PiArCj4gKyAgICBwMm1fZ2V0X2hvc3RwMm0oZCktPmFjY2Vzc19yZXF1aXJlZCA9IGFjY2Vzc19y ZXF1aXJlZDsKPiArCj4gKyAgICBpZiAoICFhbHRwMm1fYWN0aXZlKGQpICkKPiArICAgICAgICBy ZXR1cm47Cj4gKwo+ICsgICAgZm9yICggaSA9IDA7IGkgPCBNQVhfQUxUUDJNOyBpKysgKQo+ICsg ICAgewo+ICsgICAgICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0gPSBkLT5hcmNoLmFsdHAybV9w Mm1baV07Cj4gKwo+ICsgICAgICAgIGlmICggcDJtICkKPiArICAgICAgICAgICAgcDJtLT5hY2Nl c3NfcmVxdWlyZWQgPSBhY2Nlc3NfcmVxdWlyZWQ7Cj4gKyAgICB9Cj4gK30KPiArCj4gIC8qCj4g ICAqIExvY2FsIHZhcmlhYmxlczoKPiAgICogbW9kZTogQwo+IGRpZmYgLS1naXQgYS94ZW4vYXJj aC94ODYvbW0vcDJtLmMgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMKPiBpbmRleCBjNTNjYWI0Li44 ZTlmYmI1IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwo+ICsrKyBiL3hlbi9h cmNoL3g4Ni9tbS9wMm0uYwo+IEBAIC0xOTksNiArMTk5LDcgQEAgc3RhdGljIGludCBwMm1faW5p dF9hbHRwMm0oc3RydWN0IGRvbWFpbiAqZCkKPiAgewo+ICAgICAgdW5zaWduZWQgaW50IGk7Cj4g ICAgICBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtOwo+ICsgICAgc3RydWN0IHAybV9kb21haW4gKmhv c3RwMm0gPSBwMm1fZ2V0X2hvc3RwMm0oZCk7Cj4KPiAgICAgIG1tX2xvY2tfaW5pdCgmZC0+YXJj aC5hbHRwMm1fbGlzdF9sb2NrKTsKPiAgICAgIGZvciAoIGkgPSAwOyBpIDwgTUFYX0FMVFAyTTsg aSsrICkKPiBAQCAtMjEwLDcgKzIxMSw3IEBAIHN0YXRpYyBpbnQgcDJtX2luaXRfYWx0cDJtKHN0 cnVjdCBkb21haW4gKmQpCj4gICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+ICAgICAgICAg IH0KPiAgICAgICAgICBwMm0tPnAybV9jbGFzcyA9IHAybV9hbHRlcm5hdGU7Cj4gLSAgICAgICAg cDJtLT5hY2Nlc3NfcmVxdWlyZWQgPSAxOwo+ICsgICAgICAgIHAybS0+YWNjZXNzX3JlcXVpcmVk ID0gaG9zdHAybS0+YWNjZXNzX3JlcXVpcmVkOwo+ICAgICAgICAgIF9hdG9taWNfc2V0KCZwMm0t PmFjdGl2ZV92Y3B1cywgMCk7Cj4gICAgICB9Cj4KPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9k b21jdGwuYyBiL3hlbi9jb21tb24vZG9tY3RsLmMKPiBpbmRleCA5YjdiYzA4Li43ODliMzBkIDEw MDY0NAo+IC0tLSBhL3hlbi9jb21tb24vZG9tY3RsLmMKPiArKysgYi94ZW4vY29tbW9uL2RvbWN0 bC5jCj4gQEAgLTEwOTIsOCArMTA5Miw4IEBAIGxvbmcgZG9fZG9tY3RsKFhFTl9HVUVTVF9IQU5E TEVfUEFSQU0oeGVuX2RvbWN0bF90KSB1X2RvbWN0bCkKPiAgICAgICAgICBlbHNlCj4gICAgICAg ICAgewo+ICAgICAgICAgICAgICBkb21haW5fcGF1c2UoZCk7Cj4gLSAgICAgICAgICAgIHAybV9n ZXRfaG9zdHAybShkKS0+YWNjZXNzX3JlcXVpcmVkID0KPiAtICAgICAgICAgICAgICAgIG9wLT51 LmFjY2Vzc19yZXF1aXJlZC5hY2Nlc3NfcmVxdWlyZWQ7Cj4gKyAgICAgICAgICAgIGFyY2hfcDJt X3NldF9hY2Nlc3NfcmVxdWlyZWQoZCwKPiArICAgICAgICAgICAgICAgIG9wLT51LmFjY2Vzc19y ZXF1aXJlZC5hY2Nlc3NfcmVxdWlyZWQpOwo+ICAgICAgICAgICAgICBkb21haW5fdW5wYXVzZShk KTsKPiAgICAgICAgICB9Cj4gICAgICAgICAgYnJlYWs7Cj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNs dWRlL3hlbi9kb21haW4uaCBiL3hlbi9pbmNsdWRlL3hlbi9kb21haW4uaAo+IGluZGV4IDE3N2Ni MzUuLmYzNWUzNjAgMTAwNjQ0Cj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oCj4gKysr IGIveGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oCj4gQEAgLTY2LDYgKzY2LDggQEAgdm9pZCBhcmNo X2RvbWFpbl91bnBhdXNlKHN0cnVjdCBkb21haW4gKmQpOwo+Cj4gIGludCBhcmNoX2RvbWFpbl9z b2Z0X3Jlc2V0KHN0cnVjdCBkb21haW4gKmQpOwo+Cj4gK3ZvaWQgYXJjaF9wMm1fc2V0X2FjY2Vz c19yZXF1aXJlZChzdHJ1Y3QgZG9tYWluICpkLCBib29sIGFjY2Vzc19yZXF1aXJlZCk7Cj4gKwo+ ICBpbnQgYXJjaF9zZXRfaW5mb19ndWVzdChzdHJ1Y3QgdmNwdSAqLCB2Y3B1X2d1ZXN0X2NvbnRl eHRfdSk7Cj4gIHZvaWQgYXJjaF9nZXRfaW5mb19ndWVzdChzdHJ1Y3QgdmNwdSAqLCB2Y3B1X2d1 ZXN0X2NvbnRleHRfdSk7Cj4KPiAtLQo+IDIuNy40CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8veGVuLWRldmVs