From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFE5C433E1 for ; Thu, 18 Jun 2020 03:21:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F6E721D7B for ; Thu, 18 Jun 2020 03:21:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sUjVf736" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F6E721D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jll78-0002AU-5k; Thu, 18 Jun 2020 03:21:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jll76-00029t-8D for xen-devel@lists.xenproject.org; Thu, 18 Jun 2020 03:21:16 +0000 X-Inumbo-ID: c450daba-b112-11ea-bb8b-bc764e2007e4 Received: from mail-wr1-x442.google.com (unknown [2a00:1450:4864:20::442]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c450daba-b112-11ea-bb8b-bc764e2007e4; Thu, 18 Jun 2020 03:21:15 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id x6so4416410wrm.13 for ; Wed, 17 Jun 2020 20:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qvpzg+EGseIk50qngoPxiQumjg4bKxs079YWUd41tSE=; b=sUjVf736F+EGAL1puUx5HVQ/sgR1OF3km9e/uueJ5sz0w3xott1ck2oQXUEA7QuQaH Xs3yiY1DdoRRJ5ACl2pPV3xhQyVTml+wvY3sAxCDVyCanm4n62FzGuujP2XXO2x9Tpzj dcNy2//Fws8/wWmPW6G2fvdx3nfAulJybAUCsC4Dkhdag0HvKW55aQJ14hqg1JggLPPc uRj8wsbBvGSUhQ40QHjZRbbzvBUpAkztdecltHkjZpb/JqEKgsl11xTIsUzcqAm+UIzs QkNDr1wGHshsrUmJlkVhpZ97bqnf2T4pfLCrmrbzEupMAT64xe498HFf8duxRjpeBSKF PWhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qvpzg+EGseIk50qngoPxiQumjg4bKxs079YWUd41tSE=; b=dVL11PaTjDyBTypTeF7gnG1em1yoENk6bQnSli4sRm9Io6idjKAOrcA9VmAhACvtXG DMITbwtZNNNtz0ocBwHIddF9GrFFpP0XIrK6NFLeks1ng7SVhaoDNLxgFcVG2sLF7U4B ORDRIyljgMbtWszNF1R5AV5ZROgjOs4Lb8vkYUvl4768UnSj6Jbl5P6fV8nO0fJ2e4u4 0U4rcKBLmNBR8WVCLx9ck/rZgUQe8HVWVyzekqdbOl8x56dT5p91qLl3K8Eb3VyH2PiJ WLQsnCDzwga0+K2ZzWzdyNqMzroWCFjYEmX7gBUhUoZA6/Wqh7i6FcvesJ5AVA8QxhWj Tmeg== X-Gm-Message-State: AOAM5301+MqJjr4frTJBRaEPM1N2PVHxduztLx+/tW8gaQH23CkbZI2T 5o63k5CzSefptJ7S3WNYgKDJvzV3s5OcElBckzE= X-Google-Smtp-Source: ABdhPJzinIel4mrPjxDli5yNbTMczS1/88+RN4zOEEnVLHS0xT21oDNbv+fkt/k4wM+CWVoEn9Bb2flNlPX0w88ZJfE= X-Received: by 2002:adf:f707:: with SMTP id r7mr2451622wrp.390.1592450474521; Wed, 17 Jun 2020 20:21:14 -0700 (PDT) MIME-Version: 1.0 References: <1548605014.8764792.1592320576239.JavaMail.zimbra@cert.pl> <34833328.8766172.1592320926648.JavaMail.zimbra@cert.pl> <20200616172352.GT735@Air-de-Roger> <998292451.9258672.1592421185726.JavaMail.zimbra@cert.pl> In-Reply-To: <998292451.9258672.1592421185726.JavaMail.zimbra@cert.pl> From: Tamas K Lengyel Date: Wed, 17 Jun 2020 21:20:39 -0600 Message-ID: Subject: Re: [PATCH v1 4/7] x86/vmx: add do_vmtrace_op To: =?UTF-8?B?TWljaGHFgiBMZXN6Y3p5xYRza2k=?= Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Jan Beulich , Xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > >> + > >> + a.mfn = v->arch.hvm.vmx.ipt_state->output_base >> PAGE_SHIFT; > > > > This will not work for translated domains, ie: a PVH or HVM domain > > won't be able to use this interface since it has no way to request the > > mapping of a specific mfn into it's physmap. I think we need to take > > this into account when deciding how the interface should be, so that > > we don't corner ourselves with a PV only interface. > > Please be aware that this is only going to be used by Dom0. Is is well-supported case that somebody is using PVH/HVM Dom0? > > I think that all Virtual Machine Introspection stuff currently requires to have Dom0 PV. Our main goal is to have this working well in combo with VMI. FYI the VMI interface doesn't require a PV domain. It works fine from PVH dom0 or even from a secondary privileged HVM DomU as well, provided you have the right XSM policy to allow that. Tamas