From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas@tklengyel.com>
Subject: Re: [PATCH] arm/monitor vm-events: Implement
	guest-request support
Date: Fri, 19 Feb 2016 09:02:59 -0700
Message-ID: <CABfawhnoGGuOtM9-DqMQRm2f=oz6J=WL1U13XcHEkzBOr-ExhQ@mail.gmail.com>
References: <1455824116-13783-1-git-send-email-czuzu@bitdefender.com>
	<56C7341402000078000D427C@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5035825211187680118=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56C7341402000078000D427C@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Corneliu ZUZU <czuzu@bitdefender.com>
List-Id: xen-devel@lists.xenproject.org

--===============5035825211187680118==
Content-Type: multipart/alternative; boundary=001a114e6724fc7f4c052c219d8f

--001a114e6724fc7f4c052c219d8f
Content-Type: text/plain; charset=UTF-8

On Fri, Feb 19, 2016 at 7:26 AM, Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 18.02.16 at 20:35, <czuzu@bitdefender.com> wrote:
> > ---
> >  MAINTAINERS                     |   1 +
> >  xen/arch/arm/hvm.c              |   8 +++
> >  xen/arch/x86/hvm/event.c        | 116
> ++++++----------------------------------
> >  xen/arch/x86/hvm/hvm.c          |   1 +
> >  xen/arch/x86/monitor.c          |  14 -----
> >  xen/arch/x86/vm_event.c         |   1 +
> >  xen/common/Makefile             |   2 +-
> >  xen/common/hvm/Makefile         |   3 +-
> >  xen/common/hvm/event.c          |  96 +++++++++++++++++++++++++++++++++
>
> So here you _again_ try to introduce something HVM-ish for ARM.
> Why? Why can't this code live in common/vm_event.c?
>

I too am wondering if this is the right way to architect this. It would be
better to move the guest-requested stuff into the generic vm_event
component as it doesn't seem to be HVM specific other then it using an
HVMOP hypercall to be triggered.

Tamas

--001a114e6724fc7f4c052c219d8f
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Fri, Feb 19, 2016 at 7:26 AM, Jan Beulich <span dir=3D"ltr">&lt;<a h=
ref=3D"mailto:JBeulich@suse.com" target=3D"_blank">JBeulich@suse.com</a>&gt=
;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=3D"">&gt;&gt;=
&gt; On 18.02.16 at 20:35, &lt;<a href=3D"mailto:czuzu@bitdefender.com">czu=
zu@bitdefender.com</a>&gt; wrote:<br>
&gt; ---<br>
&gt;=C2=A0 MAINTAINERS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A01 +<br>
&gt;=C2=A0 xen/arch/arm/hvm.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 |=C2=A0 =C2=A08 +++<br>
&gt;=C2=A0 xen/arch/x86/hvm/event.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 116 ++++++=
----------------------------------<br>
&gt;=C2=A0 xen/arch/x86/hvm/hvm.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0=
 =C2=A01 +<br>
&gt;=C2=A0 xen/arch/x86/monitor.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0=
 14 -----<br>
&gt;=C2=A0 xen/arch/x86/vm_event.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0=
 =C2=A01 +<br>
&gt;=C2=A0 xen/common/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0|=C2=A0 =C2=A02 +-<br>
&gt;=C2=A0 xen/common/hvm/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0=
 =C2=A03 +-<br>
&gt;=C2=A0 xen/common/hvm/event.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0=
 96 +++++++++++++++++++++++++++++++++<br>
<br>
</span>So here you _again_ try to introduce something HVM-ish for ARM.<br>
Why? Why can&#39;t this code live in common/vm_event.c?<br>
</blockquote><div><br></div><div>I too am wondering if this is the right wa=
y to architect this. It would be better to move the guest-requested stuff i=
nto the generic vm_event component as it doesn&#39;t seem to be HVM specifi=
c other then it using an HVMOP hypercall to be triggered.<br><br></div><div=
>Tamas <br></div></div><br></div></div>

--001a114e6724fc7f4c052c219d8f--


--===============5035825211187680118==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5035825211187680118==--