From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55371C38A02 for ; Sun, 30 Oct 2022 14:19:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op98O-0002Jv-BH; Sun, 30 Oct 2022 10:17:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op98N-0002Jg-BJ for qemu-devel@nongnu.org; Sun, 30 Oct 2022 10:17:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op98L-0004t1-Av for qemu-devel@nongnu.org; Sun, 30 Oct 2022 10:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667139472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7nFDjn+UabxeEH0t9XPd84q+0D1Yh49ed84JLwXb3pA=; b=L5N0gKfVLjIunD3tJWEuK7EHNm9RsiyxVL/QEKw7i0nBXMkov3mQq2OM/CGOAw1wNP1Sf7 fIjKBI7JDMTwGK9cH55lcVBu5JtRSagcf/c8hZI0LESVpusOPny+ZL//Lw6s0uyMtE6Etg JWIIT84EYX9bEei1lUq9rtZiicdX8EM= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-478-WEmJtbdrPlGa-Smg6YlDxw-1; Sun, 30 Oct 2022 10:17:49 -0400 X-MC-Unique: WEmJtbdrPlGa-Smg6YlDxw-1 Received: by mail-ua1-f71.google.com with SMTP id r3-20020ab04a43000000b0041168b89479so18141uae.6 for ; Sun, 30 Oct 2022 07:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7nFDjn+UabxeEH0t9XPd84q+0D1Yh49ed84JLwXb3pA=; b=7CXifr/2u0q0Rsl4rDaIHivdwNGgBx/I+ttRttVAwzr73CMAW9bP5ettY3yirKmFa6 pPG6QT+EyTWvXqdWJVkqfeDWWN/S76sv++gVsbVpVqxz23eBJbocFZOWdiAlz8aNQd/y sU/yhxC0bPt4qQ89Bvu7QdbKYkQ2GaXEE2LlXXaYRhLbs/+I82uBxDcRxHDeVJuOsyWY bmdH/Zkw0lBIDNk1WXLZ5mSoB1eyDQ25tsA+oo8Bh+NDijWTPqrg+A25p6nmqwKvcu64 Sy+AC8FDLGjcvuDzy3a1Y++rF/U929f0zxyOGPplFCo2sXDTqvbNp6z0bVOT7acbGu3f UyAw== X-Gm-Message-State: ACrzQf0vr8EUMfcwj9SWjX1M7MtxQ9l7mEdDXs7KSpmHgRNPKCb5BuIW 1Uwn9n5hgongtog+jhzGt7LdekXt1Sq8vZHRkZMFdH3Wmnwffv35JFcBgFcf7pP8u0cyw+p0W4o dwV1aoDoUWS2Lq0w/HUXy+hBp1nBgRmY= X-Received: by 2002:a67:c997:0:b0:3aa:1d0c:6bc7 with SMTP id y23-20020a67c997000000b003aa1d0c6bc7mr2812905vsk.16.1667139469445; Sun, 30 Oct 2022 07:17:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4muZhGVfCRD8d6KKzMhbWV84BOMtatdR8T5jIZkHbQflmSWwhQOwWQHdlKqbkDzE9ccO7+bF/6XiSpl2Nf3Ew= X-Received: by 2002:a67:c997:0:b0:3aa:1d0c:6bc7 with SMTP id y23-20020a67c997000000b003aa1d0c6bc7mr2812900vsk.16.1667139469084; Sun, 30 Oct 2022 07:17:49 -0700 (PDT) MIME-Version: 1.0 References: <20220914155950.804707-1-alex.bennee@linaro.org> <20220914155950.804707-30-alex.bennee@linaro.org> <72674788-e55a-8429-b1bf-384db3d837aa@linaro.org> <306323d5-1bec-078b-9686-7670b4fdf247@weilnetz.de> <952d57c2-8493-0a7b-8384-96e0f285853a@weilnetz.de> In-Reply-To: <952d57c2-8493-0a7b-8384-96e0f285853a@weilnetz.de> From: Paolo Bonzini Date: Sun, 30 Oct 2022 15:17:36 +0100 Message-ID: Subject: Re: [PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py To: Stefan Weil Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= , qemu-devel Content-Type: multipart/alternative; boundary="000000000000d8a50305ec4127f7" Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.055, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org+qemu-devel=archiver.kernel.org@nongnu.org --000000000000d8a50305ec4127f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I think sudo needs to be changed to "sudo -n" in docker.py. Thanks for the report! Paolo Il sab 29 ott 2022, 23:13 Stefan Weil ha scritto: > Am 29.10.22 um 21:46 schrieb Paolo Bonzini: > > Il sab 29 ott 2022, 11:38 Stefan Weil ha scritto: > >> Am 15.09.22 um 10:41 schrieb Richard Henderson: >> > On 9/14/22 16:59, Alex Benn=C3=A9e wrote: >> >> We want to migrate from docker.py to building our images directly wit= h >> >> docker/podman. Before we get there we need to make sure we don't >> >> re-introduce our layered builds so bug out if we see FROM qemu/ in a >> >> Dockerfile. >> >> >> >> Signed-off-by: Alex Benn=C3=A9e >> >> Acked-by: Thomas Huth >> >> Message-Id:<20220826172128.353798-24-alex.bennee@linaro.org> >> >> --- >> >> tests/docker/docker.py | 38 ++++++++++---------------------------- >> >> 1 file changed, 10 insertions(+), 28 deletions(-) >> > >> > Reviewed-by: Richard Henderson >> > >> > r~ >> > >> >> I am not sure whether that is related, but with latest QEMU code I now >> get an e-mail "SECURITY information [...]" each time when I run the >> configure script (or just `tests/docker/docker.py probe`): >> >> qemu.weilnetz.de : Oct 29 09:32:32 : stefan : a password is required ; >> TTY=3Dpts/0 ; PWD=3D/home/stefan/qemu/bin/ndebug/i686-w64-mingw32 ; >> USER=3Droot ; COMMAND=3Ddocker version >> >> There is no docker installation on my Debian GNU Linux build machine. >> > > It's not related, configure is checking whether "sudo docker" works. > > > You are right. "git bisect" finds that the security e-mails occur since > another commit. > > Stefan > > > c4575b59155e2e0065c29d56496dbf3e6ffd035b is the first bad commit > commit c4575b59155e2e0065c29d56496dbf3e6ffd035b > Author: Paolo Bonzini > Date: Thu Sep 29 12:41:58 2022 +0100 > > configure: store container engine in config-host.mak > > In preparation for removing $(DOCKER_SCRIPT) from the tests/tcg > configuration > files, have Make use the same container engine that had been probed a= t > configure time. > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Alex Benn=C3=A9e > > Message-Id: <20220929114231.583801-19-alex.bennee@linaro.org> > <20220929114231.583801-19-alex.bennee@linaro.org> > > configure | 11 ++++++++--- > tests/docker/Makefile.include | 2 +- > 2 files changed, 9 insertions(+), 4 deletions(-) > > --000000000000d8a50305ec4127f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think sudo=C2=A0 needs to be changed to "sudo -n&q= uot; in docker.py. Thanks for the report!

Paolo=C2=A0

Il sab 29 ott 2022, 23:13 Stefan Weil <sw@weilnetz.de> ha scritto:
=
=20 =20 =20

Am 29.10.22 um 21:46 schrieb Paolo Bonzini:

Il sab 29 ott 2022, 11:38 Stefan Weil <sw@weilnetz.de> h= a scritto:
Am 15.09.22 um 10:41 schrieb Richard Henderson:
> On 9/14/22 16:59, Alex Benn=C3=A9e wrote:
>> We want to migrate from docker.py to building our images directly with
>> docker/podman. Before we get there we need to make sure we don't
>> re-introduce our layered builds so bug out if we see FROM qemu/ in a
>> Dockerfile.
>>
>> Signed-off-by: Alex Benn=C3=A9e<al= ex.bennee@linaro.org>
>> Acked-by: Thomas Huth<thuth@redhat.com>
>> Message-Id:<20220826172128.353798-24-alex.bennee@linaro.org>
>> ---
>> =C2=A0 tests/docker/docker.py | 38 ++++++++++----------------------------
>> =C2=A0 1 file changed, 10 insertions(+), 28 deletions(-)
>
> Reviewed-by: Richard Henderson <= richard.henderson@linaro.org>
>
> r~
>

I am not sure whether that is related, but with latest QEMU code I now
get an e-mail "SECURITY information [...]" each tim= e when I run the
configure script (or just `tests/docker/docker.py probe`):
qemu.weilnetz.de : Oct 29 09:32:32 : stefan : a password is required ;
TTY=3Dpts/0 ; PWD=3D/home/stefan/qemu/bin/ndebug/i686-w64-mingw32 ;
USER=3Droot ; COMMAND=3Ddocker version

There is no docker installation on my Debian GNU Linux build machine.

It's not related, configure is checking wheth= er "sudo docker" works.


You are right. "git bisect" finds that the security e-mail= s occur since another commit.

Stefan


c4575b59155e2e0065c29d56496dbf3e6ffd035b is the first bad commit
commit c4575b59155e2e0065c29d56496dbf3e6ffd035b
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:=C2=A0=C2=A0 Thu Sep 29 12:41:58 2022 +0100

=C2=A0=C2=A0=C2=A0 configure: store container engine in config-host.m= ak
=C2=A0=C2=A0 =C2=A0
=C2=A0=C2=A0=C2=A0 In preparation for removing $(DOCKER_SCRIPT) from = the tests/tcg configuration
=C2=A0=C2=A0=C2=A0 files, have Make use the same container engine tha= t had been probed at
=C2=A0=C2=A0=C2=A0 configure time.
=C2=A0=C2=A0 =C2=A0
=C2=A0=C2=A0=C2=A0 Signed-off-by: Paolo Bonzini <pbonzini@redhat.= com>
=C2=A0=C2=A0=C2=A0 Signed-off-by: Alex Benn=C3=A9e <alex.benne= e@linaro.org>
=C2=A0=C2=A0=C2=A0 Message-Id: <20220929114231.583801-19-alex.bennee= @linaro.org>

=C2=A0configure=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 11 +++= +++++---
=C2=A0tests/docker/Makefile.include |=C2=A0 2 +-
=C2=A02 files changed, 9 insertions(+), 4 deletions(-)

--000000000000d8a50305ec4127f7--