All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Thomas Huth <thuth@redhat.com>, kvm <kvm@vger.kernel.org>,
	"Kernel Mailing List, Linux" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: Adjust the return type of kvm_vm_ioctl_check_extension_generic()
Date: Wed, 1 Jun 2022 12:48:38 +0200	[thread overview]
Message-ID: <CABgObfZ8LipJXh28xjRxqZPyNX1muP=_fYdmH=a9hvQh7eq32w@mail.gmail.com> (raw)
In-Reply-To: <YpZu6/k+8EydfBKf@google.com>

On Tue, May 31, 2022 at 9:39 PM Sean Christopherson <seanjc@google.com> wrote:
> As for KVM_GET_NR_MMU_PAGES, my vote would be just sweep it under the rug with a
> comment and blurb in the documentation that it's broken.  I highly doubt any VMM
> actually uses the ioctl() in any meaningful way as it was largely made obsolete by
> two-dimensional paging, e.g. neither QEMU nor our VMM use it.

I think we can just remove it, or return 0.

Paolo


      reply	other threads:[~2022-06-01 10:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  7:55 [PATCH] KVM: Adjust the return type of kvm_vm_ioctl_check_extension_generic() Thomas Huth
2022-05-31 19:39 ` Sean Christopherson
2022-06-01 10:48   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfZ8LipJXh28xjRxqZPyNX1muP=_fYdmH=a9hvQh7eq32w@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanjc@google.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.