From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD70C433E0 for ; Mon, 15 Feb 2021 23:16:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9674A64DE8 for ; Mon, 15 Feb 2021 23:16:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9674A64DE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBn6R-0003LH-Kq for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 18:16:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBn5G-0002bK-V2 for qemu-devel@nongnu.org; Mon, 15 Feb 2021 18:15:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBn5E-0004bP-Oi for qemu-devel@nongnu.org; Mon, 15 Feb 2021 18:15:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613430911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4u6inT5X3qTIeA807N/eIeiurNzjYzDxX5jLLqTX+fk=; b=Q4Z6M+NpVClhX8yvUjIdOtuehxx3O2k7ANNeAuNL5gX7kQVs+7gJmSFc9UM3KpDijf9YME C+fYWJdZcgGhd6d6LUv/DBmIKaaRN7lMOb+/xbryJ++vGWmkJ+K+j5QW+XjgvtPOsqKsDU qoBfgDiq9gCv/jI6MX0DJxsGDn53l40= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-ZHq_BSvCNlqQch_lv95eTA-1; Mon, 15 Feb 2021 18:15:08 -0500 X-MC-Unique: ZHq_BSvCNlqQch_lv95eTA-1 Received: by mail-pg1-f198.google.com with SMTP id f16so7688352pgh.3 for ; Mon, 15 Feb 2021 15:15:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4u6inT5X3qTIeA807N/eIeiurNzjYzDxX5jLLqTX+fk=; b=E8R9JcMF3y6NBSgU+sj8+kTkWSERlKOAhkQk4jfpgyVL9tV324po0cLRTYrrnbzA+y UoapS26HWi9QgJTk33yqQRu4dO6CSSgbmusjduIDWoM6psaFpdRIsMRyxn50H/dtcICI Wvdl0r3L1v2CGiDr7sBOC5bUo39TcQBuChFqrf6/ROGPw7pcA9UWZCHwF9Ykw5uyJUPQ 7cTECGcxJwhG5SOus30pMar/Vni8nmSBcpQNEq1WWKRynG/L3ETJRNBNYLqndgUk+iMg UDayzAgbkvHY5JybMSg/LuLSStdPFVBeH4SQjBpgMO1n4NgjvBiD749RhmzreB7CyVsq MyyA== X-Gm-Message-State: AOAM533VjeyqrxcFFbz8eTBwcOZhsRpsWhURVY5VYnTDbMxy3gpnfpG/ FGqgov7/nry+ex+T0OvlAFb8hhciWGM86m6w5Qg048MYodnQkcKUG2Y/GsWou5z/DCjoL7IaOJt RWz2aoyw8tETpI+pWu3Wi7opLOHAxQoY= X-Received: by 2002:a17:903:22cc:b029:de:191c:1bdb with SMTP id y12-20020a17090322ccb02900de191c1bdbmr17664063plg.14.1613430906973; Mon, 15 Feb 2021 15:15:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyInTND0ats4GZC91Y1Ajus6xfz7NrWLj5v8utLM7/zE3rp7CQID0AvpdhjMhl8/ci80CysbYVIsbBjRoAUcYY= X-Received: by 2002:a17:903:22cc:b029:de:191c:1bdb with SMTP id y12-20020a17090322ccb02900de191c1bdbmr17664047plg.14.1613430906625; Mon, 15 Feb 2021 15:15:06 -0800 (PST) MIME-Version: 1.0 References: <20210123143128.1167797-1-pbonzini@redhat.com> <20210123143128.1167797-32-pbonzini@redhat.com> In-Reply-To: From: Paolo Bonzini Date: Tue, 16 Feb 2021 00:14:54 +0100 Message-ID: Subject: Re: [PULL 31/31] qemu-option: warn for short-form boolean options To: Peter Maydell Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000000f570805bb68284f" Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000000f570805bb68284f Content-Type: text/plain; charset="UTF-8" Il lun 15 feb 2021, 20:56 Peter Maydell ha scritto: > Alternatively, maybe we could not deprecate this really common syntax > pattern that's going to be in lots of peoples' examples, tutorials, > shell scripts and command lines ? > Unfortunately there is no way to change the code to distinguish okay uses from broken ones. The fundamental issue is that QemuOpts is sometimes typed and sometimes not, so it lacks the information to say that "-chardev socket,server" is fine but "-device virtio-blk-pci,noserial" ("set serial number to the string 'no'") is not. I don't plan to remove the syntax altogether from QemuOpts, but I want to keep open the possibility of switching some options (especially -machine and -object) to a parser which doesn't support it. Paolo > thanks > -- PMM > > --0000000000000f570805bb68284f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Il lun 15 feb 2021, 20:56 Peter Maydell <peter.maydell@linaro.org> ha scritto:
<= /div>
Alternatively, maybe we could not depre= cate this really common syntax
pattern that's going to be in lots of peoples' examples, tutorials,=
shell scripts and command lines ?

Unfortunately there is no way to change th= e code to distinguish okay uses from broken ones. The fundamental issue is = that QemuOpts is sometimes typed and sometimes not, so it lacks the informa= tion to say that "-chardev socket,server" is fine but "-devi= ce virtio-blk-pci,noserial" ("set serial number to the string = 9;no'") is not.

I don't plan to remove the syntax altogether from QemuOpts, but I want= to keep open the possibility of switching some options (especially -machin= e and -object) to a parser which doesn't support it.

Paolo


thanks
-- PMM

--0000000000000f570805bb68284f--