All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 3/3] meson: cleanup common-user/ build
Date: Wed, 22 Dec 2021 23:05:08 +0100	[thread overview]
Message-ID: <CABgObfa4xH55T+SUzN2uVCsvDNwcDOAsME13DA17scH63RebNQ@mail.gmail.com> (raw)
In-Reply-To: <b94b5e23-6e34-d948-2f06-71c1da0ec120@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

Il mar 21 dic 2021, 21:32 Richard Henderson <richard.henderson@linaro.org>
ha scritto:

> On 12/21/21 8:33 AM, Paolo Bonzini wrote:
> > Do not go through a static_library, which is only necessary in order to
> reuse
> > some source files between emulators and tests.
>
> That's not true, is it.  Anyway, you're moving the file to a different
> static_library.  I
> though I had tried this myself, but I don't remember the details now.
>

Right, I will change the commit message to "a static_library just for
common_user files, since the one that covers all of common_ss is enough".

Paolo


>
>
> Tested-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
>
>

[-- Attachment #2: Type: text/html, Size: 1556 bytes --]

      reply	other threads:[~2021-12-22 22:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 16:32 [PATCH 0/3] build: some cleanups for common-user/ infrastructure Paolo Bonzini
2021-12-21 16:32 ` [PATCH 1/3] meson: reuse common_user_inc when building files specific to user-mode emulators Paolo Bonzini
2021-12-21 20:33   ` Richard Henderson
2021-12-21 16:32 ` [PATCH 2/3] user: move common-user includes to a subdirectory of {bsd, linux}-user/ Paolo Bonzini
2021-12-21 19:56   ` [PATCH 2/3] user: move common-user includes to a subdirectory of {bsd,linux}-user/ Richard Henderson
2021-12-21 19:57     ` Richard Henderson
2021-12-21 20:32   ` Richard Henderson
2021-12-21 16:33 ` [PATCH 3/3] meson: cleanup common-user/ build Paolo Bonzini
2021-12-21 20:31   ` Richard Henderson
2021-12-22 22:05     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABgObfa4xH55T+SUzN2uVCsvDNwcDOAsME13DA17scH63RebNQ@mail.gmail.com \
    --to=pbonzini@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.