All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Alex Bennee" <alex.bennee@linaro.org>
Subject: Re: dangers of current NEED_CPU_H, CONFIG_SOFTMMU, CONFIG_USER_ONLY (was: [PATCH v11 7/7] cpu: introduce cpu_accel_instance_init)
Date: Thu, 17 Dec 2020 22:13:17 +0100	[thread overview]
Message-ID: <CABgObfaQBuwQ3UHC6VLm03Y=djQQnorT+Ecqx5QLe0oz_XrAXQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8RyT58QCX=UpfGRrOvBZWAC7Jhvq0t+X2cAX7qEjhfkQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]

I will take a look, CONFIG_USER_ONLY is definitely something that should be
poisoned.

Paolo

Il gio 17 dic 2020, 21:26 Peter Maydell <peter.maydell@linaro.org> ha
scritto:

> On Thu, 17 Dec 2020 at 20:15, Peter Maydell <peter.maydell@linaro.org>
> wrote:
> > (So in theory we could make CONFIG_USER_ONLY
> > a poisoned identifier but that will require some work to
> > adjust places where we currently use it in "safe" ways...)
>
> Specifically, putting it in poison.h turns up these places
> that would need to be made to do what they're doing in a
> different way somehow:
>
> ../../hw/core/cpu.c:211:14: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/disas/disas.h:27:13: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/exec/address-spaces.h:24:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/exec/cpu-common.h:20:14: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/exec/cpu-common.h:6:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/exec/ioport.h:43:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/exec/memory.h:17:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/exec/ramblock.h:22:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/hw/core/cpu.h:1035:8: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/hw/core/cpu.h:518:14: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/hw/core/cpu.h:602:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/hw/hw.h:4:8: error: attempt to use poisoned "CONFIG_USER_ONLY"
> include/hw/semihosting/semihost.h:29:8: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/sysemu/accel.h:40:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/sysemu/cpus.h:65:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/sysemu/dma.h:34:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
> include/sysemu/xen.h:27:9: error: attempt to use poisoned
> "CONFIG_USER_ONLY"
>
> That cpu.c one is definitely dubious given it's in a C file,
> not a header.
>
> thanks
> -- PMM
>
>

[-- Attachment #2: Type: text/html, Size: 2780 bytes --]

  reply	other threads:[~2020-12-17 21:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 10:09 [PATCH v11 0/7] i386 cleanup PART 2 Claudio Fontana
2020-12-11 10:09 ` [PATCH v11 1/7] accel: extend AccelState and AccelClass to user-mode Claudio Fontana
2020-12-11 10:09 ` [PATCH v11 2/7] accel: replace struct CpusAccel with AccelOpsClass Claudio Fontana
2020-12-11 10:09 ` [PATCH v11 3/7] accel: introduce AccelCPUClass extending CPUClass Claudio Fontana
2020-12-11 10:09 ` [PATCH v11 4/7] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2020-12-11 10:09 ` [PATCH v11 5/7] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2020-12-11 10:09 ` [PATCH v11 6/7] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn Claudio Fontana
2020-12-11 10:09 ` [PATCH v11 7/7] cpu: introduce cpu_accel_instance_init Claudio Fontana
2020-12-17 19:46   ` dangers of current NEED_CPU_H, CONFIG_SOFTMMU, CONFIG_USER_ONLY (was: [PATCH v11 7/7] cpu: introduce cpu_accel_instance_init) Claudio Fontana
2020-12-17 20:15     ` Peter Maydell
2020-12-17 20:26       ` Peter Maydell
2020-12-17 21:13         ` Paolo Bonzini [this message]
2020-12-17 22:01           ` Eduardo Habkost
2020-12-17 20:32       ` Eduardo Habkost
2020-12-17 21:15       ` dangers of current NEED_CPU_H, CONFIG_SOFTMMU, CONFIG_USER_ONLY Claudio Fontana
2020-12-17 22:45       ` Claudio Fontana
2020-12-17 22:49         ` Peter Maydell
2020-12-17 23:47           ` Claudio Fontana
2020-12-18  0:14             ` Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfaQBuwQ3UHC6VLm03Y=djQQnorT+Ecqx5QLe0oz_XrAXQ@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cfontana@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.