All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: misono.tomohiro@jp.fujitsu.com,
	qemu-devel <qemu-devel@nongnu.org>,
	stefanha@redhat.com, David Gilbert <dgilbert@redhat.com>
Subject: Re: [PATCH 0/1] Allow to build virtiofsd without the entire tools
Date: Tue, 2 Feb 2021 00:04:23 +0100	[thread overview]
Message-ID: <CABgObfanXqg9rd1OnumUnSCm0n76mDbP9kNzp8ih0+SJ4jDXgA@mail.gmail.com> (raw)
In-Reply-To: <20210201211456.1133364-1-wainersm@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Il lun 1 feb 2021, 22:15 Wainer dos Santos Moschetta <wainersm@redhat.com>
ha scritto:

> Not too long ago (QEMU 5.0) it was possible to configure with
> --disable-tools
> and still have virtiofsd built. With the recent port of the build system to
> Meson, it is now built together with the tools though.
>
> The Kata Containers [1] project build QEMU with --disable-tools to
> decrease the
> attack surface


---enable-tools only adds separate executables, therefore it can't add to
the attack surface of the emulators. So this is misleading.

That said, it does make sense to let --enable-virtiofsd override
--disable-tools, and the same in the other direction too.

Paolo

Side note: in a private chat with Stefan Hajnoczi he come up with the idea
> that perhaps --disable-tools could be like --without-default-features where
> one can add back on feature-by-feature basis. This is outside the scope of
> this
> series but I thought in sharing because IMHO it is deserves a discussion.


> [1] https://katacontainers.io
>
> Wainer dos Santos Moschetta (1):
>   virtiofsd: Allow to build it without the tools
>
>  tools/meson.build | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> --
> 2.29.2
>
>

[-- Attachment #2: Type: text/html, Size: 2256 bytes --]

  parent reply	other threads:[~2021-02-01 23:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 21:14 [PATCH 0/1] Allow to build virtiofsd without the entire tools Wainer dos Santos Moschetta
2021-02-01 21:14 ` [PATCH 1/1] virtiofsd: Allow to build it without the tools Wainer dos Santos Moschetta
2021-02-02  5:55   ` misono.tomohiro
2021-02-02 12:58     ` Wainer dos Santos Moschetta
2021-02-03 11:30       ` Dr. David Alan Gilbert
2021-02-16 10:59       ` Dr. David Alan Gilbert
2021-02-03 14:41   ` Stefan Hajnoczi
2021-02-01 23:04 ` Paolo Bonzini [this message]
2021-02-02 12:48   ` [PATCH 0/1] Allow to build virtiofsd without the entire tools Wainer dos Santos Moschetta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABgObfanXqg9rd1OnumUnSCm0n76mDbP9kNzp8ih0+SJ4jDXgA@mail.gmail.com \
    --to=pbonzini@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=misono.tomohiro@jp.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.