From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A884AC433E0 for ; Mon, 1 Feb 2021 23:05:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24F3E64EAA for ; Mon, 1 Feb 2021 23:05:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24F3E64EAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6iGc-0004vC-17 for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 18:05:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6iFS-0004O1-Nm for qemu-devel@nongnu.org; Mon, 01 Feb 2021 18:04:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6iFN-0006no-C0 for qemu-devel@nongnu.org; Mon, 01 Feb 2021 18:04:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612220679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvnMG6CADm48dG/hBh79DnWoayzEWeo3bA5fN8YsSoU=; b=Lup59yg/qwAM1ozECjy+VnpErtzT4WKSE1cctaPqVDAXJKtk78Mt4mvEtxLUOG6gBvFtYw P5yV0nsR5ALaKa4FnYxDT9FwI+Dee/wxv+GKEa4FsGMixmkzW3jPoyLxM6ZyrlCrjImgl3 UXa7ohJ8s4ZbsaEkON7nuCL5IqrlanM= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-hCK6pTVbOlOJTtXyz7n6DA-1; Mon, 01 Feb 2021 18:04:37 -0500 X-MC-Unique: hCK6pTVbOlOJTtXyz7n6DA-1 Received: by mail-pg1-f200.google.com with SMTP id l7so6374538pgj.4 for ; Mon, 01 Feb 2021 15:04:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UvnMG6CADm48dG/hBh79DnWoayzEWeo3bA5fN8YsSoU=; b=hzObeNknD0azWFmU4dgVBI6AmtEQVWvKpKxmkC3CSGLahSMuYAmuyuAjhCHsbHy0Eo ePpYnJbNzqKUQ9nZn4LY5s3EwK76np4Owme2oDNi6/lhbS3lQ5T5OMpzIkXrAMj6fjY3 HA+zg+7t57ASamAaGGPYjvwBaNLLtNWCmlnpqZoqCrUXTayduo1BaXgJhzrC8nMi52CG eh5a621V9lNuD9IzpX3dEt4aOctbZigmfsyGv9KE1DVTIlvbLENgb1UJYRXl7nqTE/kg qikk0vUv8CSr1ySZJnu58AGr2I6Prhe51r8QJ+56lJli+totyYps8bAmnuvdD6wrph+i 7d7A== X-Gm-Message-State: AOAM533E3RwKG1O1hG4BbVLPWdWyfYANqZZlGV5fCcdcrxx49hBdRqkq BfwDwKWbww5+JcpthVXyjovyvQZn/wa8qvXzx9Q5RovavQfkxcV+/pJ4cKtIXLd3C1ALOckoBw+ +V97fgjgnli7Au+4syKZKx6cqdrVTJOc= X-Received: by 2002:a17:90a:294e:: with SMTP id x14mr1146756pjf.6.1612220676277; Mon, 01 Feb 2021 15:04:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWcHA0Nun1JrApBEElCalHtTh5T+FYhrBDaEJwrgrg6AskHE4PZTTnRQci4Q9wQff9eo8iTHlo1VgExtHtjGc= X-Received: by 2002:a17:90a:294e:: with SMTP id x14mr1146737pjf.6.1612220675972; Mon, 01 Feb 2021 15:04:35 -0800 (PST) MIME-Version: 1.0 References: <20210201211456.1133364-1-wainersm@redhat.com> In-Reply-To: <20210201211456.1133364-1-wainersm@redhat.com> From: Paolo Bonzini Date: Tue, 2 Feb 2021 00:04:23 +0100 Message-ID: Subject: Re: [PATCH 0/1] Allow to build virtiofsd without the entire tools To: Wainer dos Santos Moschetta Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000b11c6005ba4e603c" Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: misono.tomohiro@jp.fujitsu.com, qemu-devel , stefanha@redhat.com, David Gilbert Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000b11c6005ba4e603c Content-Type: text/plain; charset="UTF-8" Il lun 1 feb 2021, 22:15 Wainer dos Santos Moschetta ha scritto: > Not too long ago (QEMU 5.0) it was possible to configure with > --disable-tools > and still have virtiofsd built. With the recent port of the build system to > Meson, it is now built together with the tools though. > > The Kata Containers [1] project build QEMU with --disable-tools to > decrease the > attack surface ---enable-tools only adds separate executables, therefore it can't add to the attack surface of the emulators. So this is misleading. That said, it does make sense to let --enable-virtiofsd override --disable-tools, and the same in the other direction too. Paolo Side note: in a private chat with Stefan Hajnoczi he come up with the idea > that perhaps --disable-tools could be like --without-default-features where > one can add back on feature-by-feature basis. This is outside the scope of > this > series but I thought in sharing because IMHO it is deserves a discussion. > [1] https://katacontainers.io > > Wainer dos Santos Moschetta (1): > virtiofsd: Allow to build it without the tools > > tools/meson.build | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > -- > 2.29.2 > > --000000000000b11c6005ba4e603c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Il lun 1 feb 2021, 22:15 Wainer dos Santos Moschetta &= lt;wainersm@redhat.com> ha sc= ritto:
Not too long ago (QEMU 5.0) = it was possible to configure with --disable-tools
and still have virtiofsd built. With the recent port of the build system to=
Meson, it is now built together with the tools though.

The Kata Containers [1] project build QEMU with --disable-tools to decrease= the
attack surface

---enable-tools only = adds separate executables, therefore it can't add to the attack surface= of the emulators. So this is misleading.

=
That said, it does make sense to let --enable-virtiofsd o= verride --disable-tools, and the same in the other direction too.

Paolo

=
Side note: in a private chat with Stefan Hajnoczi he come up with th= e idea
that perhaps --disable-tools could be like --without-default-features where=
one can add back on feature-by-feature basis. This is outside the scope of = this
series but I thought in sharing because IMHO it is deserves a discussion.

[1] https://katacontainers.io

Wainer dos Santos Moschetta (1):
=C2=A0 virtiofsd: Allow to build it without the tools

=C2=A0tools/meson.build | 7 +++++--
=C2=A01 file changed, 5 insertions(+), 2 deletions(-)

--
2.29.2

--000000000000b11c6005ba4e603c--