From: James Park <james.park@lagfreegames.com>
To: Simon Ser <contact@emersion.fr>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
James Park <jpark37@lagfreegames.com>
Subject: Re: [PATCH] drm: Allow drm_fourcc.h without including drm.h
Date: Fri, 4 Dec 2020 02:08:24 -0800 [thread overview]
Message-ID: <CABjik9cWPVFXG6ctb=j3L296fB9xXYQK9JiN29wWLTVmvDsYFw@mail.gmail.com> (raw)
In-Reply-To: <CABjik9cos_qa-jS2MO0iYPmf7qhuwKRKaKSqeGdhNZoHoQtOkQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1343 bytes --]
I suppose I should do this to avoid fighting with <linux/types.h>
#ifdef DRM_FOURCC_STANDALONE
#if defined(__linux__)
#include <linux/types.h>
#else
#include <stdint.h>
typedef uint32_t __u32;
typedef uint64_t __u64;
#endif
#else
#include "drm.h"
#endif
I'll wait for more feedback before updating the patch though.
On Fri, Dec 4, 2020 at 1:47 AM James Park <james.park@lagfreegames.com>
wrote:
> The typedefs might also conflict on Linux if DRM_FOURCC_STANDALONE is
> enabled with whatever LInux declared __u32/__u64 as, but I think the
> implication is that once DRM_FOURCC_STANDALONE has been declared, that's
> kind of a promise not to include drm.h.
>
> I'm fine with this, but I'm not married to it if someone has a problem
> where they want to define DRM_FOURCC_STANDALONE, but also can't avoid
> including drm.h for some reason.
>
> On Fri, Dec 4, 2020 at 12:53 AM Simon Ser <contact@emersion.fr> wrote:
>
>> On Friday, December 4, 2020 5:53 AM, James Park <jpark37@lagfreegames.com>
>> wrote:
>>
>> > +#ifdef DRM_FOURCC_STANDALONE
>> > +#include <stdint.h>
>> >
>> > +typedef uint32_t __u32;
>> > +typedef uint64_t __u64;
>> > +#else
>> > #include "drm.h"
>> > +#endif
>>
>> C11 allows duplicate typedefs, but older versions of the standard
>> don't AFAIK. If this is a concern, a solution would be to guard the
>> typedefs.
>>
>
[-- Attachment #1.2: Type: text/html, Size: 2224 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-07 8:57 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 10:01 drm: Fix drm.h uapi header for Windows James Park
2020-12-01 10:01 ` [PATCH] " James Park
2020-12-02 8:46 ` Simon Ser
2020-12-02 9:07 ` James Park
2020-12-02 9:07 ` James Park
2020-12-02 11:42 ` Michel Dänzer
2020-12-02 12:46 ` Daniel Vetter
2020-12-02 18:06 ` Michel Dänzer
2020-12-02 19:47 ` James Park
2020-12-02 22:25 ` Daniel Vetter
2020-12-03 1:24 ` James Park
2020-12-03 9:05 ` Pekka Paalanen
2020-12-03 12:54 ` Ville Syrjälä
2020-12-03 13:13 ` Simon Ser
2020-12-03 8:18 ` Michel Dänzer
2020-12-03 14:52 ` Daniel Vetter
2020-12-03 18:55 ` James Park
2020-12-03 20:45 ` Daniel Vetter
2020-12-04 4:53 ` [PATCH] drm: Allow drm_fourcc.h without including drm.h James Park
2020-12-04 4:53 ` James Park
2020-12-04 8:53 ` Simon Ser
2020-12-04 9:47 ` James Park
2020-12-04 10:08 ` James Park [this message]
2020-12-04 14:46 ` kernel test robot
2020-12-04 14:46 ` kernel test robot
2020-12-04 22:29 ` kernel test robot
2020-12-04 22:29 ` kernel test robot
2020-12-04 8:11 ` [PATCH] drm: Fix drm.h uapi header for Windows Pekka Paalanen
2020-12-04 15:58 ` Daniel Vetter
2020-12-04 19:07 ` James Park
2020-12-06 0:39 ` [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE James Park
2020-12-06 0:39 ` James Park
2020-12-07 9:45 ` Simon Ser
2020-12-07 9:55 ` James Park
2020-12-07 9:59 ` Simon Ser
2020-12-07 10:05 ` James Park
2020-12-07 10:15 ` Simon Ser
2020-12-07 17:25 ` kernel test robot
2020-12-07 17:25 ` kernel test robot
2020-12-07 18:15 ` James Park
2020-12-07 18:15 ` James Park
2020-12-08 12:31 ` Simon Ser
2020-12-08 18:32 ` James Park
2020-12-09 10:15 ` Simon Ser
2020-12-09 10:18 ` Simon Ser
2020-12-09 11:03 ` James Park
2020-12-09 11:03 ` James Park
2020-12-10 8:35 ` Pekka Paalanen
2020-12-10 9:12 ` James Park
2020-12-10 9:12 ` James Park
2021-02-01 21:45 ` James Park
2021-02-02 17:28 ` Emil Velikov
2021-02-02 18:14 ` James Park
2021-02-02 22:48 ` Emil Velikov
2021-02-02 23:05 ` Simon Ser
2021-02-02 8:51 ` Simon Ser
2021-02-02 8:52 ` Simon Ser
2020-12-07 8:51 ` [PATCH] drm: Fix drm.h uapi header for Windows Pekka Paalanen
2020-12-07 9:08 ` James Park
2020-12-07 10:35 ` Pekka Paalanen
2020-12-07 10:44 ` Pekka Paalanen
2020-12-07 10:47 ` Simon Ser
2020-12-07 10:49 ` James Park
2020-12-07 10:53 ` Simon Ser
2020-12-07 11:01 ` James Park
2020-12-07 11:14 ` Pekka Paalanen
2020-12-08 1:08 ` James Park
2021-08-17 17:21 ` Jason Ekstrand
2020-12-07 9:48 ` Simon Ser
2020-12-07 10:00 ` James Park
2020-12-07 10:02 ` Simon Ser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABjik9cWPVFXG6ctb=j3L296fB9xXYQK9JiN29wWLTVmvDsYFw@mail.gmail.com' \
--to=james.park@lagfreegames.com \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=jpark37@lagfreegames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.