From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B458C4167B for ; Tue, 8 Dec 2020 08:32:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49E2123A7D for ; Tue, 8 Dec 2020 08:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49E2123A7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lagfreegames.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B6976E977; Tue, 8 Dec 2020 08:32:19 +0000 (UTC) Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF02D89D66 for ; Mon, 7 Dec 2020 10:05:23 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id cw27so13063501edb.5 for ; Mon, 07 Dec 2020 02:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lagfreegames.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bDqs8unLqUQBle12hG2fZgMAnT4IQ2t1ZL0W4qAaIjU=; b=DjNlwraTdrC6aMTyoaa+aDktjNVBYbzEFa+X7FOVTwJNrgEW8p7AsEN5NuyiTa942e Ra6EG350cnKAfWF2J+wvv0/C0Rr41JfcWllIwa003oyGMzJ54+m6hDpglSILmxmxQku8 +K2Ga/v+gjs18x8zBL+9+4JxbixyycYTlqLH6wyb4yQwGW0q/Xc8CZ0uPQ72yl1sRxeP JUQm3DsCuoA6rdbtzUeUIsBJE4dzTg4YN7KDuxS7gtdBFCpaYObPubnM8oXO4FwEYSdr bTmra2uZ1hsQ8m0DnkpWVqKpncPtadyBwJsuyNrovQOdw1CJwinGbD9iE/TW3uzsfDvg Z3UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bDqs8unLqUQBle12hG2fZgMAnT4IQ2t1ZL0W4qAaIjU=; b=EVGMZOBWdEAmRGQd2OrYM97uWU77Ahb3n03cbb+GPGOhO2EgoJSodXqJDW4ccIm0rj AevtcKKDHlInAx/HK13XLM5nhV+VdZ1b4Stz/WhxiadXQYvDMQJ+Um6TK7/I2lYAnyyR iImFrzqe+npyVPC5dyTdo/n/xbo2yiRkQ2VU6w/3KG8cdbagG2hzSb5Y87vkjMZz6d44 AFaijiBf1ID7dSIyBnlcestG0SoL2PyOfly5SrdXhxi4SrGzklltbFa46+CP/SDV7e1q xISNkc3CrgesJE15n4tS7JPxh9cs7d0Kfj1MBUNamjGlGob+cNsum+uyw3Shlgo11IxE nPhw== X-Gm-Message-State: AOAM532DO3pzxNAj8Y5x012h9KIL+GCslLSSQh0oKwPlGaAg167yruSe Olm+N0czS/WG3sXQCQmrmg3bkIjmYN6DMGu10ImESA== X-Google-Smtp-Source: ABdhPJybOjWcZFuQlJoclrltcHsYjSinmSYknKyo7h23Zu5W3WV9FwBY9ILLRWlaG6hrdJM7hxLmjSG7tU5ZBJu/gYY= X-Received: by 2002:a50:d2c8:: with SMTP id q8mr18303584edg.375.1607335522608; Mon, 07 Dec 2020 02:05:22 -0800 (PST) MIME-Version: 1.0 References: <1607215171-36-1-git-send-email-jpark37@lagfreegames.com> <1607215171-36-2-git-send-email-jpark37@lagfreegames.com> In-Reply-To: From: James Park Date: Mon, 7 Dec 2020 02:05:09 -0800 Message-ID: Subject: Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE To: Simon Ser X-Mailman-Approved-At: Tue, 08 Dec 2020 08:32:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel , James Park Content-Type: multipart/mixed; boundary="===============0822469974==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0822469974== Content-Type: multipart/alternative; boundary="000000000000dc33c305b5dcf67a" --000000000000dc33c305b5dcf67a Content-Type: text/plain; charset="UTF-8" The original code blocks in drm.h look identical to me. I see: #include #include typedef unsigned int drm_handle_t; Good point about drm_basic_types.h. I'll change it to say "Not Linux" after waiting a bit for more feedback. Thanks, James On Mon, Dec 7, 2020 at 1:59 AM Simon Ser wrote: > On Monday, December 7th, 2020 at 10:55 AM, James Park < > james.park@lagfreegames.com> wrote: > > > I'd noticed the #if could be combined, but they weren't in drm,h when > > they could have been, so I didn't want to depart from the existing > > pattern. > > I see. The original code really needed the two branches and > drm_basic_types.h doesn't. But let's see what others think. > > > I think "One of the BSDs" is more informative than "Not Linux" if > > that statement is still true. Given the aversion to making drm.h > > robust to Windows, I don't think we want to imply compatibility that > > isn't there. > > Well, drm_basic_types.h would be included on Windows as well from > drm_fourcc.h, right? > --000000000000dc33c305b5dcf67a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The original code blocks in drm.h look identical to m= e. I see:

#include <linux/types.h>
#inclu= de <asm/ioctl.h>
typedef unsigned int drm_handle_t;
=
Good point about drm_basic_types.h. I'll change it to say &qu= ot;Not Linux" after waiting a bit for more feedback.

Thanks,
James

On Mon, Dec 7, 2020 at 1:59 AM Simon Ser <= ;contact@emersion.fr> wrote:<= br>
On Monday, Decem= ber 7th, 2020 at 10:55 AM, James Park <james.park@lagfreegames.com> wrote:<= br>
> I'd noticed the #if could be combined, but they weren't in drm= ,h when
> they could have been, so I didn't want to depart from the existing=
> pattern.

I see. The original code really needed the two branches and
drm_basic_types.h doesn't. But let's see what others think.

> I think "One of the BSDs" is more informative than "Not= Linux" if
> that statement is still true. Given the aversion to making drm.h
> robust to Windows, I don't think we want to imply compatibility th= at
> isn't there.

Well, drm_basic_types.h would be included on Windows as well from
drm_fourcc.h, right?
--000000000000dc33c305b5dcf67a-- --===============0822469974== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0822469974==--