All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Park <james.park@lagfreegames.com>
To: Simon Ser <contact@emersion.fr>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard
Date: Wed, 3 Feb 2021 20:24:16 -0800	[thread overview]
Message-ID: <CABjik9dViqkQYixtfhZ+bNJjGWPcF=xCg4ptU3OjYeW-Xy42+g@mail.gmail.com> (raw)
In-Reply-To: <3YZGYeCokyp-fEABJS4acHkPKfFBiHtsL3lM8fRBI-ma8q--4afeisOnhmHURa5iF8AVHpUdw2E7fKCe5bug9PX4j8HJ4btFWDdWepXftBY=@emersion.fr>

Apologies for anything I've said so far that has been harsh. I'd like
this discussion to be civil.

I'm not sure if Simon is still on board with a patch given his thumbs
up to Erik's comment on the Mesa merge request (which I responded to),
but I would also like to know why adding another header file is
problematic. I would prefer to keep the definitions deduplicated and
make the code robust even for edge cases unless there's a good reason
not to. Avoiding an extra file doesn't seem like a good enough reason
to me, but I also don't have to maintain codebases that rely on these
headers, so maybe there's something I'm overlooking.

Thanks,
James

On Wed, Feb 3, 2021 at 6:21 AM Simon Ser <contact@emersion.fr> wrote:
>
> On Wednesday, February 3rd, 2021 at 3:13 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> > As said before, there are multiple ways to handle this without
> > introducing yet another UAPI header. I don't see why you're dismissing
> > all of them, can you elaborate?
>
> Because I hate it when I have to adjust my compiler flags because of
> some third-party header.
>
> Can you explain what were the past issues with introducing a new
> header?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-02-04  8:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 22:47 [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard Emil Velikov
2021-02-02 23:24 ` James Park
2021-02-03  0:56   ` Emil Velikov
2021-02-03  1:20     ` James Park
2021-02-03  9:24     ` Simon Ser
2021-02-03  9:27       ` Simon Ser
2021-02-03 10:08         ` Emil Velikov
2021-02-03 10:15           ` Simon Ser
2021-02-03 11:03             ` Emil Velikov
2021-02-03 13:47               ` Simon Ser
2021-02-03 14:13                 ` Emil Velikov
2021-02-03 14:20                   ` Simon Ser
2021-02-04  4:24                     ` James Park [this message]
2021-02-04  4:25                       ` James Park
2021-02-04 11:52                     ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABjik9dViqkQYixtfhZ+bNJjGWPcF=xCg4ptU3OjYeW-Xy42+g@mail.gmail.com' \
    --to=james.park@lagfreegames.com \
    --cc=contact@emersion.fr \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=pekka.paalanen@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.