From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11678C4338F for ; Fri, 20 Aug 2021 00:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB93F61053 for ; Fri, 20 Aug 2021 00:18:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237079AbhHTATV (ORCPT ); Thu, 19 Aug 2021 20:19:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234058AbhHTATN (ORCPT ); Thu, 19 Aug 2021 20:19:13 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C71DC061575 for ; Thu, 19 Aug 2021 17:18:35 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id m193so15551266ybf.9 for ; Thu, 19 Aug 2021 17:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HxqVyTwHe6/RPArmls1kDyHsamw5A75hUDWTGog34ak=; b=H8unLXT6f25qYtnNzgH+s0MZByT5XLjJI+h0JthIvCchv1BK79DZv1/926JwsFhuHj CUeXWYyUPAWxmeBT0gkP+Pbc8CM0FTIlHwpLVpiqn8V3y8S4dz6i2+Lyrj4C29EG2r0R +dtddq7SiKkmiy1PKXF+s+rCfcgDs76KgEtb6Bfd9ohg5yPjrBsGqzJFBP1hmp0bSPUs +ZohUlsUw7OAIGNBhkQWuzUcq6LHmSVFV0nmMKkYEwMe0gifLq/E5ixH1P++I9iBWL+p VcR6A6frB/uZCMAfvdLiH0KLxk4ugGSfKDQriL0tXbPtV+UdvRcTkGqBWDsR136waAHT VC0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HxqVyTwHe6/RPArmls1kDyHsamw5A75hUDWTGog34ak=; b=KJtLgwbZLZTKt0aEeWZclcFt2P2+JZgk27vBJlwtAsJegHbi3ln9Gu9HR0GkETPt+5 hUcjVXm5TDlTjJ/1c8cS3a+21Dv/3S433MDY6WSIenD6gRKyrrLuHPizRvL/QGbo4kNc aXzqH2Ho+3B65RNUfnm5Wt42EFBDtRmWG35b7L22z9+A/82wtWYVWfPhcpXFyXPGJMun /Wnug4nrxy9E97OW8H7PfkEBI+/1hGM4AKqGd7KUC/boHRDjsSjEP/GY2Vbdc2zzUWCI y/VqAipfU5dWKAaiw5047GwGJXQPDVunGvdo7xmUcBJ3MErF2StDQD9JywUEHDoAKprB 8eNw== X-Gm-Message-State: AOAM5339pRpaDbj6YJJaBQEFHIuvMpMzBgUotGh0fkgDMpbhKWIaQ4zl YOl6bTJ4xzIKwwjMNPZ/jWgOraS3jci0I9x+588U0A== X-Google-Smtp-Source: ABdhPJyGSqEnK739eYv9WH0HsV2wTQXq6ky87cnyy8U07pJujYILTRKzM95ReC7nt2L5zEfXroz3sdUDdQfrAHtsg+Q= X-Received: by 2002:a25:1506:: with SMTP id 6mr21318398ybv.153.1629418713639; Thu, 19 Aug 2021 17:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20210422120459.447350175@infradead.org> <20210422123309.039845339@infradead.org> <20210817151542.GA1665@asgard.redhat.com> <20210817231734.GA4449@asgard.redhat.com> In-Reply-To: From: Josh Don Date: Thu, 19 Aug 2021 17:18:22 -0700 Message-ID: Subject: Re: [PATCH] sched: Fix Core-wide rq->lock for uninitialized CPUs To: Peter Zijlstra Cc: Eugene Syromiatnikov , Joel Fernandes , "Hyser,Chris" , Ingo Molnar , Vincent Guittot , Valentin Schneider , Mel Gorman , linux-kernel , Thomas Gleixner , Christian Brauner , ldv@strace.io Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Thu, Aug 19, 2021 at 4:09 AM Peter Zijlstra wrote: > > - /* shared state */ > + /* shared state -- careful with sched_core_cpu_deactivate() */ Could also throw these fields into a wrapping struct. Either way seems fine. Reviewed-by: Josh Don