From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Riesch Date: Tue, 27 Sep 2011 10:37:33 +0200 Subject: [U-Boot] [PATCH 6/8] arm, davinci, am1808: add lowlevel functions for booting from NOR In-Reply-To: <4E817AF1.6090502@denx.de> References: <1316066380-7397-1-git-send-email-hs@denx.de> <1316066380-7397-7-git-send-email-hs@denx.de> <4E8037C8.5020905@denx.de> <4E817AF1.6090502@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Heiko, >> Which brings me to my next point: AFAIK Texas Instruments's AM18xx >> SoCs, their OMAP-L138, and their DA850 based devices basically differ >> only in the DSP/PRU part of the device. If you are (like in u-boot) >> only interested in the ARM part of chip, they are basically the same >> device. For some reason the Linux kernel and u-boot support for all >> these devices is labelled da850... Although I have no hardware to test >> it, I guess that your DDR memory controller initialization code could >> be used for the OMAP-L138 and the corresponding Davinci device as >> well. So since all code in u-boot for the entire device family is >> labelled da850... I guess your DDR initialization functions should get >> this prefix as well for consistency. Any comments from the >> maintainers/TI employees who know these devices better than I do? > > Yes of course, such a rename should be done, if somebody has tested it! I just wonder what is worse, having code in there that is labelled da850 but not tested on all devices of the family, or having it renamed every time someone finds out that it also runs on other devices. TI uses a common PLL initialization code in its User Boot Loader (UBL) for OMAP-L138, DA850, AM180x, so it should be pretty save to rename it right now. Did you also read the rest of my last email, the PSC part? Regards, Christian