All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Riesch <christian.riesch@omicron.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned (was: [PATCH] arm: fix a build error with CONFIG_USE_IRQ)
Date: Mon, 7 Jul 2014 10:55:46 +0200	[thread overview]
Message-ID: <CABkLObqiZ_mq2iCSonL7hoCGy4-VzeR4Go-7myrZz9KBJX9rGQ@mail.gmail.com> (raw)
In-Reply-To: <CABkLOboRaBojC9TRd3MDiky5x3WMzCQNibyu7XUAarRvt3tqXQ@mail.gmail.com>

Hi again,

On Mon, Jul 7, 2014 at 9:15 AM, Christian Riesch
<christian.riesch@omicron.at> wrote:
> [...] As a result, __image_copy_start points to
> 0x60000000 (CONFIG_SYS_TEXT_BASE) and _start points is 0x60000004. The
> relocation code in arch/arm/lib/relocate.S calculates its relocation
> offset based on __image_copy_start. However, arch/arm/lib/board.c
> calculates the offset as
>
> gd->reloc_off = addr - (ulong)&_start;

I just noticed that I did my test without CONFIG_SYS_GENERIC_BOARD.
Adding CONFIG_SYS_GENERIC_BOARD solves that problem, as the relocation
offset calculation in common/board_f.c is based on
CONFIG_SYS_TEXT_BASE.

So adding the missing #include in vectors.S and adding
CONFIG_SYS_GENERIC_BOARD (patch is already in u-boot-arm/master) fixes
the calimain board.

I'll post a patch for the missing include.

Christian

  reply	other threads:[~2014-07-07  8:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 10:43 [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ Masahiro Yamada
2014-06-09  7:14 ` Albert ARIBAUD
2014-06-09  7:36   ` Masahiro Yamada
2014-06-09  8:35     ` Albert ARIBAUD
2014-06-09  9:29       ` Masahiro Yamada
2014-06-09  9:42         ` Albert ARIBAUD
2014-06-09 11:19           ` Masahiro Yamada
2014-06-11  7:14         ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned (was: [PATCH] arm: fix a build error with CONFIG_USE_IRQ) Albert ARIBAUD
2014-06-11  7:47           ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned Heiko Schocher
2014-06-11 13:15             ` Christian Riesch
2014-06-12  8:05               ` Christian Riesch
2014-06-13  7:46           ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned (was: [PATCH] arm: fix a build error with CONFIG_USE_IRQ) Masahiro Yamada
2014-06-18 12:55           ` Christian Riesch
2014-06-18 13:08             ` Christian Riesch
2014-07-02 13:45             ` Christian Riesch
2014-07-04 20:35               ` Albert ARIBAUD
2014-07-07  7:15                 ` Christian Riesch
2014-07-07  8:55                   ` Christian Riesch [this message]
2014-06-09 11:18       ` [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABkLObqiZ_mq2iCSonL7hoCGy4-VzeR4Go-7myrZz9KBJX9rGQ@mail.gmail.com \
    --to=christian.riesch@omicron.at \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.