All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Baltieri <fabio.baltieri@gmail.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: linux-can@vger.kernel.org
Subject: Re: [RFC PATCH] can: add tx/rx led trigger support
Date: Wed, 11 Apr 2012 20:03:21 +0200	[thread overview]
Message-ID: <CABkP77dGxmcbPGJ8B9t1HN4nOOjrZLoc63UyQTO+dW7fS2WPKA@mail.gmail.com> (raw)
In-Reply-To: <2082927.TC8ExDXGjY@ws-stein>

On Wed, Apr 11, 2012 at 8:29 AM, Alexander Stein
<alexander.stein@systec-electronic.com> wrote:
> Am Dienstag, 10. April 2012, 23:39:25 schrieb Fabio Baltieri:
>> This patch adds two led triggers, named <ifname>-tx and <ifname>-rx to
>> each registered canbus interface.
>
> Does this mean, you can have either a tx or rx trigger, bot not both? The
> status LEDs I know from embedded system are triggered by both rx and tx.

That's a point... My idea was to have a tx AND rx trigger - independents.

I also saw adapters with separated tx/rx/error LEDs. Anyway, once the
system is in place, adding a new trigger for a slightly different
behavior - like combined tx/rx - should be easy.

> Despite that, nice idea.

Thanks.

Regards.

-- 
Fabio Baltieri

  reply	other threads:[~2012-04-11 18:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 21:39 [RFC PATCH] can: add tx/rx led trigger support Fabio Baltieri
2012-04-11  6:14 ` Oliver Hartkopp
2012-04-11 17:58   ` Fabio Baltieri
2012-04-11 18:29     ` Oliver Hartkopp
2012-04-11 18:58       ` Wolfgang Grandegger
2012-04-12  6:16         ` Oliver Hartkopp
2012-04-11 19:02     ` Oliver Hartkopp
2012-04-11 19:36       ` Fabio Baltieri
2012-04-12  6:05         ` Oliver Hartkopp
2012-04-12  6:32         ` Alexander Stein
2012-04-12 15:52           ` Oliver Hartkopp
2012-04-12 18:30             ` Fabio Baltieri
2012-04-13 19:00               ` Oliver Hartkopp
2012-04-12  7:37         ` Wolfgang Grandegger
2012-04-12 11:07           ` Martin Gysel
2012-04-12 16:02             ` Oliver Hartkopp
2012-04-12 16:13               ` Wolfgang Grandegger
2012-04-12 17:28                 ` Fabio Baltieri
2012-04-12 18:47                   ` Wolfgang Grandegger
2012-04-12 17:46           ` Fabio Baltieri
2012-04-12 18:53             ` Wolfgang Grandegger
2012-04-11  6:29 ` Alexander Stein
2012-04-11 18:03   ` Fabio Baltieri [this message]
2012-04-11 14:45 ` Wolfgang Grandegger
2012-04-11 16:24   ` Oliver Hartkopp
2012-04-11 19:11   ` Fabio Baltieri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABkP77dGxmcbPGJ8B9t1HN4nOOjrZLoc63UyQTO+dW7fS2WPKA@mail.gmail.com \
    --to=fabio.baltieri@gmail.com \
    --cc=alexander.stein@systec-electronic.com \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.