From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9D1C2D0E7 for ; Fri, 27 Mar 2020 00:13:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 312A620737 for ; Fri, 27 Mar 2020 00:13:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NF52MK0P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727705AbgC0ANu (ORCPT ); Thu, 26 Mar 2020 20:13:50 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35924 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgC0ANt (ORCPT ); Thu, 26 Mar 2020 20:13:49 -0400 Received: by mail-lj1-f196.google.com with SMTP id g12so8445424ljj.3 for ; Thu, 26 Mar 2020 17:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VWL8ZSPmJAiTPJ9JjQW1j0bE8X/JpNZikw6inrx3YQI=; b=NF52MK0PSlUZLDII9gyz0ifyNpp+j4BfKlYt4/XYvcsq/F4CYzlG/eu4r9j94+PpNJ hs97iUKCE+zNoq9ZfdDg26kpdiiEk3q5ik+SmcihoAeyK88CnY534dCGxNjVD5tyECex HKTILpbONOMGNIOIYyRDBDM7Fd7DDehT6OnDk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VWL8ZSPmJAiTPJ9JjQW1j0bE8X/JpNZikw6inrx3YQI=; b=V9Aad+FFmAmDYV1CW3oVmpjWLDgMBDSRt/DVC7ibhrvnAYeHYjahmqBJElgWQmR3ce aEydnMLE94SVkZbYGFvkTWPuTV1NtIltJvP/kLq1p/yUSeXUwh/CWQptBjk2Dh0ysQRT +WJT1aetFDvMC3chTlcAoivpQ/d20TDE1G5CKm0N9aWPy/e1RU9MWjcjg0cT8eVESVAX D29TahoY9HixeaGX/VLlw2L85p6K32sLlIeK4/JkPgQ6ta4HVBtDbYWPUIxMahvUmfgJ ssINuOIGUFQDy9D3n6BpQsH1aKbrpQbuXAZQBXqqGFQ78ns4P0VMECXiNpeNxLJRdouQ NrhA== X-Gm-Message-State: ANhLgQ1BrumiuYrTWSWR1/0JoKuA519Y0KceFAJ1gTiC92KiknkpwXhM I5D7TZQLVAkiaaFCxn3R3ee9hHxXMIadSnPqF6KNtw== X-Google-Smtp-Source: APiQypLZZN1Wtl3gwV5mELpsM2qhhqZ5leW/rlMatp78zM7+LnJ5TdE1codyNmtsIAOipZ4iyk3U+CiOz4xZhRZZUog= X-Received: by 2002:a2e:83cf:: with SMTP id s15mr6529050ljh.36.1585268027186; Thu, 26 Mar 2020 17:13:47 -0700 (PDT) MIME-Version: 1.0 References: <20200326075938.65053-1-mcchou@chromium.org> <20200326005931.v3.1.I0e975833a6789e8acc74be7756cd54afde6ba98c@changeid> In-Reply-To: From: Miao-chen Chou Date: Thu, 26 Mar 2020 17:13:36 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] Bluetooth: btusb: Indicate Microsoft vendor extension for Intel 9460/9560 and 9160/9260 To: Marcel Holtmann Cc: Bluetooth Kernel Mailing List , Alain Michaud , Luiz Augusto von Dentz , "David S. Miller" , Jakub Kicinski , Johan Hedberg , LKML , netdev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2020 at 2:01 AM Marcel Holtmann wrote: > > Hi Miao-chen, > > > This adds a bit mask of driver_info for Microsoft vendor extension and > > indicates the support for Intel 9460/9560 and 9160/9260. See > > https://docs.microsoft.com/en-us/windows-hardware/drivers/bluetooth/ > > microsoft-defined-bluetooth-hci-commands-and-events for more information > > about the extension. This was verified with Intel ThunderPeak BT controller > > where msft_vnd_ext_opcode is 0xFC1E. > > > > Signed-off-by: Miao-chen Chou > > --- > > > > Changes in v3: > > - Create net/bluetooth/msft.c with struct msft_vnd_ext defined internally > > and change the hdev->msft_ext field to void*. > > - Define and expose msft_vnd_ext_set_opcode() for btusb use. > > - Init hdev->msft_ext in hci_alloc_dev() and deinit it in hci_free_dev(). > > so I spent some cycles on thinking about on how we can have this nice and cleanly without putting too much into the core stack or hci_dev. I took your patches and converted them a little bit into how I would do it. Please have a look. Thanks for brainstorming the framework. I will address your suggestion in v4 shortly. Regards, Miao