All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Leigh <pete.leigh@gmail.com>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: Fwd: Support for Roland VG-99 (working code, but could use help)
Date: Fri, 19 Oct 2012 19:18:49 +0100	[thread overview]
Message-ID: <CABn3OEHmJqtkkKz1TeLh_Q52meUkuzKYnp8sTH5LtSjMG73sCg@mail.gmail.com> (raw)
In-Reply-To: <508191DF.2060802@gmail.com>

Hi Daniel

On 19 October 2012 18:46, Daniel Mack <zonque@gmail.com> wrote:
> On 19.10.2012 19:02, Pete Leigh wrote:

>> I quickly tested the VG-99 quirk (modified as per Clemens' suggestion)
>> and that works too, so I'll work on generating a patch as per the
>> instructions on alsa-project.org.

Actually, I'm struggling a bit with this. I'm guessing
(alsa-project.org doesn't seem to say...) that you need to check out
the release branch in alsa-driver to work on, and do your commit
against that (master branch contains only a README) but the wiki also
advises to do a rebase origin/master after your commit. It seemed
weird, but I tried it, to no useful effect of course.

As a relative novice, this is pretty confusing stuff. Is there a plain
step-by-step of the procedure to generate a patch? Would  it be
acceptable to send the patch against the sound.git tree?

>> If it's any use regarding the urb 0 -ENOSPACE error I was having,  I
>> can try and track down the config item difference that makes it work,
>> or provide the config files for you to look at.. Please let me know if
>> this would be useful.
>
> Absolutely, that would be great. We keep getting reports from users that
> see this since the driver was reworked, and I still haven't got my head
> around what really causes it. And none of my machines show the error
> yet, so it's really hard to track. If you would point me to any specific
> config option that reproducibly changes the behaviour, that would be of
> great help.
>
>> Should there be some dependency in the configs so that whatever item
>> is making the difference is enabled by selecting SND_USB_AUDIO ?
>
> No, it's really just a bug that must be fixed.

Ok, I'll try narrowing down the config differences. It might take a
while, though:

$ diff ~/3.7.working.config ~/broken.config | grep -v '#' | wc -l
$ 1001

Cheers,

- Pete.

  reply	other threads:[~2012-10-19 18:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CABn3OEFatrnhGs1xzpmOfXSxpSLuGwgRtN8v=1B96i6=7_9vTg@mail.gmail.com>
2012-10-15 23:59 ` Fwd: Support for Roland VG-99 (working code, but could use help) Pete Leigh
2012-10-16  7:40   ` Daniel Mack
2012-10-16  8:31     ` Pete Leigh
2012-10-16  8:36       ` Daniel Mack
2012-10-18 23:38         ` Pete Leigh
2012-10-19  7:45           ` Daniel Mack
2012-10-19  8:23             ` Pete Leigh
2012-10-19  8:24               ` Daniel Mack
2012-10-19  8:49                 ` Pete Leigh
2012-10-19 17:02                   ` Pete Leigh
2012-10-19 17:46                     ` Daniel Mack
2012-10-19 18:18                       ` Pete Leigh [this message]
2012-10-19 18:21                         ` Daniel Mack
2012-10-19 22:24                       ` Pete Leigh
2012-10-20  0:17                         ` Pete Leigh
2012-10-20  2:21                           ` Pete Leigh
2012-10-16  9:19       ` Clemens Ladisch
2012-10-16 11:38         ` Pete Leigh
2012-10-16 12:27           ` Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABn3OEHmJqtkkKz1TeLh_Q52meUkuzKYnp8sTH5LtSjMG73sCg@mail.gmail.com \
    --to=pete.leigh@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.