From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A57C433F5 for ; Mon, 3 Oct 2022 15:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbiJCP3p (ORCPT ); Mon, 3 Oct 2022 11:29:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbiJCP3l (ORCPT ); Mon, 3 Oct 2022 11:29:41 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C84CDC20 for ; Mon, 3 Oct 2022 08:29:37 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id x32-20020a17090a38a300b00209dced49cfso7686377pjb.0 for ; Mon, 03 Oct 2022 08:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=faryKYuRlup1uNl841W9tCsnXKY4x5ZzddcOLsdf9HkC6Bzo24TLmqkXIRjeolgwQ0 uVnITeO5OeSznTxdOXLjya60IB11c2j9MAUPdCKbidhkfkEvpXdE+JKkOxObngvaMZ34 YQ52qsWDGO9ZLcU4KgbMShdKMGgc4RGVjpSgkdbTzHE2GjrWygu3wygkpENNPhlESvp0 y9fw6suGV2xOkH7lz62ZnfHklPnDTChe4P3JzhwayXA4BdsYg/7iJclyFl/JhkLgIhLj lJxHANwUI/go2VxU7IzU6jQR9FR3g59ID9r9gsFpVg4q0OChrT7Dtkg4IV3dgGbRSAD3 mRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=osqKftceMO5QwsqvL4Wif72qRTKx0mvVSNRPcfp0n37UujOYSrJUWse8InxNSjYdZc n4O4Y9bzH0RH9yaDer5vahChiO7Hhl3AR96KVP6G6zrjkv0H9WMBP27FKQP9WFdoRN3s ATX1hT3zSPfx7YR8NhyGQYlIITDNtHXwzfQWSCzwE3jXlO2Dizo36Ou5c9yPLYkilOcu 8gsxYa8gdyeEx5OZS8R9gNMew/J2iIs83vin2ZS1trnUwV5EjoqxOE4PX78dZaAMt9HT wDZvmqNuwp+Eb2wjD5T2uiWeiTgMjfsOb3Jd7ibrNQI+aZxbaN3tWvzyjhU/UMzhuBwq NNNA== X-Gm-Message-State: ACrzQf3Cr1612cpqtYo57RHHvFeCfeixh1ediLicu5tubM+a2KmIZJyK ZiBGLHmIpuCDKT4CeRlvVVAxQtyRJqlS4QCRgzzq5w== X-Google-Smtp-Source: AMsMyM44/4lmkJnwlFZ4jkHjH1tzKco6W1np3dHDWnE8gN2xk1BxjeMb6W4Zs9wA7u4Wlvz1r9guvdbO7Gov4Hza580= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr23009123plo.112.1664810976929; Mon, 03 Oct 2022 08:29:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Oct 2022 17:29:36 +0200 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Mon, 3 Oct 2022 17:29:36 +0200 Message-ID: Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv To: Krzysztof Kozlowski , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski wrote: >On 27/09/2022 15:04, Guillaume Ranquet wrote: >> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >> wrote: >>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>> Add dpi support to enable the HDMI path. >>>> >>>> Signed-off-by: Guillaume Ranquet >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> index 72049a530ae1..27f029ca760b 100644 >>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>> .data = (void *)MTK_DPI }, >>>> { .compatible = "mediatek,mt8192-dpi", >>>> .data = (void *)MTK_DPI }, >>>> + { .compatible = "mediatek,mt8195-dpi", >>>> + .data = (void *)MTK_DPI }, >>> >>> It's compatible with the others. You don't need more compatibles. >> >> Hi Krzysztof, >> >> It's a bit confusing, because this compatible is used in both >> mtk_drm_drv.c and in mtk_dpi.c >> >> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >> it's pretty different >> regarding the mtk_dpi module. > >Sure, but this does not explain why do you need these entries here in >mtk_drm_drv. > >Best regards, >Krzysztof > Hi Krzysztof, Sorry for the late answer. The mtk_drm_drv is the component master of the full mediatek drm stack. it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. That mtk_ddp_comp_dt_ids array is iterated over to find all of the components from the device tree. Hope this clarifies things? Thx, Guillaume. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3574C433FE for ; Mon, 3 Oct 2022 15:29:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BFF7110E3F7; Mon, 3 Oct 2022 15:29:40 +0000 (UTC) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by gabe.freedesktop.org (Postfix) with ESMTPS id A91D510E3F8 for ; Mon, 3 Oct 2022 15:29:37 +0000 (UTC) Received: by mail-pj1-x1029.google.com with SMTP id o59-20020a17090a0a4100b0020a6d5803dfso5460253pjo.4 for ; Mon, 03 Oct 2022 08:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=faryKYuRlup1uNl841W9tCsnXKY4x5ZzddcOLsdf9HkC6Bzo24TLmqkXIRjeolgwQ0 uVnITeO5OeSznTxdOXLjya60IB11c2j9MAUPdCKbidhkfkEvpXdE+JKkOxObngvaMZ34 YQ52qsWDGO9ZLcU4KgbMShdKMGgc4RGVjpSgkdbTzHE2GjrWygu3wygkpENNPhlESvp0 y9fw6suGV2xOkH7lz62ZnfHklPnDTChe4P3JzhwayXA4BdsYg/7iJclyFl/JhkLgIhLj lJxHANwUI/go2VxU7IzU6jQR9FR3g59ID9r9gsFpVg4q0OChrT7Dtkg4IV3dgGbRSAD3 mRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=Cw+S8xy9k6MuGJ3Pquvx49951OnbgIM2TY/iZkddN7tkXI58wzY1y/SLtjoz5IbPy7 7t4mxjlMiPgcZlAOHbRCNuNB0upP1wtKbhtmVy5Jia4XT+C5GfGCrWP2w+1pukQ/ynNv kXJ0DyYLcwKAytNKYqsZt9dEeEmq48fqI1z64ruij52P9SdSaOzwhN2/nnogPP1ydSA1 cUrgynd4vOYtZ0b2lVN2r0WU6RtpJr+vfih7E4nA6607sTyyPYivs6CmkkO9PqVpJYKH ZSF1mF1myKAmEmlQrOIJtnGCv/Hz8MieWf7TTO3EEz+LcbCvLd9kZKrL1d3SsYoFuA/+ Qtpg== X-Gm-Message-State: ACrzQf0is/2pqqgMpBnWzsufwz2ie8Y2a0tY3sdZA/TEhLLOj5lNESQJ P1nRHj/hvP0VDE7HpP4ZNhOMmyLu1Fhq1VPbrXj+LA== X-Google-Smtp-Source: AMsMyM44/4lmkJnwlFZ4jkHjH1tzKco6W1np3dHDWnE8gN2xk1BxjeMb6W4Zs9wA7u4Wlvz1r9guvdbO7Gov4Hza580= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr23009123plo.112.1664810976929; Mon, 03 Oct 2022 08:29:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Oct 2022 17:29:36 +0200 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Mon, 3 Oct 2022 17:29:36 +0200 Message-ID: Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv To: Krzysztof Kozlowski , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski wrote: >On 27/09/2022 15:04, Guillaume Ranquet wrote: >> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >> wrote: >>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>> Add dpi support to enable the HDMI path. >>>> >>>> Signed-off-by: Guillaume Ranquet >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> index 72049a530ae1..27f029ca760b 100644 >>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>> .data = (void *)MTK_DPI }, >>>> { .compatible = "mediatek,mt8192-dpi", >>>> .data = (void *)MTK_DPI }, >>>> + { .compatible = "mediatek,mt8195-dpi", >>>> + .data = (void *)MTK_DPI }, >>> >>> It's compatible with the others. You don't need more compatibles. >> >> Hi Krzysztof, >> >> It's a bit confusing, because this compatible is used in both >> mtk_drm_drv.c and in mtk_dpi.c >> >> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >> it's pretty different >> regarding the mtk_dpi module. > >Sure, but this does not explain why do you need these entries here in >mtk_drm_drv. > >Best regards, >Krzysztof > Hi Krzysztof, Sorry for the late answer. The mtk_drm_drv is the component master of the full mediatek drm stack. it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. That mtk_ddp_comp_dt_ids array is iterated over to find all of the components from the device tree. Hope this clarifies things? Thx, Guillaume. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E652DC433F5 for ; Mon, 3 Oct 2022 15:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=NPSaytQ41625nWacdPccGEjJy97A3zswqS8nfRsCm18=; b=eVe4djv50RfbHkw7TEm+x9mupk XtfvXZMCdO7HxM9G+kKg3LeIvWtAzw2qJXkoQ2MfL0RqX6jdR25dFmfiUFKtvHi+2AQlNdIouYS4e CzO9oCQp9AteIMIbX7KAiDAjPhZGShvKK9W5bxz+KxKXmfmB5R6B/UoqiZW01NnsxhIHYt2DSGk26 Yh8O1DwKoKyi+Oq1b22ND0LS7J8XydLaI6Xx0jndlQIRCR2O6XX81abFTWbik7Lo7XCJFxHAqrCGQ zMJ6ahdAV5jiYjW5+cIgm8lNMl1KQONoT1wvlTWRiYvLCvvxBXcJIpBJKRkDUI9/GqYM5NIad36sx y2He6tFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofNOG-006Sje-AZ; Mon, 03 Oct 2022 15:29:56 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofNO2-006Sdz-80 for linux-phy@lists.infradead.org; Mon, 03 Oct 2022 15:29:45 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 70so10190917pjo.4 for ; Mon, 03 Oct 2022 08:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=faryKYuRlup1uNl841W9tCsnXKY4x5ZzddcOLsdf9HkC6Bzo24TLmqkXIRjeolgwQ0 uVnITeO5OeSznTxdOXLjya60IB11c2j9MAUPdCKbidhkfkEvpXdE+JKkOxObngvaMZ34 YQ52qsWDGO9ZLcU4KgbMShdKMGgc4RGVjpSgkdbTzHE2GjrWygu3wygkpENNPhlESvp0 y9fw6suGV2xOkH7lz62ZnfHklPnDTChe4P3JzhwayXA4BdsYg/7iJclyFl/JhkLgIhLj lJxHANwUI/go2VxU7IzU6jQR9FR3g59ID9r9gsFpVg4q0OChrT7Dtkg4IV3dgGbRSAD3 mRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=rdXJmmIKSbh7Q3xSlbv5RSe53y21/PJqQwklA5QtqzcEyAhQe34wZh3LwQ22/MkBDD 6MFGy4+q4fIdXuhqVaViU9Ika+NWmF0KyLG3WPDdj2wDq2RPLjyR3zMPcIOOSuei1cVv 6+EyaWTz5dtM5kJqv5AEKg0X0RWJp7ThrNuA/V/MJGsolceGZwXp1XufXCkDXcYvVi3c TeOCl5k6g69gu+bFMBr9YAdTx6xWiJ8eu/KjZhzu0IOg17VUWUwolKN/r7nIg8RqWAW7 EvEYfNyXMfNFEfY2VEGet8HD1bbZ6ZPNl11Anb9vpFJtNkvKdQuu6sp72yUQa5/RvOfo Hv4w== X-Gm-Message-State: ACrzQf0K4bpbwVtmvRBtntA+YrH568yb7JaZyJ1sN8Ivq8BiviIkU/D3 tRvRAhNH+sK/RyVY2RErSbzD/2W0ftD1ma6FGJ2+aA== X-Google-Smtp-Source: AMsMyM44/4lmkJnwlFZ4jkHjH1tzKco6W1np3dHDWnE8gN2xk1BxjeMb6W4Zs9wA7u4Wlvz1r9guvdbO7Gov4Hza580= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr23009123plo.112.1664810976929; Mon, 03 Oct 2022 08:29:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Oct 2022 17:29:36 +0200 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Mon, 3 Oct 2022 17:29:36 +0200 Message-ID: Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv To: Krzysztof Kozlowski , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_082942_289947_EE6BF849 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski wrote: >On 27/09/2022 15:04, Guillaume Ranquet wrote: >> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >> wrote: >>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>> Add dpi support to enable the HDMI path. >>>> >>>> Signed-off-by: Guillaume Ranquet >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> index 72049a530ae1..27f029ca760b 100644 >>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>> .data = (void *)MTK_DPI }, >>>> { .compatible = "mediatek,mt8192-dpi", >>>> .data = (void *)MTK_DPI }, >>>> + { .compatible = "mediatek,mt8195-dpi", >>>> + .data = (void *)MTK_DPI }, >>> >>> It's compatible with the others. You don't need more compatibles. >> >> Hi Krzysztof, >> >> It's a bit confusing, because this compatible is used in both >> mtk_drm_drv.c and in mtk_dpi.c >> >> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >> it's pretty different >> regarding the mtk_dpi module. > >Sure, but this does not explain why do you need these entries here in >mtk_drm_drv. > >Best regards, >Krzysztof > Hi Krzysztof, Sorry for the late answer. The mtk_drm_drv is the component master of the full mediatek drm stack. it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. That mtk_ddp_comp_dt_ids array is iterated over to find all of the components from the device tree. Hope this clarifies things? Thx, Guillaume. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53E0EC433FE for ; Mon, 3 Oct 2022 15:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=i6vwuFKp0bhmpbk0w9CxJVvdq/OgLN1TeQqiG+WQgSc=; b=HnVrH1SFjFUdFMg+ZYwUnp6aKA BT3z7j0VbNHa6oINetHt1TE78bsPGF8OqNnvzm/XnIJJ0n70MFBL3dD3yGTZy3fOrAO4hDgevcGM6 q1hUZL3yNzqVc0wMoeDAOSQHz7MiCH8Poi8maqa1XfqUuwfwtKLP+s4Y8/Hi2QUb+Y/OLQhDSwLyi CoTCA0v2jsFzH64SWxgyK4GNH3fetrtRQUbQmseOaz3pwzuTP0tspX1ty5j3HRIRKIAWFWO1YoSgY CwkkSe1WZKr7p4k+UaE/99bcWZa1ytq01qSMaxcVvsRaNBIYz31+ryHX9SqTueHwjup3ExL2C5Bg3 g+V/8hag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofNO5-006Sg7-5G; Mon, 03 Oct 2022 15:29:45 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofNO1-006Se0-UN for linux-arm-kernel@lists.infradead.org; Mon, 03 Oct 2022 15:29:43 +0000 Received: by mail-pj1-x102b.google.com with SMTP id o59-20020a17090a0a4100b0020a6d5803dfso5460254pjo.4 for ; Mon, 03 Oct 2022 08:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=faryKYuRlup1uNl841W9tCsnXKY4x5ZzddcOLsdf9HkC6Bzo24TLmqkXIRjeolgwQ0 uVnITeO5OeSznTxdOXLjya60IB11c2j9MAUPdCKbidhkfkEvpXdE+JKkOxObngvaMZ34 YQ52qsWDGO9ZLcU4KgbMShdKMGgc4RGVjpSgkdbTzHE2GjrWygu3wygkpENNPhlESvp0 y9fw6suGV2xOkH7lz62ZnfHklPnDTChe4P3JzhwayXA4BdsYg/7iJclyFl/JhkLgIhLj lJxHANwUI/go2VxU7IzU6jQR9FR3g59ID9r9gsFpVg4q0OChrT7Dtkg4IV3dgGbRSAD3 mRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=BuEmPyN4Ez4NmzzutnovdwGSEF1vNe6R6TiRpHW5ogY=; b=VwE65bczo4TpNoD1dhYQ940PqtOpcczhje6BXl4byoamXlkKCt3jVReSzgsb5CFF4m qgctts4h/XTspy0MXWFLIM1zKH+Cxaf9iTTdYeb8/6a761HpTItXCQdXEDqK9xrAi/ja HsghQYgKNTfnsNfuobxJ0yOUA/6yqaktlTnAnLP+VlLe4nbXKNy9ivnNeOLyGOzyU/5M LeLmoQ2nIfdIQdypzb+wkriHLbePOkBLUR2koev39ycY0D3V6rmwDZKbPUdp55aB+LoW KlHUv77Hin1WJnYJ1gr7bzoWZAxisF4JRKlcyR84+rw+29z/P2mLqZ13rnNKlC1AKPdR JURQ== X-Gm-Message-State: ACrzQf0ugGdZDdaPizr418ToBcCwjo1gwyyGVq0WxQpgex9aRu9F/w3l NH/rMdD3id3unmpADDuL/nsDG4Xh4VjdsSgyKfnabQ== X-Google-Smtp-Source: AMsMyM44/4lmkJnwlFZ4jkHjH1tzKco6W1np3dHDWnE8gN2xk1BxjeMb6W4Zs9wA7u4Wlvz1r9guvdbO7Gov4Hza580= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr23009123plo.112.1664810976929; Mon, 03 Oct 2022 08:29:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Oct 2022 17:29:36 +0200 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Mon, 3 Oct 2022 17:29:36 +0200 Message-ID: Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv To: Krzysztof Kozlowski , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_082941_985618_A688E342 X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski wrote: >On 27/09/2022 15:04, Guillaume Ranquet wrote: >> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >> wrote: >>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>> Add dpi support to enable the HDMI path. >>>> >>>> Signed-off-by: Guillaume Ranquet >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> index 72049a530ae1..27f029ca760b 100644 >>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>> .data = (void *)MTK_DPI }, >>>> { .compatible = "mediatek,mt8192-dpi", >>>> .data = (void *)MTK_DPI }, >>>> + { .compatible = "mediatek,mt8195-dpi", >>>> + .data = (void *)MTK_DPI }, >>> >>> It's compatible with the others. You don't need more compatibles. >> >> Hi Krzysztof, >> >> It's a bit confusing, because this compatible is used in both >> mtk_drm_drv.c and in mtk_dpi.c >> >> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >> it's pretty different >> regarding the mtk_dpi module. > >Sure, but this does not explain why do you need these entries here in >mtk_drm_drv. > >Best regards, >Krzysztof > Hi Krzysztof, Sorry for the late answer. The mtk_drm_drv is the component master of the full mediatek drm stack. it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. That mtk_ddp_comp_dt_ids array is iterated over to find all of the components from the device tree. Hope this clarifies things? Thx, Guillaume. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel