From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88377C433F5 for ; Tue, 12 Apr 2022 08:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+TF7O/W8WOUdJ1bAlrba3v6uIoAc37zB7aoUL+VwMI8=; b=Xy5H67ESVnOSesVIP+yP9Duaez 5GM5h52EzOAF4o2n2RauB5zy4sAtjRdG1L1+YdpJlmrx0ZixAF6MLkG+Roy4pGAmZ8+PzD3rs+hI4 MiP2YZEixB8tXW58I248c2RIA6GylqJCIQNl4QX/mXDcPLYyjfjOYuBKlnlMUG1s9rclt85fUpxPr ylr6aVewFpj20RReWicrtja10WSolX3GZGnK2vOFjI/NvUn36Zw+HjCTPx3zmMk6FMOkLAaaHvREB 76K4sjtn39UylaIQ0NcUxFZpAFkffzRqMjy/38SJFgE2//N3jA92NI0TXXr4bnv7QTgoVY13rZrl9 m5XWGfhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCMz-00CkBB-GD; Tue, 12 Apr 2022 08:59:29 +0000 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCMd-00Cjzc-50 for linux-mediatek@lists.infradead.org; Tue, 12 Apr 2022 08:59:09 +0000 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-deb9295679so20117025fac.6 for ; Tue, 12 Apr 2022 01:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=i+E8+24eJSPuwFpWwnhwRcMosCQtTEQoU0qVumPFd1B/5vOrb43OnnM06scRAF73Yq oMByED8vyfj7h/juyKz0L3ed4WqHpCgSlskOcx+kVCwtlWgCiSRQA57g1AuGyhRftLkn PMcblX+TbX+MHeKj3cpATLc7zfvBTrR1JonUwOgFtW9kUMKobrEyLRFKbEi6WgtAtS6n FCB8ilN1nAxUZedW0P+Azc/J+6dpMpBO/s4qN2MMBBKOQNBC+cNRVDAa2Xi5cUNXXxIm UJfzvicRT62Wq64zodMNVExN+Gzy0MnFtlZGEVwjmhUqQKDk5bd3GuHqulcLVnv1AYsL SMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=dfPdzabZV3MQ/6GZCUJPnN9oQt5sTLAHZTR+ZyVQwBhNqh+9YEzr+w3oLQvFcGrZ2w VgAAf08g+JsWw2uZ9VaReEumH7GBwRsq9GJEmJew7H/0wVV+7BXeYO1FoXpLNBHJquK3 RqyLn5r0THN3rsW3QdR5TPDHj0awmTj7HdTLGoaLN98oycjBbvZLBNNc/QrDM/DSFqec Fsy3j44K3G6ObX1uCA8QLg8xfiC5SwqCeQVZpy1uSXwiGbtZ9rh+nhjar+wwKnuPRAih ThAfYjYl0oi/figRk7/zmJd7W4uq/5eDcAQJYF1dhqYpceXCvo6kmoy0ty6qpe2fe8AU WOZA== X-Gm-Message-State: AOAM531PULV9GW+xtvkk29ivUoIwYPyKcnhUVXRnAuzbldz699bctIHt NZqbUZVn8LK+QJgfDGixUwTBQCi8BmtMCyHgFVeKew== X-Google-Smtp-Source: ABdhPJzgcHEvPZCp6gdbg7kDhJKlxditkMSAtxr85wga0tldVXhcDC3GVMdHj7CuZ6MWQrtRrZ1EySnMvRiS1vE8OqA= X-Received: by 2002:a05:6870:f21a:b0:dd:9bec:caf8 with SMTP id t26-20020a056870f21a00b000dd9beccaf8mr1592268oao.78.1649753944968; Tue, 12 Apr 2022 01:59:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:59:04 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> <33212024-ae93-32c3-7890-09006057ff49@collabora.com> In-Reply-To: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:59:04 -0700 Message-ID: Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_015907_245776_599B5826 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 28 Mar 2022 10:09, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> From: Markus Schneider-Pargmann >> >> Similar to HDMI, DP uses audio infoframes as well which are structured >> very similar to the HDMI ones. >> >> This patch adds a helper function to pack the HDMI audio infoframe for >> DP, called hdmi_audio_infoframe_pack_for_dp(). >> hdmi_audio_infoframe_pack_only() is split into two parts. One of them >> packs the payload only and can be used for HDMI and DP. >> >> Signed-off-by: Markus Schneider-Pargmann >> Signed-off-by: Guillaume Ranquet >> --- >> drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- >> include/drm/dp/drm_dp_helper.h | 2 + >> include/linux/hdmi.h | 7 ++- >> 3 files changed, 71 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c >> index 947be761dfa4..5f50237554ed 100644 >> --- a/drivers/video/hdmi.c >> +++ b/drivers/video/hdmi.c >> @@ -21,6 +21,7 @@ >> * DEALINGS IN THE SOFTWARE. >> */ >> >> +#include >> #include >> #include >> #include >> @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr >> * >> * Returns 0 on success or a negative error code on failure. >> */ >> -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) >> +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) > >I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, >but you really should mention that you're constifying this one in your commit >description, or do that in a separate commit. > >Either of the two is fine. > >Regards, >Angelo Noted, I'll add it to the commit message. Thx, Guillaume. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C452BC433FE for ; Tue, 12 Apr 2022 08:59:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EEB8D10FB97; Tue, 12 Apr 2022 08:59:06 +0000 (UTC) Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC12C10EA07 for ; Tue, 12 Apr 2022 08:59:05 +0000 (UTC) Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-de3eda6b5dso20164157fac.0 for ; Tue, 12 Apr 2022 01:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=i+E8+24eJSPuwFpWwnhwRcMosCQtTEQoU0qVumPFd1B/5vOrb43OnnM06scRAF73Yq oMByED8vyfj7h/juyKz0L3ed4WqHpCgSlskOcx+kVCwtlWgCiSRQA57g1AuGyhRftLkn PMcblX+TbX+MHeKj3cpATLc7zfvBTrR1JonUwOgFtW9kUMKobrEyLRFKbEi6WgtAtS6n FCB8ilN1nAxUZedW0P+Azc/J+6dpMpBO/s4qN2MMBBKOQNBC+cNRVDAa2Xi5cUNXXxIm UJfzvicRT62Wq64zodMNVExN+Gzy0MnFtlZGEVwjmhUqQKDk5bd3GuHqulcLVnv1AYsL SMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=J2HM97opxdISBShJN1HPtYxUZRCH2nMaqrl5mUVgAqnWz0/mfUg0aRk9KO7b85BdOU FmsZaCqnNDdfVTSSR00gazuNJZP391yEcC0+QEDljQgHwRSbP3HiWh13aR+cA+5Ebx3l g/EE4RAED9OPuUBaXU4fDe9bAsfzuZihOlCQVEjqIo32z6S7f6w0Zz9lhsN/jdljv+wK gGZF2S0qQ4VEis1zeInU1Ik/A5nT0OaYTB9YZvxTGml4LvVudpUkU1N3YFjcxHlYqUNZ cF/B/DWZEj04P/xQ8YoQgo/vRAAIf0dhhzNzXDfpoZ2EoPW+UgJFX/sYWvb+RRrc8kxY hiwA== X-Gm-Message-State: AOAM530PDkWVYUbV3yYPgz2PAtO2E9YhHnXYlqH0y9ssAOktFUrs+iU8 Iv6wFhvIOABR0dgDoipo68ZiJuhQgOBOIJ/QNFl1JA== X-Google-Smtp-Source: ABdhPJzgcHEvPZCp6gdbg7kDhJKlxditkMSAtxr85wga0tldVXhcDC3GVMdHj7CuZ6MWQrtRrZ1EySnMvRiS1vE8OqA= X-Received: by 2002:a05:6870:f21a:b0:dd:9bec:caf8 with SMTP id t26-20020a056870f21a00b000dd9beccaf8mr1592268oao.78.1649753944968; Tue, 12 Apr 2022 01:59:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:59:04 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> <33212024-ae93-32c3-7890-09006057ff49@collabora.com> In-Reply-To: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:59:04 -0700 Message-ID: Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Schneider-Pargmann , linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, markyacoub@google.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 28 Mar 2022 10:09, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> From: Markus Schneider-Pargmann >> >> Similar to HDMI, DP uses audio infoframes as well which are structured >> very similar to the HDMI ones. >> >> This patch adds a helper function to pack the HDMI audio infoframe for >> DP, called hdmi_audio_infoframe_pack_for_dp(). >> hdmi_audio_infoframe_pack_only() is split into two parts. One of them >> packs the payload only and can be used for HDMI and DP. >> >> Signed-off-by: Markus Schneider-Pargmann >> Signed-off-by: Guillaume Ranquet >> --- >> drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- >> include/drm/dp/drm_dp_helper.h | 2 + >> include/linux/hdmi.h | 7 ++- >> 3 files changed, 71 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c >> index 947be761dfa4..5f50237554ed 100644 >> --- a/drivers/video/hdmi.c >> +++ b/drivers/video/hdmi.c >> @@ -21,6 +21,7 @@ >> * DEALINGS IN THE SOFTWARE. >> */ >> >> +#include >> #include >> #include >> #include >> @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr >> * >> * Returns 0 on success or a negative error code on failure. >> */ >> -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) >> +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) > >I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, >but you really should mention that you're constifying this one in your commit >description, or do that in a separate commit. > >Either of the two is fine. > >Regards, >Angelo Noted, I'll add it to the commit message. Thx, Guillaume. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1E2BC433F5 for ; Tue, 12 Apr 2022 08:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QPeOVc8avc6XAO7BxXdQGSGqIrPUNUkiQE64WFMOr2c=; b=wvNqrtXVtec4eRXjqpfqqTWqDH eKB4FVov+dMDybAznm3RJ+NzMLbhRt+EyAKENxeXNZokkPhNlctMz/DmELn1rCnkVN5fUyEew95Ub /nrUMuL5RtjUri7GEj18dvo0th5QgDFWToEiWJjt9NkoUMcmoJlzYY4VKGTGyS0+sEa8u+uSq/Nct sYlo8VQnE7tgMS76EJn2jrLmmcKr58NLCEGFA7bW3Cw+tjwdiP4TaBLrrX3HPldBaNG68ykxZewSi UMtewkYAr2IKbMbClrWQ8B/T8LS8Sf9h6UAlRZT2WnLF7rTzbM76eu7qYY7qfp5gqdfV/M7f+6t/M m+j7zYsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCMz-00CkB1-7U; Tue, 12 Apr 2022 08:59:29 +0000 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCMd-00Cjzg-4z for linux-phy@lists.infradead.org; Tue, 12 Apr 2022 08:59:08 +0000 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-ddfa38f1c1so20077374fac.11 for ; Tue, 12 Apr 2022 01:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=i+E8+24eJSPuwFpWwnhwRcMosCQtTEQoU0qVumPFd1B/5vOrb43OnnM06scRAF73Yq oMByED8vyfj7h/juyKz0L3ed4WqHpCgSlskOcx+kVCwtlWgCiSRQA57g1AuGyhRftLkn PMcblX+TbX+MHeKj3cpATLc7zfvBTrR1JonUwOgFtW9kUMKobrEyLRFKbEi6WgtAtS6n FCB8ilN1nAxUZedW0P+Azc/J+6dpMpBO/s4qN2MMBBKOQNBC+cNRVDAa2Xi5cUNXXxIm UJfzvicRT62Wq64zodMNVExN+Gzy0MnFtlZGEVwjmhUqQKDk5bd3GuHqulcLVnv1AYsL SMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=qnjwN32HCkq9vIVt0HPOqD8KsXbGbwXgjZ2/v7HGSLi57rD8j/6Fk3k+JOFr30XtJP Ifx0ulfPHflR0g65BQ4rfqV5RoWV0tc2KaUA+Er1YcDkavsckiHt6x8Pe97+0wSJEN5L 9dOV0GZrGIyV2DApHPER7mhuphTidbDwAAFGGpkCJtRxCTL0EIX7BYMHwmWP7U7Os4YE KhxOLdC/2ETgNb5X3POOGXUqvhYfisfgycWheWN8R2YdwFtzqauVBHZdt10jxxHqigLl p19alqOKRjN6zfKzPv2Iq9yjrAYWmy63nBoS0tio2vEMAuCZxSmTZDlwxIBsiN1mNmqk myvw== X-Gm-Message-State: AOAM530hK/TWAq/UMN/imju8S4wu9YLKm/qjz0x0bk9Y1YjHqrV9ctTe T2O6PtunQzY+49t2c4wWY+0f72d7103MTHTt+aJZ8w== X-Google-Smtp-Source: ABdhPJzgcHEvPZCp6gdbg7kDhJKlxditkMSAtxr85wga0tldVXhcDC3GVMdHj7CuZ6MWQrtRrZ1EySnMvRiS1vE8OqA= X-Received: by 2002:a05:6870:f21a:b0:dd:9bec:caf8 with SMTP id t26-20020a056870f21a00b000dd9beccaf8mr1592268oao.78.1649753944968; Tue, 12 Apr 2022 01:59:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:59:04 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> <33212024-ae93-32c3-7890-09006057ff49@collabora.com> In-Reply-To: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:59:04 -0700 Message-ID: Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_015907_238752_265A444F X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, 28 Mar 2022 10:09, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> From: Markus Schneider-Pargmann >> >> Similar to HDMI, DP uses audio infoframes as well which are structured >> very similar to the HDMI ones. >> >> This patch adds a helper function to pack the HDMI audio infoframe for >> DP, called hdmi_audio_infoframe_pack_for_dp(). >> hdmi_audio_infoframe_pack_only() is split into two parts. One of them >> packs the payload only and can be used for HDMI and DP. >> >> Signed-off-by: Markus Schneider-Pargmann >> Signed-off-by: Guillaume Ranquet >> --- >> drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- >> include/drm/dp/drm_dp_helper.h | 2 + >> include/linux/hdmi.h | 7 ++- >> 3 files changed, 71 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c >> index 947be761dfa4..5f50237554ed 100644 >> --- a/drivers/video/hdmi.c >> +++ b/drivers/video/hdmi.c >> @@ -21,6 +21,7 @@ >> * DEALINGS IN THE SOFTWARE. >> */ >> >> +#include >> #include >> #include >> #include >> @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr >> * >> * Returns 0 on success or a negative error code on failure. >> */ >> -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) >> +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) > >I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, >but you really should mention that you're constifying this one in your commit >description, or do that in a separate commit. > >Either of the two is fine. > >Regards, >Angelo Noted, I'll add it to the commit message. Thx, Guillaume. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3300C433EF for ; Tue, 12 Apr 2022 09:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=CYZ20qS/HFiWcK+8TSE5f3CevcL1psFT0bNcnlKSw5M=; b=0Ue/S9/Y219zJXw8s1XmBTniRc qUwgflT2eiUtma1wmIRn5Np6LM3kX/xIJqpVYJGWZ1mLitFyZBBsXA7laLWVnx9BT0+a51qdX197x EgGiovI7UA94W1uV3dlB97gsq8xERUPDMYWCit+rkja4fiT84F8+/ckKvzx85msDtOyD7P+HvSq58 0LjIiobQgzJLFYFvOECzR+rZo3wVkUNv7QIGFFdxPgCE/gvYRzof5y2hDY+UaJKx86CRxHe887x9S Yjj/1GIkzurra+0rJeFSU2ocPSZibKsUZTiV8fsl4ItnJujYFlWMKm0BVBZhh1uBGqWvR3j0cNgPK jRyfu9XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCMo-00Ck5i-Qa; Tue, 12 Apr 2022 08:59:19 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCMc-00Cjzf-JA for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 08:59:08 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-dacc470e03so20101989fac.5 for ; Tue, 12 Apr 2022 01:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=i+E8+24eJSPuwFpWwnhwRcMosCQtTEQoU0qVumPFd1B/5vOrb43OnnM06scRAF73Yq oMByED8vyfj7h/juyKz0L3ed4WqHpCgSlskOcx+kVCwtlWgCiSRQA57g1AuGyhRftLkn PMcblX+TbX+MHeKj3cpATLc7zfvBTrR1JonUwOgFtW9kUMKobrEyLRFKbEi6WgtAtS6n FCB8ilN1nAxUZedW0P+Azc/J+6dpMpBO/s4qN2MMBBKOQNBC+cNRVDAa2Xi5cUNXXxIm UJfzvicRT62Wq64zodMNVExN+Gzy0MnFtlZGEVwjmhUqQKDk5bd3GuHqulcLVnv1AYsL SMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=fs8gfcvvq0FE2SWPrkBppGrtwitGB6fdb4UMNyJ2HhrpKQe38mK/VVxAys1GjMFDuG 9Va31t+paDXfN6XrePSyRkKPm0aREev8DHIeAyRQYAnxqAYKjLX4h1Lq9A0T3GCYRvgN 6YF5bMq850EpT/yxI4xRHPE89esOw034kNmGVAbO6ozARpxEkGEK5GXeEj5tbn21lPQG nTdC8+aatWKu/7gN4GezibVPuCFL5rC025U5PRNQxg4tBCSy37AbdK7acemFCXwCKXEZ j6VG7D/S6q2aF4JCyuUN+9OvvWTWjubwQxaRslJ7XPssM3/cpC3CIoThocTFUgL3RiWW WpFQ== X-Gm-Message-State: AOAM530X9m3rwdQEtL24X5A/3bRfXrSNAO6VKrS0SRJJh4el7PYptzX9 F0Ju4wKTztaWDVdQOho6wJdtqRIY7LWixRn43fJgRQ== X-Google-Smtp-Source: ABdhPJzgcHEvPZCp6gdbg7kDhJKlxditkMSAtxr85wga0tldVXhcDC3GVMdHj7CuZ6MWQrtRrZ1EySnMvRiS1vE8OqA= X-Received: by 2002:a05:6870:f21a:b0:dd:9bec:caf8 with SMTP id t26-20020a056870f21a00b000dd9beccaf8mr1592268oao.78.1649753944968; Tue, 12 Apr 2022 01:59:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:59:04 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> <33212024-ae93-32c3-7890-09006057ff49@collabora.com> In-Reply-To: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:59:04 -0700 Message-ID: Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_015906_697296_284BD78C X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 28 Mar 2022 10:09, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> From: Markus Schneider-Pargmann >> >> Similar to HDMI, DP uses audio infoframes as well which are structured >> very similar to the HDMI ones. >> >> This patch adds a helper function to pack the HDMI audio infoframe for >> DP, called hdmi_audio_infoframe_pack_for_dp(). >> hdmi_audio_infoframe_pack_only() is split into two parts. One of them >> packs the payload only and can be used for HDMI and DP. >> >> Signed-off-by: Markus Schneider-Pargmann >> Signed-off-by: Guillaume Ranquet >> --- >> drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- >> include/drm/dp/drm_dp_helper.h | 2 + >> include/linux/hdmi.h | 7 ++- >> 3 files changed, 71 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c >> index 947be761dfa4..5f50237554ed 100644 >> --- a/drivers/video/hdmi.c >> +++ b/drivers/video/hdmi.c >> @@ -21,6 +21,7 @@ >> * DEALINGS IN THE SOFTWARE. >> */ >> >> +#include >> #include >> #include >> #include >> @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr >> * >> * Returns 0 on success or a negative error code on failure. >> */ >> -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) >> +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) > >I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, >but you really should mention that you're constifying this one in your commit >description, or do that in a separate commit. > >Either of the two is fine. > >Regards, >Angelo Noted, I'll add it to the commit message. Thx, Guillaume. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C08FC433FE for ; Tue, 12 Apr 2022 10:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351202AbiDLKSX (ORCPT ); Tue, 12 Apr 2022 06:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356896AbiDLJzT (ORCPT ); Tue, 12 Apr 2022 05:55:19 -0400 Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26CF32AE2C for ; Tue, 12 Apr 2022 01:59:05 -0700 (PDT) Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-e2fa360f6dso541377fac.2 for ; Tue, 12 Apr 2022 01:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=i+E8+24eJSPuwFpWwnhwRcMosCQtTEQoU0qVumPFd1B/5vOrb43OnnM06scRAF73Yq oMByED8vyfj7h/juyKz0L3ed4WqHpCgSlskOcx+kVCwtlWgCiSRQA57g1AuGyhRftLkn PMcblX+TbX+MHeKj3cpATLc7zfvBTrR1JonUwOgFtW9kUMKobrEyLRFKbEi6WgtAtS6n FCB8ilN1nAxUZedW0P+Azc/J+6dpMpBO/s4qN2MMBBKOQNBC+cNRVDAa2Xi5cUNXXxIm UJfzvicRT62Wq64zodMNVExN+Gzy0MnFtlZGEVwjmhUqQKDk5bd3GuHqulcLVnv1AYsL SMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=61Zhp6cmoUliim9YwiwcZpLzWn635tX3xmuezZ/XE1Q=; b=EaILETg9ZgRXOFbE3kBa2SisBWy9WXWF5pJZcm4vJYEDkvkID/rdjftCaLSHCuy3YS zW5fhIkI4XnlFzOTp3hZVJE6RaC9DuvPGGJxO/Fp5XQPBA4HT2zYD722CtibpNwB+EtC Apfz+9mlfW6zUfNFnSPiqJCWqOkQkBWPAOVuH8gBtNCkw1j22igSwEjmcclq/r/NPFDp kJiwbGws4KpOa23Qj3HsqHlxOOC8y84uagryUz3Ktps3ULLYqyTKCRxZ32UZRrZ+9fTw 7SUIP7SwJzk+VZfa7zWIbI0qHaW+1hXAnDIzadtste4SLQwu8IWXQDtOMYkZtUtxFl5g RjXQ== X-Gm-Message-State: AOAM530OqKbzUbAktZuwy2fwcanHh+4Kj6CGxyuYea8QOirDRuQaWIwC +h0I97IHHXLeEN0O4jQzfGWqoSsba4KJQgqsF8mkrw== X-Google-Smtp-Source: ABdhPJzgcHEvPZCp6gdbg7kDhJKlxditkMSAtxr85wga0tldVXhcDC3GVMdHj7CuZ6MWQrtRrZ1EySnMvRiS1vE8OqA= X-Received: by 2002:a05:6870:f21a:b0:dd:9bec:caf8 with SMTP id t26-20020a056870f21a00b000dd9beccaf8mr1592268oao.78.1649753944968; Tue, 12 Apr 2022 01:59:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:59:04 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> <33212024-ae93-32c3-7890-09006057ff49@collabora.com> In-Reply-To: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:59:04 -0700 Message-ID: Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Mar 2022 10:09, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> From: Markus Schneider-Pargmann >> >> Similar to HDMI, DP uses audio infoframes as well which are structured >> very similar to the HDMI ones. >> >> This patch adds a helper function to pack the HDMI audio infoframe for >> DP, called hdmi_audio_infoframe_pack_for_dp(). >> hdmi_audio_infoframe_pack_only() is split into two parts. One of them >> packs the payload only and can be used for HDMI and DP. >> >> Signed-off-by: Markus Schneider-Pargmann >> Signed-off-by: Guillaume Ranquet >> --- >> drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- >> include/drm/dp/drm_dp_helper.h | 2 + >> include/linux/hdmi.h | 7 ++- >> 3 files changed, 71 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c >> index 947be761dfa4..5f50237554ed 100644 >> --- a/drivers/video/hdmi.c >> +++ b/drivers/video/hdmi.c >> @@ -21,6 +21,7 @@ >> * DEALINGS IN THE SOFTWARE. >> */ >> >> +#include >> #include >> #include >> #include >> @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr >> * >> * Returns 0 on success or a negative error code on failure. >> */ >> -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) >> +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) > >I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, >but you really should mention that you're constifying this one in your commit >description, or do that in a separate commit. > >Either of the two is fine. > >Regards, >Angelo Noted, I'll add it to the commit message. Thx, Guillaume.