From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D4EC07E9D for ; Tue, 27 Sep 2022 13:14:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232480AbiI0NOB (ORCPT ); Tue, 27 Sep 2022 09:14:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbiI0NNm (ORCPT ); Tue, 27 Sep 2022 09:13:42 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68DA21577F3 for ; Tue, 27 Sep 2022 06:13:39 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id q15-20020a17090a304f00b002002ac83485so10080136pjl.0 for ; Tue, 27 Sep 2022 06:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=KGZxffdgEWrc+nIKZQdWmZ3shdGF0hcnG/eimwyIfxhrmALI1rYCYrjvI7h/XUgVGA AC6SvAtl53+/uRBU3anLk1UvpVRaNBemAR7Oyh2pHvX7bjmJNbSDXufs8hRYtyXsG5vQ jd3iWOu4rVRR/EnzQp9aaeBmal/AfKg+NmoFOYFIDeJe+wLcey51NCuMUbD1u2T1V94U R0nuad1PG+imVaMqobj/rIzM1PIjkWlf6o0msI+SnoIU3CpMuPKph0lfdyOcWwBg0vLZ dTGoMaNPB1H8WboG58vSq5A7eIOFKcqFwcw4AAp8tg8XHTSKsuUNf6zQOBzI1wa4MP6X qvxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=DvZW/Q/RmPkMjAW9ZudsKkpqVSwnAj6SLCkK3mvD106zycQ2aLEwo5ju2OK62B7s97 PPY6My9sC/rhGNFd+1/LTGOOEVVJ5IqC2TRqnh904lb7z3+Etz/x+C4FQWoP3y8Ts5bI hJIEYG2rFc0opDr2hRSJ0OUa5KRhOCfapoRfJsjSRWydyLwj6O3uNM4nE7i8V0405htv I1g0SOKNU6tZlnTh5dbCo35eVvn3nv+mafC6vP5BK06+x22brHSM/GqSJZJjNte+A553 ZC5Zf7nXFU5I2EP3YIhesE039USsC1IOMmVreNQCn8zBXoVf/b5i7OONI+OhP8cZtouz Ftvw== X-Gm-Message-State: ACrzQf3R7uq2cUhVlhUtHASr3U+oOwXajO/jSP6DppFcCo1fG2qFgcGV wHtuPNoncDM605dBdoOa965uiKwJJI/psLWKcB0Dcg== X-Google-Smtp-Source: AMsMyM5foO9hRFfJNeJsExDA4MlTDjL11pmea0BPzSUwTLsGAoVk8kBgQmDpzSWwATR1ZA70FE3cdWBnn6SlAjNkjO4= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr27434461plo.112.1664284411364; Tue, 27 Sep 2022 06:13:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:13:30 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-12-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:13:30 -0700 Message-ID: Subject: Re: [PATCH v1 12/17] drm/mediatek: hdmi: mt8195: add audio support To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2022 13:11, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Add HDMI audio support for mt8195 >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> index 39e07a6dd490..bb7593ea4c86 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> @@ -215,6 +215,26 @@ static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black) >> mtk_hdmi_mask(hdmi, TOP_VMUTE_CFG1, 0, REG_VMUTE_EN); >> } >> >> +static void mtk_hdmi_hw_aud_mute(struct mtk_hdmi *hdmi) >> +{ >> + u32 val; >> + >> + val = mtk_hdmi_read(hdmi, AIP_CTRL, &val); >> + > >val_tx = AUD_MUTE_FIFO_EN; >if (val & DSD_EN) > val_tx |= DSD_MUTE_DATA; > >regmap_set_bits(regmap, AIP_TXCTRL, val_tx); > >Easier, shorter. Thx for the tip. > >> + if (val & DSD_EN) >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN); >> + else >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, AUD_MUTE_FIFO_EN, >> + AUD_MUTE_FIFO_EN); >> +} > >Regards, >Angelo > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4740C6FA82 for ; Tue, 27 Sep 2022 13:13:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5CD210E335; Tue, 27 Sep 2022 13:13:37 +0000 (UTC) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB26010E323 for ; Tue, 27 Sep 2022 13:13:31 +0000 (UTC) Received: by mail-pl1-x636.google.com with SMTP id d24so9050410pls.4 for ; Tue, 27 Sep 2022 06:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=KGZxffdgEWrc+nIKZQdWmZ3shdGF0hcnG/eimwyIfxhrmALI1rYCYrjvI7h/XUgVGA AC6SvAtl53+/uRBU3anLk1UvpVRaNBemAR7Oyh2pHvX7bjmJNbSDXufs8hRYtyXsG5vQ jd3iWOu4rVRR/EnzQp9aaeBmal/AfKg+NmoFOYFIDeJe+wLcey51NCuMUbD1u2T1V94U R0nuad1PG+imVaMqobj/rIzM1PIjkWlf6o0msI+SnoIU3CpMuPKph0lfdyOcWwBg0vLZ dTGoMaNPB1H8WboG58vSq5A7eIOFKcqFwcw4AAp8tg8XHTSKsuUNf6zQOBzI1wa4MP6X qvxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=yFbl3uvXWfdle3YoiQlFC/02uMmAZfECfqeK8LkR2G4/yu5VzV+Vn025IqLaNn92MG BGkC4v4P4HOD/XVjyXcEQWwAUo1m0RX1mjuIyzGCpj9tWlJCiVj6g4jR/fHs2ftquvOd x7cJzyjrUH9UuUY1YFR4aEDLfRxvJIP42EHuhsMbQfwbikpv0ND0BFmGhlaB1yZdl8Lp Hx9pFaDpYlBKv8bvSDmqmTH6qgN8wJ1NJbwYIA1VFqZLF0qoyxPNfqfQjZgJAyCjew7l SqKB39hhsv6uYGHXJj4h2vY1GXfiptM6iRczI2JJEQLK0Wm264j3Dh3Xp3mtaHO1XKjG aFdA== X-Gm-Message-State: ACrzQf31U0Y3BxOcRQ2CpHagCktayW2hwi24phHHHz6RL0Jrai45b6ma hSsZrJVOwuEfc0yN7Y16mORUjN53uPevKoLg31HYOw== X-Google-Smtp-Source: AMsMyM5foO9hRFfJNeJsExDA4MlTDjL11pmea0BPzSUwTLsGAoVk8kBgQmDpzSWwATR1ZA70FE3cdWBnn6SlAjNkjO4= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr27434461plo.112.1664284411364; Tue, 27 Sep 2022 06:13:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:13:30 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-12-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:13:30 -0700 Message-ID: Subject: Re: [PATCH v1 12/17] drm/mediatek: hdmi: mt8195: add audio support To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 20 Sep 2022 13:11, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Add HDMI audio support for mt8195 >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> index 39e07a6dd490..bb7593ea4c86 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> @@ -215,6 +215,26 @@ static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black) >> mtk_hdmi_mask(hdmi, TOP_VMUTE_CFG1, 0, REG_VMUTE_EN); >> } >> >> +static void mtk_hdmi_hw_aud_mute(struct mtk_hdmi *hdmi) >> +{ >> + u32 val; >> + >> + val = mtk_hdmi_read(hdmi, AIP_CTRL, &val); >> + > >val_tx = AUD_MUTE_FIFO_EN; >if (val & DSD_EN) > val_tx |= DSD_MUTE_DATA; > >regmap_set_bits(regmap, AIP_TXCTRL, val_tx); > >Easier, shorter. Thx for the tip. > >> + if (val & DSD_EN) >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN); >> + else >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, AUD_MUTE_FIFO_EN, >> + AUD_MUTE_FIFO_EN); >> +} > >Regards, >Angelo > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4560C6FA82 for ; Tue, 27 Sep 2022 13:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=mNtqy0GwZ/kMrjcNceKSb9wwnroP40eo40NvUgnhzac=; b=Txr0FfNtwH0vu+T8hIB1jKVLau de/V+C9dEaIKl1XvfOSmxPscTK6Svd7LeRV/x9Ebi6oS8NTfVX1KiMREEvTNOBK52yRJAjXMMdMax HUkaPF5I1GIrzTXqgwCPlQuAiVOINul+32oqKN9VZDrskRg2i17B2Iplwm9nEtkgTDgeBRFfBUpgw +urYJTHj0OpVxrT3zDvDQRyU0v8XPbOBI5CDwfFOgL8WKJh2mXT8XLpI8uAZW78J+rjWMJ5JXrHD9 YWcOYCHhDEiRYvxF4Oi7YA1qyXsMNOAnVVmvdzWlCA0yIxIh0ckHv/VYvwgex2ScrM8hANJ0+FFsD CaVUYBSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAPB-00AjCp-9i; Tue, 27 Sep 2022 13:13:45 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAP3-00Aj98-Sk for linux-phy@lists.infradead.org; Tue, 27 Sep 2022 13:13:39 +0000 Received: by mail-pj1-x1030.google.com with SMTP id u92so151540pjh.3 for ; Tue, 27 Sep 2022 06:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=KGZxffdgEWrc+nIKZQdWmZ3shdGF0hcnG/eimwyIfxhrmALI1rYCYrjvI7h/XUgVGA AC6SvAtl53+/uRBU3anLk1UvpVRaNBemAR7Oyh2pHvX7bjmJNbSDXufs8hRYtyXsG5vQ jd3iWOu4rVRR/EnzQp9aaeBmal/AfKg+NmoFOYFIDeJe+wLcey51NCuMUbD1u2T1V94U R0nuad1PG+imVaMqobj/rIzM1PIjkWlf6o0msI+SnoIU3CpMuPKph0lfdyOcWwBg0vLZ dTGoMaNPB1H8WboG58vSq5A7eIOFKcqFwcw4AAp8tg8XHTSKsuUNf6zQOBzI1wa4MP6X qvxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=seDy8gKhSxq0BDbf8PPPCEgK/McZITD18F7nYv2I4k9eWi5/KAl9HAbkg+SbECmAPm bkXYtsMv9A5L3vBqoYIIerqFBHCMsXpg6ClaIHPG7OXxbff/sLoQJDd8MP77jhNDNrAA JJhQpDiREU1iFIg+wXyQRrbTO3N8U/Caiq6DVFrnoDQX6zja5lQKxP07WDlTS+Gv5Umg oQ4j1W6RQoS1cxX3j8e7DbnZsxgNgMA5FG3030u0a0baLfV7JvVU8JeerGof7CRWknva z0eLnCFGDyQE2oqmYWIhLuxgyMFu4Ae4S0pn33zcrRWr0PCJ6/gLi8PF2BXEVE1E9BQV TYDA== X-Gm-Message-State: ACrzQf0Ipl5E7mlyQGuX8GwyHUwiTwOJKbGpksMKuloi1iY6b8inuJ34 BfLHoonwkly01fZ0tafE+VL+ITUE3Fe1kzOkx7WxnQ== X-Google-Smtp-Source: AMsMyM5foO9hRFfJNeJsExDA4MlTDjL11pmea0BPzSUwTLsGAoVk8kBgQmDpzSWwATR1ZA70FE3cdWBnn6SlAjNkjO4= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr27434461plo.112.1664284411364; Tue, 27 Sep 2022 06:13:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:13:30 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-12-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:13:30 -0700 Message-ID: Subject: Re: [PATCH v1 12/17] drm/mediatek: hdmi: mt8195: add audio support To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_061337_946449_ECFE7020 X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, 20 Sep 2022 13:11, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Add HDMI audio support for mt8195 >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> index 39e07a6dd490..bb7593ea4c86 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> @@ -215,6 +215,26 @@ static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black) >> mtk_hdmi_mask(hdmi, TOP_VMUTE_CFG1, 0, REG_VMUTE_EN); >> } >> >> +static void mtk_hdmi_hw_aud_mute(struct mtk_hdmi *hdmi) >> +{ >> + u32 val; >> + >> + val = mtk_hdmi_read(hdmi, AIP_CTRL, &val); >> + > >val_tx = AUD_MUTE_FIFO_EN; >if (val & DSD_EN) > val_tx |= DSD_MUTE_DATA; > >regmap_set_bits(regmap, AIP_TXCTRL, val_tx); > >Easier, shorter. Thx for the tip. > >> + if (val & DSD_EN) >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN); >> + else >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, AUD_MUTE_FIFO_EN, >> + AUD_MUTE_FIFO_EN); >> +} > >Regards, >Angelo > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AE94C6FA92 for ; Tue, 27 Sep 2022 13:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=KlojWPaSaK5pykNyBnBmRJ4x3KU9XonJ+63Faqmd5qk=; b=ggQbq9gj5D3pYOCI7acXlqgc5h EitHeDXDDjdO4e/tsTMgv3aKKibtrTo998FvpdR8uNa1zBYpU5Wy8WHUBgt8OyrkWleKFjWOf+5tf of/hZZI84yn2xjd2XvfPN8nyNB3M+CiBsCCajYmv0HYttf8XEMDCwV94CfNlq+D+U1Wny280Fb0DL dgO8r5fGRFF0jJJuWLWo4xeEBBZoidIuee3LFfgBdOk+E5Ca5pb0JWeAangTDvP6jv1deNGldm4JR BG+kP7S/O5y4iuIyn37/wBojhCaE5gw0tbOGXwk7pVuRMW4HsNKNsdEacPduik38PSCG+SC5F5a+Y F5ExabPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAP2-00AjA7-35; Tue, 27 Sep 2022 13:13:36 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAOy-00Aj96-77 for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 13:13:34 +0000 Received: by mail-pl1-x634.google.com with SMTP id w10so9026946pll.11 for ; Tue, 27 Sep 2022 06:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=KGZxffdgEWrc+nIKZQdWmZ3shdGF0hcnG/eimwyIfxhrmALI1rYCYrjvI7h/XUgVGA AC6SvAtl53+/uRBU3anLk1UvpVRaNBemAR7Oyh2pHvX7bjmJNbSDXufs8hRYtyXsG5vQ jd3iWOu4rVRR/EnzQp9aaeBmal/AfKg+NmoFOYFIDeJe+wLcey51NCuMUbD1u2T1V94U R0nuad1PG+imVaMqobj/rIzM1PIjkWlf6o0msI+SnoIU3CpMuPKph0lfdyOcWwBg0vLZ dTGoMaNPB1H8WboG58vSq5A7eIOFKcqFwcw4AAp8tg8XHTSKsuUNf6zQOBzI1wa4MP6X qvxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=uw1gvMh/1zxeYeQnV6wZiimhJI0pYdqIU/T7gR133DU=; b=RcT/njVDG720HKn0Z1fRocRm/OcT6AMo8qM4aea6pex/WnBEJuql792tcFFmtpdRcz ttrHg/40+y8Bl6C5zFb5K3ucTmA/OuJJgjhED64N53S3EAwAlmosePZ+o1lXnJe4//AA 9/1j+imZM8GU3QFF07ik9zdhsFww9YpH3wHy4lAlvCwHV3f0FCz1Z5LRXZ711+/bC8Dq j7F0Qcain4Fd7ddqLe3NVpHGHVTLu5LKO7BFPdNpYCFzyctgFMQMZ6g6MnU5XZdBMLPr PLwmCePQx6RiVcF2gOcCFqPW7GZEpsbanDeZ42pESnKoepFidQIGFT6EkS1xAydhnlxt gQdQ== X-Gm-Message-State: ACrzQf0KDUlGcT+wuE0kJtzAkMVDgqVpxVFWqlmMGrB4d/eIs4QHxeJK E6+/Pli72WqEScfEQu6YnD8keHwXM50PB4AuNrob3w== X-Google-Smtp-Source: AMsMyM5foO9hRFfJNeJsExDA4MlTDjL11pmea0BPzSUwTLsGAoVk8kBgQmDpzSWwATR1ZA70FE3cdWBnn6SlAjNkjO4= X-Received: by 2002:a17:902:f710:b0:178:a692:b1f7 with SMTP id h16-20020a170902f71000b00178a692b1f7mr27434461plo.112.1664284411364; Tue, 27 Sep 2022 06:13:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:13:30 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-12-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:13:30 -0700 Message-ID: Subject: Re: [PATCH v1 12/17] drm/mediatek: hdmi: mt8195: add audio support To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_061332_279516_3DCFD92D X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Sep 2022 13:11, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Add HDMI audio support for mt8195 >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> index 39e07a6dd490..bb7593ea4c86 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> @@ -215,6 +215,26 @@ static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black) >> mtk_hdmi_mask(hdmi, TOP_VMUTE_CFG1, 0, REG_VMUTE_EN); >> } >> >> +static void mtk_hdmi_hw_aud_mute(struct mtk_hdmi *hdmi) >> +{ >> + u32 val; >> + >> + val = mtk_hdmi_read(hdmi, AIP_CTRL, &val); >> + > >val_tx = AUD_MUTE_FIFO_EN; >if (val & DSD_EN) > val_tx |= DSD_MUTE_DATA; > >regmap_set_bits(regmap, AIP_TXCTRL, val_tx); > >Easier, shorter. Thx for the tip. > >> + if (val & DSD_EN) >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN, >> + DSD_MUTE_DATA | AUD_MUTE_FIFO_EN); >> + else >> + mtk_hdmi_mask(hdmi, AIP_TXCTRL, AUD_MUTE_FIFO_EN, >> + AUD_MUTE_FIFO_EN); >> +} > >Regards, >Angelo > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel