From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31AACC07E9D for ; Tue, 27 Sep 2022 13:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232321AbiI0NJi (ORCPT ); Tue, 27 Sep 2022 09:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbiI0NJe (ORCPT ); Tue, 27 Sep 2022 09:09:34 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E33A1879DC for ; Tue, 27 Sep 2022 06:08:47 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id b21so9027973plz.7 for ; Tue, 27 Sep 2022 06:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=Y3O5T8rz166uc6HJ4FhMI44NIUgz7yP8NiLJa38oQ3iQqcCvEf1JKUSMRRQjUmvMTd 4ctpIh9zL2BGVRzkWihc/0+zJA0vvqQaNIcdLVBGBjlJgpCdtH9UA6CaIZ8fAsMB7Qa5 MAmXOYJLBFGb76dyw/0GYl4Ud9bQLwonphTsObGEXWQEk9eA57oxtDSmPKQJHfic3A3j HkZqwW/hayyIYLR1Y0kHnLheguF50xHZLRtrPOgrjZtl0trmUGTA+HLEUWgduM2GBkWu ThZ/NjoYcg+Qh9SrbLP+UhAR4BHGL1ZL/OyBADAi8nYVZqFUBSIRwmAXmM7f9rMGutH+ 2GAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=mAJPUwgyNvVs+r1EA7701Idg5yjhajvMoQhVPScXVfYIQ33QFRVmwHAHuchEVNYt/r /0ZzrgsPME2LazdOq70TnXzB9z7dUifmwgHElxdADvaq6zkYarxHpSOChr8cbB+LLc5M fIZ1fnZoFzxB1wwMwsEyHBE4Yh+MwF8TT58UimGYYJ5Rt1hIkZZKjrlflqccqSnTnX8A ET7YDnFljOCb/U/ILClptBW6qCkda8Oa0a9FCmcWbRIFIusm5d1Sv080ZG6PCbuIE/rt wbUtCjl8pi2sorJhklMJpx/Olia6fHdf2fcXGbEl3bPalZrF8H+YKU+zcILs8Kpuyb3z w1og== X-Gm-Message-State: ACrzQf3DWj4Kw9tqPi97/fo77STVe7ICGOIzLccEQxQfOscUTCxXw5Om okL8RwbhbI8a5HdgIGf1b2hcZGlolyxUcis4sN+TEQ== X-Google-Smtp-Source: AMsMyM6X8Fa6ezRZqL7m/lEJjF3Bh5CG2glAPpLeLqQI0M9YdLpt4yB4B9sD/oFbG2+k4WA70xAHEax+sQbaSKsrxhc= X-Received: by 2002:a17:90b:3807:b0:205:d746:93a0 with SMTP id mq7-20020a17090b380700b00205d74693a0mr3635933pjb.188.1664284124030; Tue, 27 Sep 2022 06:08:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:08:43 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-7-4844816c9808@baylibre.com> <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> In-Reply-To: <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:08:43 -0700 Message-ID: Subject: Re: [PATCH v1 07/17] drm/mediatek: extract common functions from the mtk hdmi driver To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2022 12:25, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Create a common "framework" that can be used to add support for >> different hdmi IPs within the mediatek range of products. >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile >> index d4d193f60271..008ec69da67b 100644 >> --- a/drivers/gpu/drm/mediatek/Makefile >> +++ b/drivers/gpu/drm/mediatek/Makefile >> @@ -22,7 +22,8 @@ obj-$(CONFIG_DRM_MEDIATEK) += mediatek-drm.o >> >> mediatek-drm-hdmi-objs := mtk_cec.o \ >> mtk_hdmi.o \ > >abcd ... mtk_hdmi_common.o goes here :-) > >> - mtk_hdmi_ddc.o >> + mtk_hdmi_ddc.o \ >> + mtk_hdmi_common.o \ >> >> obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> index 5cd05d4fe1a9..837d36ec4d64 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> @@ -32,187 +32,18 @@ >> #include >> >> #include "mtk_cec.h" >> -#include "mtk_hdmi.h" >> #include "mtk_hdmi_regs.h" >> +#include "mtk_hdmi_common.h" >> >> #define NCTS_BYTES 7 >> >> -enum mtk_hdmi_clk_id { >> - MTK_HDMI_CLK_HDMI_PIXEL, >> - MTK_HDMI_CLK_HDMI_PLL, >> - MTK_HDMI_CLK_AUD_BCLK, >> - MTK_HDMI_CLK_AUD_SPDIF, >> - MTK_HDMI_CLK_COUNT >> +const char * const mtk_hdmi_clk_names_mt8183[MTK_MT8183_HDMI_CLK_COUNT] = { > >Why MT8183? This can be either MT8167 or MT2701... or, IMO more appropriately, you >should name the IP version. >Example: MTK_HDMIV123_CLK_COUNT (I don't know what IP version would that be!). You're right, the naming isn't great. I'll ask mediatek if they have a good name that would regroup the "legacy" HDMI IP and the new IP in mt8195. Thx, Guillaume. > >> + [MTK_MT8183_HDMI_CLK_HDMI_PIXEL] = "pixel", >> + [MTK_MT8183_HDMI_CLK_HDMI_PLL] = "pll", >> + [MTK_MT8183_HDMI_CLK_AUD_BCLK] = "bclk", >> + [MTK_MT8183_HDMI_CLK_AUD_SPDIF] = "spdif", >> }; >> > >Regards, >Angelo > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C112C07E9D for ; Tue, 27 Sep 2022 13:08:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 895BD10E31E; Tue, 27 Sep 2022 13:08:49 +0000 (UTC) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8083D10E31E for ; Tue, 27 Sep 2022 13:08:44 +0000 (UTC) Received: by mail-pl1-x632.google.com with SMTP id z20so2147956plb.10 for ; Tue, 27 Sep 2022 06:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=Y3O5T8rz166uc6HJ4FhMI44NIUgz7yP8NiLJa38oQ3iQqcCvEf1JKUSMRRQjUmvMTd 4ctpIh9zL2BGVRzkWihc/0+zJA0vvqQaNIcdLVBGBjlJgpCdtH9UA6CaIZ8fAsMB7Qa5 MAmXOYJLBFGb76dyw/0GYl4Ud9bQLwonphTsObGEXWQEk9eA57oxtDSmPKQJHfic3A3j HkZqwW/hayyIYLR1Y0kHnLheguF50xHZLRtrPOgrjZtl0trmUGTA+HLEUWgduM2GBkWu ThZ/NjoYcg+Qh9SrbLP+UhAR4BHGL1ZL/OyBADAi8nYVZqFUBSIRwmAXmM7f9rMGutH+ 2GAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=e2pq6Dq++KYBMO1MfM86KRmJgl3fhNlpBRvcaWA+buTSa32M/Dfqsl/cLq7Sy41PmJ knELwtAABTdPGBt9fpydLdjxRjoY2ru0eRRZzlqEHgOja5sGavxkqlaIua5oiUX0EYM8 Q+J5Y5T7ObGFUY3D5mgqk70ggebNoQ7uZ3tYE+WMub3JQKafrtbzePl8ykeeBxj0Peo2 BZLXF7JE1Ecflj/qditeOsFluTgNvZonPYHGF0dZqMLIJT8ULNshBqkJhc7CdVnJE0TE Y8zaKLdTYtF01ozhzl0ldlXYHTrYmcPINibbHMM/7XIH0DGsDDA84LC32q111wsXy+ns SuaA== X-Gm-Message-State: ACrzQf1AWxMj56ikR1Q4w+MtxzpFMnwpXtdNZJaDIsxqXDh5ZbB2gNP+ bIwrWvf1MD3W5mRTpXdGea+yYIGgtZTG2e6RFd3ZIQ== X-Google-Smtp-Source: AMsMyM6X8Fa6ezRZqL7m/lEJjF3Bh5CG2glAPpLeLqQI0M9YdLpt4yB4B9sD/oFbG2+k4WA70xAHEax+sQbaSKsrxhc= X-Received: by 2002:a17:90b:3807:b0:205:d746:93a0 with SMTP id mq7-20020a17090b380700b00205d74693a0mr3635933pjb.188.1664284124030; Tue, 27 Sep 2022 06:08:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:08:43 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-7-4844816c9808@baylibre.com> <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> In-Reply-To: <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:08:43 -0700 Message-ID: Subject: Re: [PATCH v1 07/17] drm/mediatek: extract common functions from the mtk hdmi driver To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 20 Sep 2022 12:25, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Create a common "framework" that can be used to add support for >> different hdmi IPs within the mediatek range of products. >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile >> index d4d193f60271..008ec69da67b 100644 >> --- a/drivers/gpu/drm/mediatek/Makefile >> +++ b/drivers/gpu/drm/mediatek/Makefile >> @@ -22,7 +22,8 @@ obj-$(CONFIG_DRM_MEDIATEK) += mediatek-drm.o >> >> mediatek-drm-hdmi-objs := mtk_cec.o \ >> mtk_hdmi.o \ > >abcd ... mtk_hdmi_common.o goes here :-) > >> - mtk_hdmi_ddc.o >> + mtk_hdmi_ddc.o \ >> + mtk_hdmi_common.o \ >> >> obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> index 5cd05d4fe1a9..837d36ec4d64 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> @@ -32,187 +32,18 @@ >> #include >> >> #include "mtk_cec.h" >> -#include "mtk_hdmi.h" >> #include "mtk_hdmi_regs.h" >> +#include "mtk_hdmi_common.h" >> >> #define NCTS_BYTES 7 >> >> -enum mtk_hdmi_clk_id { >> - MTK_HDMI_CLK_HDMI_PIXEL, >> - MTK_HDMI_CLK_HDMI_PLL, >> - MTK_HDMI_CLK_AUD_BCLK, >> - MTK_HDMI_CLK_AUD_SPDIF, >> - MTK_HDMI_CLK_COUNT >> +const char * const mtk_hdmi_clk_names_mt8183[MTK_MT8183_HDMI_CLK_COUNT] = { > >Why MT8183? This can be either MT8167 or MT2701... or, IMO more appropriately, you >should name the IP version. >Example: MTK_HDMIV123_CLK_COUNT (I don't know what IP version would that be!). You're right, the naming isn't great. I'll ask mediatek if they have a good name that would regroup the "legacy" HDMI IP and the new IP in mt8195. Thx, Guillaume. > >> + [MTK_MT8183_HDMI_CLK_HDMI_PIXEL] = "pixel", >> + [MTK_MT8183_HDMI_CLK_HDMI_PLL] = "pll", >> + [MTK_MT8183_HDMI_CLK_AUD_BCLK] = "bclk", >> + [MTK_MT8183_HDMI_CLK_AUD_SPDIF] = "spdif", >> }; >> > >Regards, >Angelo > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C570C07E9D for ; Tue, 27 Sep 2022 13:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Ic2ddz54LN2TkRIZWB9PCHpK1XsRQV1NtjE+KH4O0PI=; b=lAY6eCNz40A73Z5hPKKw9Q12md Mi87QkKs3COpBmR2lRdd4IeNPA7F7D/ZZqUhlZlskTF3x6jLmhURrxJN5SBU4fXO7wLu+g25W2DAt 2tuSHGNJiq0qWVo9pqYHuUKvRNb8WpTb/Ppiz1h3dc9yeGjZeSip5pxcnCLjrtnL3MOVUsZQfpfWl 7Fpq/rIbEe9L2QsdvY6XnaHhBZ+GyIP0+tJAf7szqEoXs58c8zbxN74i8TdkDdFWJ+1w/nC33yUtx NzzUkGQmebECr/f5iUP34DGIfyI0BTgZYOOA/3MB5Xl/yxEyCET+OWeur8FIFO8Y65VSCBNZzlUKo WKF2yDcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAKW-00AhMj-LE; Tue, 27 Sep 2022 13:08:56 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAKN-00AhHI-MJ for linux-phy@lists.infradead.org; Tue, 27 Sep 2022 13:08:55 +0000 Received: by mail-pl1-x62f.google.com with SMTP id w20so9003741ply.12 for ; Tue, 27 Sep 2022 06:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=Y3O5T8rz166uc6HJ4FhMI44NIUgz7yP8NiLJa38oQ3iQqcCvEf1JKUSMRRQjUmvMTd 4ctpIh9zL2BGVRzkWihc/0+zJA0vvqQaNIcdLVBGBjlJgpCdtH9UA6CaIZ8fAsMB7Qa5 MAmXOYJLBFGb76dyw/0GYl4Ud9bQLwonphTsObGEXWQEk9eA57oxtDSmPKQJHfic3A3j HkZqwW/hayyIYLR1Y0kHnLheguF50xHZLRtrPOgrjZtl0trmUGTA+HLEUWgduM2GBkWu ThZ/NjoYcg+Qh9SrbLP+UhAR4BHGL1ZL/OyBADAi8nYVZqFUBSIRwmAXmM7f9rMGutH+ 2GAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=e+vP+u0DtThbAi7OZMLWYHFT28nQaiB0v2TH9fhQMXO0H3H3GHuve+lL/j4ivHD/kX STP+Tg9pfNc4vswXdN8eq9k3iaEAvJB5hw6zhTOg1wbeIkadOA/Vj4ToFBne+a9oej/I We00cLnffsAqnC29qHZVTChXSve/UuuheoGRpxz8BtCm2K2stl9J4eWOIa0p8k9ujzlC W79VgAXQ6GXiTv9VAq1iwOMWlWTlXO2dy2vj4s4W2tnHVprmwTkvaCcxucqS/yQWu+oN JeZD9RaYfgIj77+qT70IH3swhfcD74xtVSa66IZLIS3WGytddLh2NXrpmELVmdTWpTsC NHOg== X-Gm-Message-State: ACrzQf1QQw0Z5yV6Rd14CXJHQjJ9l/cfNmqghlAL/BmgawRt5Bp2yEBY xZvaY0r4OSfu8pdfhyqXXg/U4OPThJIKs11hZ1dxsg== X-Google-Smtp-Source: AMsMyM6X8Fa6ezRZqL7m/lEJjF3Bh5CG2glAPpLeLqQI0M9YdLpt4yB4B9sD/oFbG2+k4WA70xAHEax+sQbaSKsrxhc= X-Received: by 2002:a17:90b:3807:b0:205:d746:93a0 with SMTP id mq7-20020a17090b380700b00205d74693a0mr3635933pjb.188.1664284124030; Tue, 27 Sep 2022 06:08:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:08:43 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-7-4844816c9808@baylibre.com> <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> In-Reply-To: <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:08:43 -0700 Message-ID: Subject: Re: [PATCH v1 07/17] drm/mediatek: extract common functions from the mtk hdmi driver To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_060847_734837_FDED1790 X-CRM114-Status: GOOD ( 10.06 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, 20 Sep 2022 12:25, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Create a common "framework" that can be used to add support for >> different hdmi IPs within the mediatek range of products. >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile >> index d4d193f60271..008ec69da67b 100644 >> --- a/drivers/gpu/drm/mediatek/Makefile >> +++ b/drivers/gpu/drm/mediatek/Makefile >> @@ -22,7 +22,8 @@ obj-$(CONFIG_DRM_MEDIATEK) += mediatek-drm.o >> >> mediatek-drm-hdmi-objs := mtk_cec.o \ >> mtk_hdmi.o \ > >abcd ... mtk_hdmi_common.o goes here :-) > >> - mtk_hdmi_ddc.o >> + mtk_hdmi_ddc.o \ >> + mtk_hdmi_common.o \ >> >> obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> index 5cd05d4fe1a9..837d36ec4d64 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> @@ -32,187 +32,18 @@ >> #include >> >> #include "mtk_cec.h" >> -#include "mtk_hdmi.h" >> #include "mtk_hdmi_regs.h" >> +#include "mtk_hdmi_common.h" >> >> #define NCTS_BYTES 7 >> >> -enum mtk_hdmi_clk_id { >> - MTK_HDMI_CLK_HDMI_PIXEL, >> - MTK_HDMI_CLK_HDMI_PLL, >> - MTK_HDMI_CLK_AUD_BCLK, >> - MTK_HDMI_CLK_AUD_SPDIF, >> - MTK_HDMI_CLK_COUNT >> +const char * const mtk_hdmi_clk_names_mt8183[MTK_MT8183_HDMI_CLK_COUNT] = { > >Why MT8183? This can be either MT8167 or MT2701... or, IMO more appropriately, you >should name the IP version. >Example: MTK_HDMIV123_CLK_COUNT (I don't know what IP version would that be!). You're right, the naming isn't great. I'll ask mediatek if they have a good name that would regroup the "legacy" HDMI IP and the new IP in mt8195. Thx, Guillaume. > >> + [MTK_MT8183_HDMI_CLK_HDMI_PIXEL] = "pixel", >> + [MTK_MT8183_HDMI_CLK_HDMI_PLL] = "pll", >> + [MTK_MT8183_HDMI_CLK_AUD_BCLK] = "bclk", >> + [MTK_MT8183_HDMI_CLK_AUD_SPDIF] = "spdif", >> }; >> > >Regards, >Angelo > > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BF28C54EE9 for ; Tue, 27 Sep 2022 13:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jLDKrw7mapqUUmBdp6z0F9ImQJ1iebqKA8P0/jAqWuI=; b=g7PKVbW/iTvmiPTu0Zk95jONG6 AfwKqkTuk4XNiStQcRfcjkh4Yhg4M6zRSyOuXgSqb7h70c9JNapWeUKQ56hm+Zz3WOOx+OCyic5pY iuyIxe3VZn4AGFjxU9w3dPKhMrosztZFf6shd8kK7TFbkosEZWx009lZXeNwm7Vd5WxsZSWjP68Lu yNcwXpjw79hFGzbzcsGgzOHBH+UAzmsr43ZhY+iZtYvlrU4psFxsJgXu+yZslvfRmit7bVz92fHwa 13DgXG5p0hDcfl9ffeWurU+iA652d0qR0+66m5s1vl6J711CPnARQM0B0Xvf1jag/Y1vObK7riZoX nh6EWC/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAKY-00AhN6-CA; Tue, 27 Sep 2022 13:08:58 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAKO-00AhHH-G0 for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 13:08:56 +0000 Received: by mail-pl1-x630.google.com with SMTP id x1so9031997plv.5 for ; Tue, 27 Sep 2022 06:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=Y3O5T8rz166uc6HJ4FhMI44NIUgz7yP8NiLJa38oQ3iQqcCvEf1JKUSMRRQjUmvMTd 4ctpIh9zL2BGVRzkWihc/0+zJA0vvqQaNIcdLVBGBjlJgpCdtH9UA6CaIZ8fAsMB7Qa5 MAmXOYJLBFGb76dyw/0GYl4Ud9bQLwonphTsObGEXWQEk9eA57oxtDSmPKQJHfic3A3j HkZqwW/hayyIYLR1Y0kHnLheguF50xHZLRtrPOgrjZtl0trmUGTA+HLEUWgduM2GBkWu ThZ/NjoYcg+Qh9SrbLP+UhAR4BHGL1ZL/OyBADAi8nYVZqFUBSIRwmAXmM7f9rMGutH+ 2GAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=YoaKPGbtL0W6yKop2Q5GqUbFMulbchm58vJX4E+Hvss=; b=oS0lMnJUcZWV+I+scsNgHTx4piGxu4kWZQMUC07GbWT6dUBT4T2BWU708+Vo8WnH3M VIOoTa3R4epyt9a0/dAzY821XPbLUe/Nj/nEoL6dYhbm4DjFapDnqsPKd7j7JHJjdAyQ Ze3B5IIdx3E5+6cE7iOjRMWYxij18D+eA+xLZs4V6P48ghs06Xk5OMunDXcqAZsCIF88 Vfq4ryB2GHGAyTitvbDdZiuNQCkcNzxiVzLzKT71GrQ6+TxslT6xPh270jNiAG0HP/nr 6627k8a49oeBpSJqHgMBxmp2YC78D+OGnJGM3j+LCyPbwGNhqDOcLhwOPS9fgsAW91Ys tW3Q== X-Gm-Message-State: ACrzQf2mPEWrVjPYL0pw7+dYZwP7p6r+dUN9oLmQ+nVRu4icf9dohvsx OZjBAIk/KccKXYn+72B1Hk9R+KYFP77KGm7GprHPfw== X-Google-Smtp-Source: AMsMyM6X8Fa6ezRZqL7m/lEJjF3Bh5CG2glAPpLeLqQI0M9YdLpt4yB4B9sD/oFbG2+k4WA70xAHEax+sQbaSKsrxhc= X-Received: by 2002:a17:90b:3807:b0:205:d746:93a0 with SMTP id mq7-20020a17090b380700b00205d74693a0mr3635933pjb.188.1664284124030; Tue, 27 Sep 2022 06:08:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 06:08:43 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-7-4844816c9808@baylibre.com> <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> In-Reply-To: <153dcb4f-4583-427e-83c7-bdd33e3b11aa@collabora.com> MIME-Version: 1.0 Date: Tue, 27 Sep 2022 06:08:43 -0700 Message-ID: Subject: Re: [PATCH v1 07/17] drm/mediatek: extract common functions from the mtk hdmi driver To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_060848_537595_A571252F X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Sep 2022 12:25, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Create a common "framework" that can be used to add support for >> different hdmi IPs within the mediatek range of products. >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile >> index d4d193f60271..008ec69da67b 100644 >> --- a/drivers/gpu/drm/mediatek/Makefile >> +++ b/drivers/gpu/drm/mediatek/Makefile >> @@ -22,7 +22,8 @@ obj-$(CONFIG_DRM_MEDIATEK) += mediatek-drm.o >> >> mediatek-drm-hdmi-objs := mtk_cec.o \ >> mtk_hdmi.o \ > >abcd ... mtk_hdmi_common.o goes here :-) > >> - mtk_hdmi_ddc.o >> + mtk_hdmi_ddc.o \ >> + mtk_hdmi_common.o \ >> >> obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> index 5cd05d4fe1a9..837d36ec4d64 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> @@ -32,187 +32,18 @@ >> #include >> >> #include "mtk_cec.h" >> -#include "mtk_hdmi.h" >> #include "mtk_hdmi_regs.h" >> +#include "mtk_hdmi_common.h" >> >> #define NCTS_BYTES 7 >> >> -enum mtk_hdmi_clk_id { >> - MTK_HDMI_CLK_HDMI_PIXEL, >> - MTK_HDMI_CLK_HDMI_PLL, >> - MTK_HDMI_CLK_AUD_BCLK, >> - MTK_HDMI_CLK_AUD_SPDIF, >> - MTK_HDMI_CLK_COUNT >> +const char * const mtk_hdmi_clk_names_mt8183[MTK_MT8183_HDMI_CLK_COUNT] = { > >Why MT8183? This can be either MT8167 or MT2701... or, IMO more appropriately, you >should name the IP version. >Example: MTK_HDMIV123_CLK_COUNT (I don't know what IP version would that be!). You're right, the naming isn't great. I'll ask mediatek if they have a good name that would regroup the "legacy" HDMI IP and the new IP in mt8195. Thx, Guillaume. > >> + [MTK_MT8183_HDMI_CLK_HDMI_PIXEL] = "pixel", >> + [MTK_MT8183_HDMI_CLK_HDMI_PLL] = "pll", >> + [MTK_MT8183_HDMI_CLK_AUD_BCLK] = "bclk", >> + [MTK_MT8183_HDMI_CLK_AUD_SPDIF] = "spdif", >> }; >> > >Regards, >Angelo > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel