From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1UDYbS-000592-FH
	for qemu-devel@nongnu.org; Thu, 07 Mar 2013 06:03:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1UDYbO-0000Aq-EZ
	for qemu-devel@nongnu.org; Thu, 07 Mar 2013 06:03:14 -0500
Received: from mail-oa0-f47.google.com ([209.85.219.47]:60213)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1UDYbO-0000Ab-A0
	for qemu-devel@nongnu.org; Thu, 07 Mar 2013 06:03:10 -0500
Received: by mail-oa0-f47.google.com with SMTP id o17so391040oag.34
	for <qemu-devel@nongnu.org>; Thu, 07 Mar 2013 03:03:09 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CABoDooPGx1ZJ_df+uTGim49oo2Epe_gv7gkzSgx=mPDj2NkHfg@mail.gmail.com>
References: <cover.1328280144.git.riku.voipio@linaro.org>
	<d0fd11ffd3e2cb65234da354f14d745e5fbfce67.1328280144.git.riku.voipio@linaro.org>
	<CABoDooPGx1ZJ_df+uTGim49oo2Epe_gv7gkzSgx=mPDj2NkHfg@mail.gmail.com>
Date: Thu, 7 Mar 2013 12:03:09 +0100
Message-ID: <CABoDooOSM8HrNz+AHE7Xm64kfShLdVFWg4OsNqJ-ss_np0Aevw@mail.gmail.com>
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now
 mandatory on all targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: riku.voipio@linaro.org
Cc: qemu-devel@nongnu.org

On Wed, Feb 8, 2012 at 10:46 AM, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> On Fri, Feb 3, 2012 at 3:49 PM,  <riku.voipio@linaro.org> wrote:
>> From: Riku Voipio <riku.voipio@linaro.org>
>>
>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>> ---
>>  linux-user/qemu.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
>> index 55ad9d8..30e2abd 100644
>> --- a/linux-user/qemu.h
>> +++ b/linux-user/qemu.h
>> @@ -123,10 +123,10 @@ typedef struct TaskState {
>>  #endif
>>  #if defined(TARGET_ARM) || defined(TARGET_M68K) || defined(TARGET_UNICORE32)
>>     /* Extra fields for semihosted binaries.  */
>> -    uint32_t stack_base;
>>     uint32_t heap_base;
>>     uint32_t heap_limit;
>>  #endif
>> +    uint32_t stack_base;
>
> Shouldn't this be abi_ulong instead of uint32_t?

Ping...

Yes it's more than a year old, but if Aarch64 support with semihosting
ever comes to life :)

Laurent

>>     int used; /* non zero if used */
>>     struct image_info *info;
>>     struct linux_binprm *bprm;
>
> Laurent