Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now mandatory on all targets

From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: riku.voipio@linaro.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now mandatory on all targets
Date: Wed, 8 Feb 2012 10:46:17 +0100	[thread overview]
Message-ID: <CABoDooPGx1ZJ_df+uTGim49oo2Epe_gv7gkzSgx=mPDj2NkHfg@mail.gmail.com> (raw)
In-Reply-To: <d0fd11ffd3e2cb65234da354f14d745e5fbfce67.1328280144.git.riku.voipio@linaro.org>

On Fri, Feb 3, 2012 at 3:49 PM,  <riku.voipio@linaro.org> wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
>  linux-user/qemu.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
> index 55ad9d8..30e2abd 100644
> --- a/linux-user/qemu.h
> +++ b/linux-user/qemu.h
> @@ -123,10 +123,10 @@ typedef struct TaskState {
>  #endif
>  #if defined(TARGET_ARM) || defined(TARGET_M68K) || defined(TARGET_UNICORE32)
>     /* Extra fields for semihosted binaries.  */
> -    uint32_t stack_base;
>     uint32_t heap_base;
>     uint32_t heap_limit;
>  #endif
> +    uint32_t stack_base;

Shouldn't this be abi_ulong instead of uint32_t?

>     int used; /* non zero if used */
>     struct image_info *info;
>     struct linux_binprm *bprm;

Laurent